From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Bill Meier Newsgroups: gmane.emacs.bugs Subject: Re: [PATCH] nt/gmake,defs, nt/nmake.defs Date: Sat, 19 Jan 2008 16:24:55 -0500 Message-ID: <47926AA7.3070804@newsguy.com> References: <200801152218.m0FMIjGx041292@member.newsguy.com> <47911D24.4010409@gnu.org> <4791D691.50406@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1200777942 9335 80.91.229.12 (19 Jan 2008 21:25:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Jan 2008 21:25:42 +0000 (UTC) To: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 19 22:26:01 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JGLCS-0000uR-3w for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2008 22:26:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGLC3-0006la-5Q for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Jan 2008 16:25:35 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JGLBp-0006gt-0X for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2008 16:25:21 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JGLBn-0006g4-53 for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2008 16:25:20 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JGLBm-0006fu-RW for bug-gnu-emacs@gnu.org; Sat, 19 Jan 2008 16:25:18 -0500 Original-Received: from smtp1.newsguy.com ([64.209.0.71]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JGLBf-0000mS-K5; Sat, 19 Jan 2008 16:25:11 -0500 Original-Received: from [12.75.233.197] (197.piscataway-02rh15rt.nj.dial-access.att.net [12.75.233.197]) (authenticated bits=0) by smtp1.newsguy.com (8.13.8/8.13.8) with ESMTP id m0JLP1YL059807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 19 Jan 2008 13:25:03 -0800 (PST) (envelope-from wmeier@newsguy.com) User-Agent: Thunderbird 2.0.0.9 (X11/20071115) In-Reply-To: <4791D691.50406@gnu.org> X-detected-kernel: by monty-python.gnu.org: FreeBSD 4.6-4.8 (RFC1323-) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:17379 Archived-At: OK: 1. A Windows 'mingw32-make install' (to other than the build directories) ends up installing files such as those in emacs/etc/ and such as the .el files without preserving the date/time of these (source) files. Although this may not cause any direct problems, IMHO it's a bug in the install. I note from a a quick look at the *nix install scripts that the *nix install does preserve the file date/times (since tar .... is used to copy the files [at least for the .el files]). (As an aside, I also note that the *nix install also removes any .cvsignore & etc files from the install destination directories as part of the install; I'll leave that to another time). 2. I'm happy to submit a proposed fix which will preserve the file date/times during an install (if cp implements -p). I found after some further testing that my original fix did not work for all the files installed (specifically: the .el files) since the lisp/makefile.w32-in uses 'cp' (and not '$(CP)' for the install of the .el files & etc. I'm inclined to do the fix as follows (comments welcome): 1. In lisp/makefile.w32-in: For the install target: change 'cp -f' to '($CP)' 2. In configure.bat, gmake.defs and nmake.defs: Add appropiate code so as to test for the availability of 'cp -p' and to define CP (and CP_DIR) to include (or not) the '-p' option. This approach changes all usage of CP and CP_DIR in the makefile.w32-in files to preserve file date/times; A review of the usage of $(CP) and some testing suggests this won't be a problem. An alternative approach would be to change just the install usage of cp; Eg: by defining a new macro (say) 'CPI=cp -p -f' (if 'cp -p' implemented). In this case the cp usage for install would need to be changed to use $(CPI) in some number of the various makefile.w32-in files. Thoughts ? Thanks Bill Meier