From: Clemens <clemera@posteo.net>
To: Juri Linkov <juri@linkov.net>
Cc: 45780@debbugs.gnu.org
Subject: bug#45780: 28.0.50; [PATCH] Face used for affixation function annotations
Date: Thu, 14 Jan 2021 18:21:00 +0100 [thread overview]
Message-ID: <4779a90d-a475-0490-7de2-de072efe64f5@posteo.net> (raw)
In-Reply-To: <875z3z50if.fsf@mail.linkov.net>
> Do you want to use the completion-annotations face conditionally only
> for annotations, i.e. when only the suffix is provided by the client?
> Because when a prefix is provided as well, then it's not an annotation
> anymore, so the completion-annotations face is not applicable to prefixes.
I see, personally I think of all strings besides the completions
themselves as annotations ;) Makes sense to do it only for the suffix then.
> Doing this is not something new, we already have the same logic
> in minibuffer-message:
>
> (unless (or (null minibuffer-message-properties)
> ;; Don't overwrite the face properties the caller has set
> (text-properties-at 0 message))
> (setq message (apply #'propertize message minibuffer-message-properties)))
>
> Is this logic suitable for completion-annotations?
I guess this could also be used, the version I posted earlier only
checks for the face property and then also check the whole string:
(if (text-property-not-all 0 (length str) 'face nil str)
str
(propertize str 'face face))
When only the face matters my proposed version might be better?
next prev parent reply other threads:[~2021-01-14 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 12:38 bug#45780: 28.0.50; [PATCH] Face used for affixation function annotations Clemens
2021-01-11 18:38 ` Juri Linkov
2021-01-11 20:07 ` Clemens
2021-01-12 18:30 ` Juri Linkov
2021-01-13 18:06 ` Clemens
2021-01-14 9:00 ` Juri Linkov
2021-01-14 17:21 ` Clemens [this message]
2021-01-14 18:59 ` Juri Linkov
2021-01-14 19:43 ` Clemens
2021-01-25 18:02 ` Juri Linkov
2021-01-30 19:13 ` Juri Linkov
2021-01-31 9:36 ` Clemens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4779a90d-a475-0490-7de2-de072efe64f5@posteo.net \
--to=clemera@posteo.net \
--cc=45780@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).