From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Roland Winkler" Newsgroups: gmane.emacs.bugs Subject: bug#44503: 27.1; image-scroll-up and image-scroll-down Date: Sat, 7 Nov 2020 09:16:22 -0600 Message-ID: <47686.12087.468202.24486@gargle.gargle.HOWL> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6520"; mail-complaints-to="usenet@ciao.gmane.io" To: 44503@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 07 16:17:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbPxx-0001Xu-R5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 16:17:21 +0100 Original-Received: from localhost ([::1]:49862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbPxw-0002Lo-Sx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 10:17:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbPxg-0002LT-3g for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:17:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbPxe-0003sQ-Gl for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbPxe-0000C3-BT for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Roland Winkler" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Nov 2020 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44503 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.1604762209717 (code B ref -1); Sat, 07 Nov 2020 15:17:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Nov 2020 15:16:49 +0000 Original-Received: from localhost ([127.0.0.1]:59079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbPxR-0000BV-4a for submit@debbugs.gnu.org; Sat, 07 Nov 2020 10:16:49 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:38148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbPxQ-0000BO-4a for submit@debbugs.gnu.org; Sat, 07 Nov 2020 10:16:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbPxP-00029O-VI for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:16:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59817) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbPxP-0003mH-Ls for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:16:47 -0500 Original-Received: from [2602:30a:2e52:d720:65b7:1416:12e7:8bfb] (port=48280 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1kbPxO-0001er-Qw for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:16:47 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192839 Archived-At: My understanding of the doc strings of image-scroll-up and image-scroll-down is that the argument N should be a number, nil, or `-'." However, these commands use (interactive "P") with prefix-numeric-value inside the body of these commands. I suggest to document this behavior. (I guess it is not very clean to use prefix-numeric-value inside the body of these commands. But changing this behavior likely will break existing code that uses these commands.) I realized this when I looked at doc-view's scrolling commands doc-view-scroll-up-or-next-page and doc-view-scroll-down-or-previous-page that likewise use (interactive "P"), contrary, to what the docstrings of these commands say, and I was surprised that this gives a meaningful behavior. So these docstrings probably should be updated, too. In GNU Emacs 27.1 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.18.9) of 2020-08-31 built on regnitz Windowing system distributor 'The X.Org Foundation', version 11.0.11804000 System Description: Ubuntu 16.04.7 LTS