From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#33567: Syntactic fontification of diff hunks Date: Tue, 18 Dec 2018 17:55:15 +0200 Message-ID: <47546098-59ef-ae43-878a-fd225b60ec99@yandex.ru> References: <878t18j4is.fsf@mail.linkov.net> <83a7lobemr.fsf@gnu.org> <87a7lnv6ex.fsf@mail.linkov.net> <83pnuj9kb8.fsf@gnu.org> <875zwajh6c.fsf@mail.linkov.net> <837egpagko.fsf@gnu.org> <87k1koygvm.fsf@mail.linkov.net> <83r2ew8mfx.fsf@gnu.org> <87va475y1m.fsf@mail.linkov.net> <87mupafi73.fsf@mail.linkov.net> <834lbgh3n7.fsf@gnu.org> <87h8fduis0.fsf@mail.linkov.net> <83d0q0dtc0.fsf@gnu.org> <877eg7sq8a.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1545148792 11674 195.159.176.226 (18 Dec 2018 15:59:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Dec 2018 15:59:52 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Thunderbird/64.0 To: 33567@debbugs.gnu.org, juri@linkov.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 18 16:59:47 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZHmb-0002sO-Cy for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Dec 2018 16:59:45 +0100 Original-Received: from localhost ([::1]:54761 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZHoh-0000El-VE for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Dec 2018 11:01:55 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gZHj5-0004gA-Jz for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 10:56:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gZHj0-0007tz-7m for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 10:56:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gZHj0-0007tu-1W for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 10:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gZHiz-0006Ug-UC for bug-gnu-emacs@gnu.org; Tue, 18 Dec 2018 10:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Dec 2018 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33567-submit@debbugs.gnu.org id=B33567.154514852824914 (code B ref 33567); Tue, 18 Dec 2018 15:56:01 +0000 Original-Received: (at 33567) by debbugs.gnu.org; 18 Dec 2018 15:55:28 +0000 Original-Received: from localhost ([127.0.0.1]:53593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZHiR-0006Tm-Nf for submit@debbugs.gnu.org; Tue, 18 Dec 2018 10:55:27 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:53913) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gZHiP-0006TY-K0 for 33567@debbugs.gnu.org; Tue, 18 Dec 2018 10:55:25 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id d15so3174927wmb.3 for <33567@debbugs.gnu.org>; Tue, 18 Dec 2018 07:55:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CN1MoK9QtphAPIMfbdDXAbvLuZqrMgVT/gfV9bPaa94=; b=d3i3ZLBs7zEPBgTI6jTwh4MmEU1/KXbBnWc3LCP0oR6CSThamoHHNB0LldFfDc79vI 8KRYCmiY9Eyn0hglcXucDJZv17JPVIREBG5FzRcsfJs4+0lsLPWqqOmj/V0EhZFfpcxM UNrWIaxssylqlvC4tqdZpvMbQ53eeGQGbaD2DCqtzeWw/cQID5QbUNOIAciob+0FtjrH exao9uSH6inYT3JJliMY34S291+bnrxDRDnJarKrbzmox8taQnlnGRQ+n6wSW6ZezvKH f/X+Tk+/xPCHFjH7Hs6HXznsjwqFlj8rv8a+ii1zsER5TcuY1hNnm+gmqhe0enNyKL2r /y6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CN1MoK9QtphAPIMfbdDXAbvLuZqrMgVT/gfV9bPaa94=; b=PZJC6P4RYefnZkO49EjmbF4PntHod+puRY1oD7m6cYv7b1S4bro/W7onq3oz8OAWoS F3Dk37vfNe/NChrowxFsszBxAVry6aAxgJEOAgW0kzCy5wfJe5/qAdjTdGyf3JY3HVm/ xj/k7IAqzyZepx37QJrzT7DwROC5kpTMrGwqbCN3mxJHjr9f3TfyandYCZZIXdKDyE4y pkWjcg6mI27gIiGTaiTknmIWiCSdc/CVXvisP2DtcA3fzodVhsk6Tkka11Qc6yhdvo3p 6yw123pTA78dVBb8j8nvV9nEHAz8eSCuQDBcZLnuC8xjf9jt3cG8FycOTZzTSv4/YnG8 AFlg== X-Gm-Message-State: AA+aEWakLRz0pBQ1fcTWye7C0eESZ9YMZD9ywaciO1RXF/31i2Hz36Ev AlxD82tZl/4HTqFayPg5+5OyMPVB X-Google-Smtp-Source: AFSGD/WpR36b8w1Qb+tfcJV4tm2XJdhW6IY2mNvKGdRInF/xy4wmm8BBdp4y21IRHslLMTvMVlWSgw== X-Received: by 2002:a1c:cbcb:: with SMTP id b194mr3384255wmg.64.1545148519600; Tue, 18 Dec 2018 07:55:19 -0800 (PST) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id q3sm5306949wrn.84.2018.12.18.07.55.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Dec 2018 07:55:17 -0800 (PST) In-Reply-To: <877eg7sq8a.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153557 Archived-At: On 18.12.2018 1:11, Juri Linkov wrote: >>> Also with more highlighting in diff hunks now diff indicators need more >>> distinctive colors that I also tested. >> >> Thanks, this LGTM. > > Pushed to master and closed. Juri, thank you. Looks like an helpful feature. Have you considered bringing over the "default" face foregrounds as well, though, not just the special highlighting? My brain sees syntax highlighting in some places and keeps wanting to interpret the green and red text and something syntactically meaningful as well. Maybe we could add extra ancestors for diff-added and diff-removed faces, with default foregrounds, and use them for the base highlighting of diff chunks, aside from +'s and -'s. Another thing that messes up the display a bit, is that comments and docstrings also have customized backgrounds in my theme, but that's less essential and seems harder to fix.