From: Vincenzo Pupillo <v.pupillo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 72966@debbugs.gnu.org
Subject: bug#72966: 30.0.90; [PATCH] php-ts-mode: custom php.ini config for the built-in php webserver
Date: Mon, 02 Sep 2024 16:52:24 +0200 [thread overview]
Message-ID: <4744299.vXUDI8C0e8@fedora> (raw)
In-Reply-To: <86bk16877q.fsf@gnu.org>
Ok, thanks.
I will fix ASAP.
Vincenzo.
In data lunedì 2 settembre 2024 16:23:53 CEST, Eli Zaretskii ha scritto:
> > From: Vincenzo Pupillo <v.pupillo@gmail.com>
> > Date: Mon, 02 Sep 2024 15:29:23 +0200
> >
> > Ciao,
> > this patch adds a new CONFIG attribute to 'php-ts-mode-run-php-webserver'
> > that allows you to specify an alternative php.ini file to the default (or
> > whatever is specified in 'php-ts-mode-php-config').
>
> Thanks.
>
> > -(defun php-ts-mode-run-php-webserver (&optional port hostname
> > document-root -
> > router-script num-of-workers) +(defun php-ts-mode-run-php-webserver
> > (&optional port
> > + hostname
> > + document-root
> > + router-script
> > + config
> > + num-of-workers)
> >
> > "Run PHP built-in web server.
>
> This changes a public API in backward-incompatible way, something we
> don't do, because it could break someone's code out there. (It is
> true that php-ts-mode was introduced in Emacs 30, but that version is
> already in pretest and will be released soon, so I don't think we can
> change this there, either.)
>
> So please find a backward-compatible way of adding this feature,
> perhaps add the new CONFIG argument as the last one?
>
> Also, I think this needs a NEWS entry describing the change in
> behavior.
next prev parent reply other threads:[~2024-09-02 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 13:29 bug#72966: 30.0.90; [PATCH] php-ts-mode: custom php.ini config for the built-in php webserver Vincenzo Pupillo
2024-09-02 14:23 ` Eli Zaretskii
2024-09-02 14:52 ` Vincenzo Pupillo [this message]
2024-09-05 19:16 ` Vincenzo Pupillo
2024-09-08 6:48 ` Eli Zaretskii
2024-09-08 10:52 ` Vincenzo Pupillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4744299.vXUDI8C0e8@fedora \
--to=v.pupillo@gmail.com \
--cc=72966@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).