unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* win32 emacs 22.1 crashes in longlines mode + outline minor mode
@ 2007-11-13  9:51 Dmitry Bolshakov
  2007-11-13 20:34 ` Juanma Barranquero
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Dmitry Bolshakov @ 2007-11-13  9:51 UTC (permalink / raw)
  To: bug-gnu-emacs


[-- Attachment #1.1: Type: text/plain, Size: 299 bytes --]

Win xp

GNU Emacs 22.1.1 (i386-mingw-nt5.1.2600) of 2007-06-02 on RELEASE

 

1. Open text file

2.

M-x longlines-mode

M-x longlines-show-hard-newlines

M-x outline-minor-mode

M-x hide-entry

"An unhandled win32 exception occurred in emacs.exe [3780]"

 

With best regards

Dmitry Bolshakov

 


[-- Attachment #1.2: Type: text/html, Size: 3899 bytes --]

[-- Attachment #2: text.txt --]
[-- Type: text/plain, Size: 2010 bytes --]

* H1
just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text 

* H2
just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text 

* H3
just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text just text 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: win32 emacs 22.1 crashes in longlines mode + outline minor mode
  2007-11-13  9:51 win32 emacs 22.1 crashes in longlines mode + outline minor mode Dmitry Bolshakov
@ 2007-11-13 20:34 ` Juanma Barranquero
  2007-11-13 21:13 ` Jason Rumney
  2007-11-14  9:03 ` martin rudalics
  2 siblings, 0 replies; 4+ messages in thread
From: Juanma Barranquero @ 2007-11-13 20:34 UTC (permalink / raw)
  To: Dmitry Bolshakov; +Cc: bug-gnu-emacs

On 11/13/07, Dmitry Bolshakov <dmitry.bolshakov@bridge-quest.com> wrote:

> "An unhandled win32 exception occurred in emacs.exe [3780]"

It does not happen in EMACS_22_BASE or the trunk.

             Juanma




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: win32 emacs 22.1 crashes in longlines mode + outline minor mode
  2007-11-13  9:51 win32 emacs 22.1 crashes in longlines mode + outline minor mode Dmitry Bolshakov
  2007-11-13 20:34 ` Juanma Barranquero
@ 2007-11-13 21:13 ` Jason Rumney
  2007-11-14  9:03 ` martin rudalics
  2 siblings, 0 replies; 4+ messages in thread
From: Jason Rumney @ 2007-11-13 21:13 UTC (permalink / raw)
  To: Dmitry Bolshakov; +Cc: bug-gnu-emacs

Dmitry Bolshakov wrote:
>
> 1. Open text file
>
> 2.
>
> M-x longlines-mode
>
> M-x longlines-show-hard-newlines
>
> M-x outline-minor-mode
>
> M-x hide-entry
>
> “An unhandled win32 exception occurred in emacs.exe [3780]”
>

Thanks for the bug report. This appears to be the same bug as previously
reported:

http://lists.gnu.org/archive/html/emacs-devel/2007-09/msg01996.html
http://lists.gnu.org/archive/html/emacs-devel/2007-10/msg00339.html

If so, it has been fixed already. It would be good if you can try
building Emacs yourself from CVS (the EMACS_22_BASE branch), or try the
pretest for Emacs 22.2 when it comes out soon, to confirm that this is
the case before 22.2 is released.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: win32 emacs 22.1 crashes in longlines mode + outline minor mode
  2007-11-13  9:51 win32 emacs 22.1 crashes in longlines mode + outline minor mode Dmitry Bolshakov
  2007-11-13 20:34 ` Juanma Barranquero
  2007-11-13 21:13 ` Jason Rumney
@ 2007-11-14  9:03 ` martin rudalics
  2 siblings, 0 replies; 4+ messages in thread
From: martin rudalics @ 2007-11-14  9:03 UTC (permalink / raw)
  To: Dmitry Bolshakov; +Cc: bug-gnu-emacs

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

 > 1. Open text file
 >
 > 2.
 >
 > M-x longlines-mode
 >
 > M-x longlines-show-hard-newlines

At the time I'm here the buffer is already modified since modification
hooks are not inhibited in `longlines-show-hard-newlines', thus calling
`longlines-after-change-function' which subsequently causes to run
`longlines-post-command-function' which runs `longlines-show-region' a
second time _without_ saving the buffer-modified state though, ...

The attached patch should handle this.

[-- Attachment #2: longlines.patch --]
[-- Type: text/plain, Size: 1650 bytes --]

*** longlines.el.~1.40.~	Fri Nov  2 09:54:54 2007
--- longlines.el	Wed Nov 14 09:42:18 2007
***************
*** 220,226 ****
    (let* ((pmin (min beg end))
           (pmax (max beg end))
           (pos (text-property-not-all pmin pmax 'hard nil))
!          (inhibit-read-only t))
      (while pos
        (put-text-property pos (1+ pos) 'display
                           (copy-sequence longlines-show-effect))
--- 220,227 ----
    (let* ((pmin (min beg end))
           (pmax (max beg end))
           (pos (text-property-not-all pmin pmax 'hard nil))
! 	 (inhibit-read-only t)
! 	 (inhibit-modification-hooks t))
      (while pos
        (put-text-property pos (1+ pos) 'display
                           (copy-sequence longlines-show-effect))
***************
*** 230,239 ****
    "Make hard newlines invisible again."
    (interactive)
    (setq longlines-showing nil)
!   (let ((pos (text-property-not-all (point-min) (point-max) 'hard nil)))
      (while pos
        (remove-text-properties pos (1+ pos) '(display))
!       (setq pos (text-property-not-all (1+ pos) (point-max) 'hard nil)))))

  ;; Wrapping the paragraphs.

--- 231,245 ----
    "Make hard newlines invisible again."
    (interactive)
    (setq longlines-showing nil)
!   (let ((pos (text-property-not-all (point-min) (point-max) 'hard nil))
! 	(buffer-undo-list t)
! 	(mod (buffer-modified-p))
! 	(inhibit-read-only t)
! 	(inhibit-modification-hooks t))
      (while pos
        (remove-text-properties pos (1+ pos) '(display))
!       (setq pos (text-property-not-all (1+ pos) (point-max) 'hard nil)))
!     (set-buffer-modified-p mod)))

  ;; Wrapping the paragraphs.


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-14  9:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-13  9:51 win32 emacs 22.1 crashes in longlines mode + outline minor mode Dmitry Bolshakov
2007-11-13 20:34 ` Juanma Barranquero
2007-11-13 21:13 ` Jason Rumney
2007-11-14  9:03 ` martin rudalics

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).