From: Jim Porter <jporterbugs@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 53715@debbugs.gnu.org
Subject: bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell
Date: Wed, 2 Feb 2022 11:41:33 -0800 [thread overview]
Message-ID: <4733b4db-705c-2b52-e1e6-68b0902f87d3@gmail.com> (raw)
In-Reply-To: <871r0lrvg1.fsf@gnus.org>
On 2/2/2022 10:10 AM, Lars Ingebrigtsen wrote:
> These patches seem to lead to a number of tests failing:
>
> Test eshell-test/last-result-var2 condition:
> (void-variable eshell-last-async-proc)
> FAILED 22/34 eshell-test/last-result-var2 (0.001074 sec) at lisp/eshell/eshell-tests.el:164
> passed 23/34 eshell-test/lisp-command (0.000350 sec)
> passed 24/34 eshell-test/lisp-command-args (0.000308 sec)
Sorry, I forgot to mention that since the second patch updates a
defsubst (`eshell-interactive-process'), you'll need to recompile all
the files that might use it, so `make boostrap' or `touch
lisp/eshell/*.el test/lisp/eshell/*.el && make'. That should make these
tests pass.
Once this merges, I'll send a message to emacs-devel to let everyone
know to recompile these files so there are no surprises when they try to
use Eshell later on.
next prev parent reply other threads:[~2022-02-02 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 3:32 bug#53715: 29.0.50; [PATCH] Improve correctness of pipelines in Eshell Jim Porter
2022-02-02 18:10 ` Lars Ingebrigtsen
2022-02-02 19:41 ` Jim Porter [this message]
2022-02-02 19:49 ` Lars Ingebrigtsen
2022-02-02 21:01 ` Jim Porter
2022-02-03 2:35 ` Jim Porter
2022-02-03 19:03 ` Lars Ingebrigtsen
2022-02-05 6:51 ` Jim Porter
2022-02-05 6:59 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4733b4db-705c-2b52-e1e6-68b0902f87d3@gmail.com \
--to=jporterbugs@gmail.com \
--cc=53715@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).