From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: JD Smith Newsgroups: gmane.emacs.bugs Subject: bug#68236: [PATCH] help.el: allow help-quick to use local commands/quick-sections Date: Wed, 10 Jan 2024 17:49:24 -0500 Message-ID: <4731097C-D870-439C-B012-98ADA2AEB330@gmail.com> References: <83sf35mb8g.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.300.61.1.2\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_A633408E-8741-4CFC-987B-DD7B446D5F07" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18244"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Philip Kaludercic , 68236@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 10 23:52:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNhQs-0004Wj-L2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jan 2024 23:52:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNhOr-0006f8-48; Wed, 10 Jan 2024 17:50:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNhOg-0006HG-2x for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 17:50:07 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNhOd-0005hf-Uv for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 17:50:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNhOc-0005Z7-GV for bug-gnu-emacs@gnu.org; Wed, 10 Jan 2024 17:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: JD Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jan 2024 22:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68236 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68236-submit@debbugs.gnu.org id=B68236.170492698221356 (code B ref 68236); Wed, 10 Jan 2024 22:50:02 +0000 Original-Received: (at 68236) by debbugs.gnu.org; 10 Jan 2024 22:49:42 +0000 Original-Received: from localhost ([127.0.0.1]:43513 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhOI-0005YO-4e for submit@debbugs.gnu.org; Wed, 10 Jan 2024 17:49:42 -0500 Original-Received: from mail-yw1-x1130.google.com ([2607:f8b0:4864:20::1130]:45446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNhOG-0005YA-Lm for 68236@debbugs.gnu.org; Wed, 10 Jan 2024 17:49:41 -0500 Original-Received: by mail-yw1-x1130.google.com with SMTP id 00721157ae682-5e734d6cbe4so39368257b3.3 for <68236@debbugs.gnu.org>; Wed, 10 Jan 2024 14:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704926976; x=1705531776; darn=debbugs.gnu.org; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=MbhR2rucY4KO0BJ+gckbbP+kCrPCYBa/ikZAs85//tY=; b=R39aul7JuXsH3WH55UVxcVax8Spn2tbpcWt41peoOvSho3M8LfFGtrNnp8Ltjp2duR w0vObKFXWnfs8DoBFAgMRFcAX0ZpJEMIZbyFA8acYumEvtc8PE8myWlkrEcONEzlrYA6 Nlcy9wZjlbsSKhHfPA13I0iEz2NODPnyCfK0I416txDZDcDcQDCcm3cflNP1drPYosRS Yk1Qt/P0FzJdOJcunw46lproNfYbOaNm9hzj1NL3hG7BmznhA6eFWg1KbqtQjtXRPK5G UzinUzaZc+3x33XRqgANiMGykRcLNfXx3i2V5Ztcv0I6U6QqHqQnnubky4eFCR67dPxE vDEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704926976; x=1705531776; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MbhR2rucY4KO0BJ+gckbbP+kCrPCYBa/ikZAs85//tY=; b=RSmznP/eV2jCJcyj5yVHK57PrKMRmInjXmut9cmAUrnY9lENWOyQcquxtVq7ESBvUx 7hzGR1ZHNU5V81IMI6aNlo/RY+hBBA8s9x+iFIPxfi8Ic5kAPjl3ANVm+5DGs74gNbNt Ev8cd12llyRUmU/YO3bQJZx7epXTfVpTxJ1ZpjUwSVqCETHueF7SzCg1WDGCprTwgojI 2ntsKfFXCI2BHTOFH8AxrNVLqKINrB+Y+u2j4Mly7Iv3ZVCn1UvR3IgmZCdhKIfTvyly 2DX+Mkee0+3OeAT82SaGFn08/tXd2dEsMgoiIaBJ8CFgOqUo85EaPzCktwrti4cRE+Sj NjDg== X-Gm-Message-State: AOJu0YwKly4gxRdcRRF+WMFvDxWg3dE0Gqeuqn7MFkITrt1cDQnGvqSY y3rqdDI3Zsu01TQIUxXU3EM= X-Google-Smtp-Source: AGHT+IH+hBEBHUfSUMG2WxFAKb1/Cw6gnPH4v9yye/ZBLid+GjpM4OI5JAjxlKw+uunHQgB9woORTg== X-Received: by 2002:a05:690c:24a:b0:5f1:2c90:405a with SMTP id ba10-20020a05690c024a00b005f12c90405amr325957ywb.53.1704926976115; Wed, 10 Jan 2024 14:49:36 -0800 (PST) Original-Received: from smtpclient.apple ([131.183.131.33]) by smtp.gmail.com with ESMTPSA id q67-20020a0de746000000b005869ca8da8esm1926750ywe.146.2024.01.10.14.49.35 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Jan 2024 14:49:35 -0800 (PST) In-Reply-To: <83sf35mb8g.fsf@gnu.org> X-Mailer: Apple Mail (2.3774.300.61.1.2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277846 Archived-At: --Apple-Mail=_A633408E-8741-4CFC-987B-DD7B446D5F07 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 With my original fix of just allowing buffer-local binding to appear in = help-quick, I fully intended to disable most of the global bindings (I = don=E2=80=99t need a reminder of C-x C-f) and expected it to be = therefore a smaller and easier to parse mode-specific list. =20 Since the user has to take the initiative to modify = `help-quick-sections=E2=80=99 in my simple approach, I do not see = =E2=80=9Closs of global bindings=E2=80=9D as a concern; that=E2=80=99s a = feature, not a bug, from my perspective. > On Jan 10, 2024, at 10:58=E2=80=AFAM, Eli Zaretskii = wrote: >=20 >> From: JD Smith >> Date: Wed, 10 Jan 2024 10:46:22 -0500 >> Cc: Eli Zaretskii , 68236@debbugs.gnu.org, >> Philip Kaludercic >>=20 >> But what about instead of a separate command to remember, just = creating an (optional) section in the existing help-quick popup, for = local commands? where-is-internal would consult the global keymap for = the global commands, and the current buffer=E2=80=99s keymap for the = locals. >=20 > I think we should be careful not to add too much to what these > commands display, since otherwise we'd reinvent "C-h b" again. >=20 > The whole purpose of help-quick is to present a small list of the most > useful commands and their bindings, and do it in a small window. As > soon as the buffer is long enough to require scrolling, I think we > will have lost. --Apple-Mail=_A633408E-8741-4CFC-987B-DD7B446D5F07 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 With my = original fix of just allowing buffer-local binding to appear in = help-quick, I fully intended to disable most of the global bindings (I = don=E2=80=99t need a reminder of C-x C-f) and expected it to be = therefore  a smaller and easier to parse mode-specific list. =  

Since the user has to take the initiative to = modify `help-quick-sections=E2=80=99 in my = simple approach, I do not see =E2=80=9Closs of global bindings=E2=80=9D = as a concern; that=E2=80=99s a feature, not a bug, from my = perspective.


On Jan 10, 2024, at 10:58=E2=80=AFAM, Eli Zaretskii = <eliz@gnu.org> wrote:

From: JD Smith <jdtsmith@gmail.com>
Date: Wed, 10 = Jan 2024 10:46:22 -0500
Cc: Eli Zaretskii <eliz@gnu.org>, = 68236@debbugs.gnu.org,
Philip Kaludercic = <philipk@posteo.net>

But what about instead of a separate = command to remember, just creating an (optional) section in the existing = help-quick popup, for local commands?  where-is-internal would = consult the global keymap for the global commands, and the current = buffer=E2=80=99s keymap for the locals.

I think we = should be careful not to add too much to what these
commands display, = since otherwise we'd reinvent "C-h b" again.

The whole purpose of = help-quick is to present a small list of the most
useful commands and = their bindings, and do it in a small window.  As
soon as the = buffer is long enough to require scrolling, I think we
will have = lost.

= --Apple-Mail=_A633408E-8741-4CFC-987B-DD7B446D5F07--