From: martin rudalics <rudalics@gmx.at>
To: Glenn Morris <rgm@gnu.org>
Cc: bug-gnu-emacs@gnu.org, dashteacup@insightbb.com
Subject: Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t
Date: Sat, 20 Oct 2007 11:45:58 +0200 [thread overview]
Message-ID: <4719CE56.6020301@gmx.at> (raw)
In-Reply-To: <wufy07uh3d.fsf@fencepost.gnu.org>
> emacs -Q -f make-frame
> C-h f find-file
> C-x 0
> q
>
> -> frame gets iconified (or deleted if view-remove-frame-by-deleting
> is non-nil). Burying the help buffer and leaving the frame alone
> (since it was created manually) would seem like the Right Thing here.
Yes. I could create an additional `view-return-to-alist' element like
'delete-window-but-not-frame and not iconify/kill the frame in that
case. Alternatively, I could, in `view-mode-exit' do
((not (eq old-buf-info t)) nil) ; Not case 2, do nothing.
((not (one-window-p t)) (delete-window))
((not pop-up-frames) (bury-buffer)) ; <--- BURY BUFFER HERE
((not (eq frame (next-frame)))
;; Not the only frame, so can safely be removed.
but this would obviously fail for users with `pop-up-frames' non-nil.
Unfortunately, fiddling around with C-x 0 and C-x 1 will likely create
other cases that cannot be handled easily. C-x 2 on a help window is
another point of concern. Finally, I have little experience with
cloned Help buffers.
> The second problem can basically be summarized as quit only working
> once. Eg:
>
> emacs -Q
> C-h find-file
> C-x 1
> C-x b *Help*
> q
>
> -> "q" has no effect at all
I cannot reproduce this, my Emacs has "q" display *scratch* instead.
This is set up in help-mode's
(defun help-mode ()
...
(setq view-exit-action
(lambda (buffer)
(with-current-buffer buffer
;; Use `with-current-buffer' to assert that `bury-buffer'
;; removes buffer from the selected window. Leave it to
;; `view-mode-exit' to delete the associated window(s).
(bury-buffer))))
(run-mode-hooks 'help-mode-hook))
Can you investigate why this fails for you?
next prev parent reply other threads:[~2007-10-20 9:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D64B7FD7-2C5F-4A87-8F0B-61EB47217262@insightbb.com>
2007-10-13 17:28 ` View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t David Reitter
2007-10-14 8:42 ` martin rudalics
2007-10-17 20:58 ` Glenn Morris
2007-10-18 8:20 ` martin rudalics
2007-10-18 16:05 ` Drew Adams
2007-10-18 22:01 ` martin rudalics
2007-10-18 22:58 ` Drew Adams
2007-10-19 8:23 ` martin rudalics
2007-10-19 15:17 ` Drew Adams
2007-10-20 9:45 ` martin rudalics
2007-10-18 18:27 ` Glenn Morris
2007-10-18 22:03 ` martin rudalics
2007-10-18 23:44 ` Glenn Morris
2007-10-19 8:14 ` martin rudalics
2007-10-19 17:52 ` Glenn Morris
2007-10-20 9:45 ` martin rudalics [this message]
2007-10-23 23:30 ` Glenn Morris
2007-10-24 6:32 ` martin rudalics
2007-10-22 21:45 ` David Reitter
2007-11-29 9:05 ` David Reitter
2007-11-29 10:22 ` martin rudalics
[not found] ` <mailman.4303.1196332542.18990.bug-gnu-emacs@gnu.org>
2007-12-01 8:01 ` David Reitter
2007-12-01 9:20 ` martin rudalics
2007-12-01 14:44 ` David Reitter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4719CE56.6020301@gmx.at \
--to=rudalics@gmx.at \
--cc=bug-gnu-emacs@gnu.org \
--cc=dashteacup@insightbb.com \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).