unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Noam Postavsky <npostavs@users.sourceforge.net>,
	Ilya Khaprov <ilya.khaprov@publitechs.com>
Cc: 28774@debbugs.gnu.org
Subject: bug#28774: Master, emacs-26: Can't add text property to built-in function name.
Date: Tue, 10 Oct 2017 07:01:52 -0700 (PDT)	[thread overview]
Message-ID: <46ed09ff-2c97-49ac-8885-a6d367bd5a89@default> (raw)
In-Reply-To: <877ew3cngq.fsf@users.sourceforge.net>

> It seems ido-completions relies on (format "%s" str) to return a copy of
> str.  This fixes it:

If `format' no longer always copies STR in this context then
its doc should be updated, I think.

This:

 Format a string out of a format-string and arguments.
 The first argument is a format control string.
 The other arguments are substituted into it to make the
 result, a string.

suggests that it creates a new string, or at most reuses
the format string (e.g., "%s"), modifying it by substituting
STR for %s in it.  If in fact it can sometimes simply return
STR then this should be mentioned explicitly, to avoid confusion.

(And why was this change made?  Was it just to save a string
copy?)

This is an incompatible Lisp change, if it is new.  In that
case, it should be documented as such.





  reply	other threads:[~2017-10-10 14:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-10  7:57 bug#28774: Master, emacs-26: Can't add text property to built-in function name Ilya Khaprov
2017-10-10 10:21 ` Noam Postavsky
2017-10-10 14:01   ` Drew Adams [this message]
2017-10-10 14:12     ` Noam Postavsky
2017-10-12  0:56   ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46ed09ff-2c97-49ac-8885-a6d367bd5a89@default \
    --to=drew.adams@oracle.com \
    --cc=28774@debbugs.gnu.org \
    --cc=ilya.khaprov@publitechs.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).