From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#60845: 30.0.50; [PATCH] Add tests for Eshell interactive completion (and fix a bug in it) Date: Tue, 5 Sep 2023 17:47:06 -0700 Message-ID: <46c56cb6-deff-bc8f-7d29-9401b7d261b1@gmail.com> References: <2b75d4d4-0533-2182-6da8-413391577bf5@gmail.com> <40d31b3d-d429-5a48-02bc-a3c1e4a1d903@gmail.com> <8f725450-1158-67de-7a0f-d550d867e084@gmail.com> <990abf69-d2f9-7582-c4dd-fd6bdebf04b3@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12850"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60845@debbugs.gnu.org, Stefan Monnier To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 02:48:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdgiV-0003Co-C6 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 02:48:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdgiA-0004kv-ST; Tue, 05 Sep 2023 20:48:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdgi9-0004kl-DZ for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 20:48:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdgi9-0006Zd-5r for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 20:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdgi9-00042u-RN for bug-gnu-emacs@gnu.org; Tue, 05 Sep 2023 20:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 00:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60845-submit@debbugs.gnu.org id=B60845.169396123615331 (code B ref 60845); Wed, 06 Sep 2023 00:48:01 +0000 Original-Received: (at 60845) by debbugs.gnu.org; 6 Sep 2023 00:47:16 +0000 Original-Received: from localhost ([127.0.0.1]:60083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdghQ-0003zD-0l for submit@debbugs.gnu.org; Tue, 05 Sep 2023 20:47:16 -0400 Original-Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:45400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdghN-0003yz-PY for 60845@debbugs.gnu.org; Tue, 05 Sep 2023 20:47:14 -0400 Original-Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-68a41031768so2020721b3a.3 for <60845@debbugs.gnu.org>; Tue, 05 Sep 2023 17:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693961227; x=1694566027; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=jXumc14ktdfE0zEuogrNKkcfaJr/RaVfektbcVXwHlE=; b=G048GpeAK3rzWF7jMcfr39JQ3q+nQTvwGI06QmzNK7l6fHt2qV63/dYnsVQ6yW3Rhg GHx7H3ivs5Dmi55P6/1u0wlu5RwfAqms+iNlYF/IAor8nV9TIaC8+8mwnOQ3F7CeEDod JuOw29+ZzAy4A/uVFJRremTlHydXJ0yLar8aAXgu80yN1LXm1Y0PO32E/Om/3S2ANUuN twEpIcu0yf511OGrdbEQsqgVWtF7SCpCRdvgb3W08CUWXrFk6tIIwOtnKwVqd+X4Nbgb BbSMtFraTT6thrVs0fsaMvKTzRFbfqOEyrnvuJSjaOqrgAqPW6yuwJ3Fl/FevmDpD+M3 pivA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693961227; x=1694566027; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jXumc14ktdfE0zEuogrNKkcfaJr/RaVfektbcVXwHlE=; b=AhpQ31eXt8v4/EhpmCDxBKhXWTeyxyqHNA7MYfcM1cUY5zvW1NKtfL/LrvPkkyPily 77Gx0bo2a6lHZJ8J/8AaUjLInG8HwTej55ErVbK6xKQQ1OxXH70Foxi9uspkbeVaK8UL p1Rj3ZOMD/9GH4WbamKF2luRTFlhTNxsDIku63LFGHPuZ5B+dbmPmgro9+wwhEGj2geo UBsi8fsiqIldbcFOfAfQMBWoObbE3INftfDKgjdvKA9xAyW5U5CEs/ZOONvYGGmW2JvX VFOe27LzGnBiKqeFxkUdZ2/RLaAXjdR5Cciz+zs2W1X3kcPYf74cdb1t+sheEVSG4y1U joyg== X-Gm-Message-State: AOJu0YwD9A2wnGAtQi+SqF0qzMVyutC0iWBqFDOwHQYzGpD4qkwHN9EW 2SM7wuS6vXXRjDHFmOkYVOM= X-Google-Smtp-Source: AGHT+IGN8eZIp3B0vkZIN8N/3RkpT7OFNbR1bl9GJIizF0HVRZ+D1EpmiR7OTPaCqx9QYELkRxurTw== X-Received: by 2002:a05:6a00:1821:b0:68b:eb5a:644 with SMTP id y33-20020a056a00182100b0068beb5a0644mr16122918pfa.5.1693961227094; Tue, 05 Sep 2023 17:47:07 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h28-20020a63385c000000b00553b9e0510esm10021787pgn.60.2023.09.05.17.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Sep 2023 17:47:06 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269463 Archived-At: On 9/5/2023 4:36 PM, Stefan Kangas wrote: > Jim Porter writes: > >> On 1/30/2023 6:54 AM, Stefan Monnier via Bug reports for GNU Emacs, the Swiss >> army knife of text editors wrote: >>> It sounds good to me, but I'm definitely not well versed in this aspect >>> of the interaction between Eshell and Pcomplete (more specifically, >>> this is a part of their interaction which I find quite tricky), so it's >>> good that you add corresponding regression tests. >> >> Thanks for taking a look. I've merged my patches as e7d0aa248e. We can leave >> this open though to discuss what to do about the Pcomplete side of things. I >> think we can remove the workaround for Emacs 29, but maybe we want some >> additional changes. > > That was 9 months ago. Is it still relevant to keep this bug open? Yes, I believe so. I was planning to wait until Emacs 29.1 was released before pinging people on this, but then forgot all about it. We should probably use this time to fix the FIXME in 'pcomplete-arg', since (I think) the current behavior in Eshell no longer requires the FIXME bit: ;; FIXME: 'last' is handled specially in Emacs 29, because ;; 'pcomplete-parse-arguments' accepts a list of strings ;; (which are completion candidates) as return value for ;; (pcomplete-arg 'last). See below: "it means it's a ;; list of completions computed during parsing, ;; e.g. Eshell uses that to turn globs into lists of ;; completions". This special case will be dealt with ;; differently in Emacs 30: the pcomplete-arg-value ;; property will be used by 'pcomplete-parse-arguments'.