From: martin rudalics <rudalics@gmx.at>
To: Drew Adams <drew.adams@oracle.com>
Cc: Bug-Gnu-Emacs <bug-gnu-emacs@gnu.org>
Subject: Re: help-make-xrefs
Date: Mon, 27 Aug 2007 10:10:48 +0200 [thread overview]
Message-ID: <46D28708.4060202@gmx.at> (raw)
In-Reply-To: <DHEEKFAFJEFOJHLCFPFDEEIOCAAA.drew.adams@oracle.com>
> help-make-xrefs tries to be smart about providing links, but it could
> use some improvement. In the *Help* buffer from `C-h b', for instance,
> it provides links for commands that follow `M-x', even for cases such
> as `C-M-x'. The comment for this code says "An obvious case of a key
> substitution", which is not correct in this case. The regexp should
> at least be changed to prohibit a symbol character just before `M-x'.
After C-h b I get the line
C-M-x eval-defun
with a `help-function' button labeled `eval-defun' which doesn't seem
entirely wrong. We could change the regexp in question to
"\\_<M-x\\s-+\\(\\sw\\(\\sw\\|\\s_\\)*\\sw\\)" nil t)
but that might break other uses of `help-make-xrefs'. Alternatively we
could write
"[^-]\\<M-x\\s-+\\(\\sw\\(\\sw\\|\\s_\\)*\\sw\\)" nil t)
Suggestions welcome.
> Another problem in the `describe-bindings' display is this code on
> line 465 that tries to back up over non-whitespace:
>
> (skip-chars-backward "^\t\n")
>
> This works only if `indent-tabs-mode' is non-nil in the *Help* buffer.
> The string should be "^ \t\n" or equivalent. Otherwise, no commands
> are linked.
I fixed this on 2007-07-02.
prev parent reply other threads:[~2007-08-27 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 6:33 help-make-xrefs Drew Adams
2007-08-27 8:10 ` martin rudalics [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46D28708.4060202@gmx.at \
--to=rudalics@gmx.at \
--cc=bug-gnu-emacs@gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).