From: martin rudalics <rudalics@gmx.at>
To: Martin von Gagern <Martin.vGagern@gmx.net>, bug-gnu-emacs@gnu.org
Subject: Re: backup-buffer-copy loops if old backup can't be deleted
Date: Tue, 21 Aug 2007 16:37:32 +0200 [thread overview]
Message-ID: <46CAF8AC.9070809@gmx.at> (raw)
In-Reply-To: <46CAD810.3050904@gmx.net>
> There now is a patch to fix this, provided by Ulrich Mueller.
> Original URL: http://bugs.gentoo.org/attachment.cgi?id=128742
>
> =================== emacs-22.1-backup-buffer.patch ===================
> --- emacs-22.1.orig/lisp/files.el 2007-05-25 14:43:31.000000000 +0200
> +++ emacs-22.1/lisp/files.el 2007-08-21 08:26:36.000000000 +0200
> @@ -3119,9 +3119,8 @@ backup-buffer-copy (from-name to-name modes)
> (set-default-file-modes ?\700)
> (while (condition-case ()
> (progn
> - (condition-case nil
> - (delete-file to-name)
> - (file-error nil))
> + (and (file-exists-p to-name)
> + (delete-file to-name))
> (copy-file from-name to-name nil t)
> nil)
> (file-already-exists t))
> =============== end of emacs-22.1-backup-buffer.patch ===============
Did you apply that patch? Suppose the file to-name exists but cannot be
deleted. `copy-file' will raise its `file-already-exists' error and you
remain trapped in that loop.
You have to either change the backup file's permissions from within the
`condition-case' or mandate error handling up to `backup-buffer' where
it attempts to do the (convert-standard-filename "~/%backup%~") stuff.
I can't test these solutions here since my file system doesn't provide
permissions.
next prev parent reply other threads:[~2007-08-21 14:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.5018.1187641790.32220.bug-gnu-emacs@gnu.org>
2007-08-20 22:01 ` backup-buffer-copy loops if old backup can't be deleted Martin von Gagern
[not found] ` <mailman.5021.1187647310.32220.bug-gnu-emacs@gnu.org>
2007-08-21 12:18 ` Martin von Gagern
2007-08-21 14:37 ` martin rudalics [this message]
2007-08-21 14:51 ` Martin von Gagern
2007-08-21 15:28 ` martin rudalics
2007-08-21 19:35 ` Glenn Morris
2007-08-21 21:01 ` martin rudalics
2007-08-21 21:50 ` Glenn Morris
2007-08-22 9:13 ` Martin von Gagern
2007-08-22 9:44 ` martin rudalics
2007-08-22 9:48 ` Martin von Gagern
2007-08-22 12:40 ` martin rudalics
2007-08-22 21:37 ` Michael Schierl
2007-08-21 22:21 ` Martin von Gagern
2007-08-22 9:51 ` Ulrich Mueller
2007-08-23 20:59 ` Richard Stallman
2007-08-24 7:13 ` Martin von Gagern
2007-08-24 9:10 ` martin rudalics
2007-08-25 4:07 ` Richard Stallman
2007-08-25 4:07 ` Richard Stallman
[not found] ` <mailman.5219.1187902794.32220.bug-gnu-emacs@gnu.org>
2007-08-24 6:11 ` Ulrich Mueller
2007-08-20 19:58 Martin von Gagern
2007-08-21 6:50 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46CAF8AC.9070809@gmx.at \
--to=rudalics@gmx.at \
--cc=Martin.vGagern@gmx.net \
--cc=bug-gnu-emacs@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).