Indentations, PERL

Indentations, PERL

[Александр Поляков]

Hello,

I am a very basic user of Emacs, and I have never configured anything 
special about Emacs. So, in case what I am writing about will turn out 
to be just a problem with my default configuration files, I apologize.

What I think is the bug, is a problem with automatic indentations when I 
type PERL programs. Let me get right to the point and I'll paste first 
the code how it is automatically indented:

sub insert_sub {
    return unless (save_slide());
    my $after = 0;

    prompt(0, 'New Subtitle', "Would you like to " .
       "insert the new subtitle\n" .
       "before the current one or after?",
       [{GTK_ID => 'gtk-cancel',
         LABEL => 'Cancel',
         ALIGN => 'right',
         SUB => sub { $after = -1;}},
{GTK_ID => 'gtk-go-back',
 LABEL => 'Before',
 ALIGN => 'left',
 SUB => sub {$after = 0;}},
{GTK_ID => 'gtk-go-forward',
 LABEL => 'After',
 ALIGN => 'right',
 SUB => sub {$after = 1}},
    ]);

if ($after == 0) {
    insert_before($srt_idx);
} elsif ($after == 1) {
    insert_before($srt_idx + 1);
}
}


Next, is how I believe would be a proper way to indent the same code:

sub insert_sub {
    return unless (save_slide());
    my $after = 0;

    prompt(0, 'New Subtitle', "Would you like to " .
           "insert the new subtitle\n" .
           "before the current one or after?",
           [{GTK_ID => 'gtk-cancel',
             LABEL => 'Cancel',
             ALIGN => 'right',
             SUB => sub { $after = -1;}},
            {GTK_ID => 'gtk-go-back',
             LABEL => 'Before',
             ALIGN => 'left',
             SUB => sub {$after = 0;}},
            {GTK_ID => 'gtk-go-forward',
             LABEL => 'After',
             ALIGN => 'right',
             SUB => sub {$after = 1}},
           ]);

    if ($after == 0) {
        insert_before($srt_idx);
    } elsif ($after == 1) {
        insert_before($srt_idx + 1);
    }
}

(Somehow the exact spacing differ here, but I think you can see the 
difference in general.)

 Basically after I enter "{... SUB => sub {}}," the indentation screws 
up. I hope this makes sense.

Thanks,
Alex.

Re: Indentations, PERL

[martin rudalics]

> What I think is the bug, is a problem with automatic indentations when I 
> type PERL programs. Let me get right to the point and I'll paste first 
> the code how it is automatically indented:
> 
> sub insert_sub {
>    return unless (save_slide());
>    my $after = 0;
> 
>    prompt(0, 'New Subtitle', "Would you like to " .
>       "insert the new subtitle\n" .
> Next, is how I believe would be a proper way to indent the same code:
> 
> sub insert_sub {
>    return unless (save_slide());
>    my $after = 0;
> 
>    prompt(0, 'New Subtitle', "Would you like to " .
>           "insert the new subtitle\n" .
>           "before the current one or after?",
>           [{GTK_ID => 'gtk-cancel',
>             LABEL => 'Cancel',
>             ALIGN => 'right',
>             SUB => sub { $after = -1;}},
>            {GTK_ID => 'gtk-go-back',
>             LABEL => 'Before',
>             ALIGN => 'left',
>             SUB => sub {$after = 0;}},
>            {GTK_ID => 'gtk-go-forward',
>             LABEL => 'After',
>             ALIGN => 'right',
>             SUB => sub {$after = 1}},
>           ]);
> 
>    if ($after == 0) {
>        insert_before($srt_idx);
>    } elsif ($after == 1) {
>        insert_before($srt_idx + 1);
>    }
> }
> 
> (Somehow the exact spacing differ here, but I think you can see the 
> difference in general.)
> 
> Basically after I enter "{... SUB => sub {}}," the indentation screws 
> up. I hope this makes sense.
> 
> Thanks,
> Alex.
> 
> 
> _______________________________________________
> bug-gnu-emacs mailing list
> bug-gnu-emacs@gnu.org
> http://lists.gnu.org/mailman/listinfo/bug-gnu-emacs
> 

Re: Indentations, PERL

[martin rudalics]

Pleae ignore my first reply on this, it got mangled while sending.

 > What I think is the bug, is a problem with automatic indentations when I
 > type PERL programs. Let me get right to the point and I'll paste first
 > the code how it is automatically indented:
 >
 > sub insert_sub {
 >    return unless (save_slide());
 >    my $after = 0;
 >
 >    prompt(0, 'New Subtitle', "Would you like to " .
 >       "insert the new subtitle\n" .

Could you please tell how you inserted the last line.  Here, typing RET
at the end of the line before as well as hitting TAB on the last line do
the right thing.

 > Next, is how I believe would be a proper way to indent the same code:

It does so here.

 > (Somehow the exact spacing differ here, but I think you can see the
 > difference in general.)
 >
 > Basically after I enter "{... SUB => sub {}}," the indentation screws
 > up. I hope this makes sense.

Please tell us which Emacs version and which perl mode (cperl-mode or
perl-mode) you use.

Re: Indentations, PERL

[martin rudalics]

> for all the indentation, I always hit the <return> key, and then the 
> <tab> to get the automatic alignment. Oh, I've tried using cperl-mode, 
> instead of perl-mode, and that fixes it. So, it seems this is only 
> happens in perl-mode. The emacs version I have is: 21.4.1, I've 
> installed it from a package for Ubuntu.

I could reproduce it.  This has been fixed for Emacs 22.1.  You should
install that to get the right behavior.  I'm not sure whether the latest
perl-mode works with Emacs 21.4.

Stefan could you comment on that?

> So, is this just how perl-mode works? Is there anyway for me to slightly 
> adjust it, because I prefer the highlighting in perl-mode better than 
> cperl-mode?

Re: Indentations, PERL

[Stefan Monnier]

>> for all the indentation, I always hit the <return> key, and then the <tab>
>> to get the automatic alignment.  Oh, I've tried using cperl-mode, instead
>> of perl-mode, and that fixes it.  So, it seems this is only happens in
>> perl-mode.  The Emacs version I have is: 21.4.1, I've installed it from
>> a package for Ubuntu.

> I could reproduce it.  This has been fixed for Emacs 22.1.  You should
> install that to get the right behavior.  I'm not sure whether the latest
> perl-mode works with Emacs 21.4.

> Stefan could you comment on that?

I cannot remember using features specific to Emacs-22 in perl-mode, but
I can't guarantee that it will work with Emacs-21 either.

If it doesn't work, it should be pretty easy to make it work, tho.
In any case, I'd first lobby Ubuntu to include an emacs22 package since that
will give you other improvements at the same time.


        Stefan

Re: Indentations, PERL

[martin rudalics]

> I cannot remember using features specific to Emacs-22 in perl-mode, but
> I can't guarantee that it will work with Emacs-21 either.

It uses `syntax-ppss' which doesn't exist in Emacs 21.

> If it doesn't work, it should be pretty easy to make it work, tho.
> In any case, I'd first lobby Ubuntu to include an emacs22 package since that
> will give you other improvements at the same time.