unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jason Rumney <jasonr@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: bug-gnu-emacs@gnu.org
Subject: Re: w32-find-bdf-fonts does not close file handles of files examined
Date: Fri, 22 Jun 2007 14:22:20 +0100	[thread overview]
Message-ID: <467BCD0C.70103@gnu.org> (raw)
In-Reply-To: <utzt0p2xh.fsf@gnu.org>

Eli Zaretskii wrote:
> Btw, why are we using memory-mapped files for this functionality?
>   

It predates the inclusion of w32bdf.c in Emacs (the implementation is
based on mw32bdf.c from Meadow, a Japanese fork of Emacs 20), but I
think the reason for using memory mapping is that some East Asian fonts
are very large, and ten years ago when this code was written, the
difference between reading a file into memory and mapping it mattered a
lot more. I can see that in this particular function where the file is
closed again immediately, it offers no advantage, and is actually a loss
on Windows 9X, which doesn't support swapping directly from
memory-mapped files, but the new font backend in Emacs 23 will
eventually replace this code anyway, so there is not much point in
making major changes now.

  reply	other threads:[~2007-06-22 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-20 20:28 w32-find-bdf-fonts does not close file handles of files examined Michael Schierl
2007-06-20 21:29 ` Jason Rumney
2007-06-22 12:51   ` Eli Zaretskii
2007-06-22 13:22     ` Jason Rumney [this message]
2007-06-22 17:58       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=467BCD0C.70103@gnu.org \
    --to=jasonr@gnu.org \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).