From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.bugs Subject: Re: No Windows File Dialogue in Win98SE Date: Mon, 11 Jun 2007 00:27:17 +0100 Message-ID: <466C88D5.4050101@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1181518051 9795 80.91.229.12 (10 Jun 2007 23:27:31 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 10 Jun 2007 23:27:31 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: Juergen Fenn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 11 01:27:30 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HxWoi-0004sD-ND for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jun 2007 01:27:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxWoi-0005BT-7P for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Jun 2007 19:27:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HxWof-0005BE-EV for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2007 19:27:25 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HxWoe-0005B2-5T for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2007 19:27:24 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HxWod-0005Az-Rd for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2007 19:27:23 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HxWod-00046A-CC for bug-gnu-emacs@gnu.org; Sun, 10 Jun 2007 19:27:23 -0400 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id EE05551326; Mon, 11 Jun 2007 00:27:21 +0100 (BST) User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) In-Reply-To: X-detected-kernel: Linux 2.4-2.6 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:15837 Archived-At: Juergen Fenn wrote: > I tried to open a file in NTEmacs 22.1 on Windows 98 SE by selecting > File|Open File with the mouse. The dialogue did not appear. Thanks, I think I have found the bug. If you can recompile Emacs (using the mingw port of GCC, which is also free), then it would help us to verify that this patch works before the next release. *** w32fns.c 28 Mar 2007 23:13:00 +0100 1.288 --- w32fns.c 11 Jun 2007 00:24:10 +0100 *************** *** 7902,7910 **** /* Apparently NT4 crashes if you give it an unexpected size. I'm not sure about Windows 9x, so play it safe. */ if (w32_major_version > 4 && w32_major_version < 95) ! file_details->lStructSize = sizeof (new_file_details); else ! file_details->lStructSize = sizeof (file_details); file_details->hwndOwner = FRAME_W32_WINDOW (f); /* Undocumented Bug in Common File Dialog: --- 7910,7918 ---- /* Apparently NT4 crashes if you give it an unexpected size. I'm not sure about Windows 9x, so play it safe. */ if (w32_major_version > 4 && w32_major_version < 95) ! file_details->lStructSize = sizeof (NEWOPENFILENAME); else ! file_details->lStructSize = sizeof (OPENFILENAME); file_details->hwndOwner = FRAME_W32_WINDOW (f); /* Undocumented Bug in Common File Dialog: