From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#43764: Calc shift right broken Date: Thu, 8 Oct 2020 14:24:02 +0200 Message-ID: <4648BF2F-8507-4D39-85F1-1C40C0E8BFC2@acm.org> References: <87h7r9ozuh.fsf@gnus.org> <87wo04nnvr.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.17\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24120"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Vincent =?UTF-8?Q?Bela=C3=AFche?= , 43764@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 08 14:25:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kQUyu-0006An-Gs for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Oct 2020 14:25:12 +0200 Original-Received: from localhost ([::1]:46326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kQUyt-0007uw-38 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Oct 2020 08:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33672) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kQUyk-0007uJ-PY for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2020 08:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47399) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kQUyk-0004n8-FV for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2020 08:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kQUyk-0003nC-Bm for bug-gnu-emacs@gnu.org; Thu, 08 Oct 2020 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Oct 2020 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43764 X-GNU-PR-Package: emacs Original-Received: via spool by 43764-submit@debbugs.gnu.org id=B43764.160215985514503 (code B ref 43764); Thu, 08 Oct 2020 12:25:02 +0000 Original-Received: (at 43764) by debbugs.gnu.org; 8 Oct 2020 12:24:15 +0000 Original-Received: from localhost ([127.0.0.1]:58942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQUxz-0003lr-5Z for submit@debbugs.gnu.org; Thu, 08 Oct 2020 08:24:15 -0400 Original-Received: from mail1445c50.megamailservers.eu ([91.136.14.45]:44086 helo=mail265c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kQUxw-0003lc-6J for 43764@debbugs.gnu.org; Thu, 08 Oct 2020 08:24:13 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1602159845; bh=L1UGRjSelSvNzS99mw5nD3JaWEpLO3GmvYiFHDzm7yY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=pTwO1kl3+OMEcTqSbAU/+ooV3U2Sg7ApdIbptPdLiO0kZIADjR7bzfRaLHhx9nSAZ BjwT99DdXz9+MKosQ1Y65T34hguncpMa6N1oYSxt29Ae4rqWFI16qVv/37KUM8ZZml yxE30wOdY1tJgtEiqceGEqhgYFjizyFxeqiGK9ew= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-304ee655.032-75-73746f71.bbcust.telenor.se [85.230.78.48]) (authenticated bits=0) by mail265c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 098CO3ic001952; Thu, 8 Oct 2020 12:24:04 +0000 In-Reply-To: <87wo04nnvr.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.17) X-CTCH-RefID: str=0001.0A782F29.5F7F04E5.008F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=D5w51cZj c=1 sm=1 tr=0 a=63Z2wlQ1NB3xHpgKFKE71g==:117 a=63Z2wlQ1NB3xHpgKFKE71g==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=x1g4Qhi0v8UQpmzpWnYA:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190080 Archived-At: 6 okt. 2020 kl. 03.28 skrev Lars Ingebrigtsen : > On the other hand, I don't know what people use Calc for here. If > people are going "I wonder what would happen on a 32-bit machine if I > were to do this shift operation", then it'd be something else... Yes, we should be defending the users of Emacs, not Emacs itself. What about a narrower change: clip the value after shifting right = instead of before? Vincent, would you be happy with the patch below, or do you think a more = fundamental change is required? --- a/lisp/calc/calc-bin.el +++ b/lisp/calc/calc-bin.el @@ -375,7 +375,7 @@ calcFunc-lsh (Math-lessp w n)) 0) ((< n 0) - (math-quotient (math-clip a w) (math-power-of-2 (- n)))) + (math-clip (math-quotient a (math-power-of-2 (- n))) w)) (t (math-clip (math-mul a (math-power-of-2 n)) w)))))) =20