From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Robert Weiner Newsgroups: gmane.emacs.bugs Subject: bug#24021: FEATURE ADDITION: 25.0.94: goto-marker, jumps to a marker potentially in a different buffer Date: Mon, 18 Jul 2016 22:05:33 -0400 Message-ID: <46351974-097B-48D3-8A60-7881CA9A2553@gmail.com> References: <87oa5ucx1a.fsf@users.sourceforge.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1468893986 12989 80.91.229.3 (19 Jul 2016 02:06:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 02:06:26 +0000 (UTC) Cc: 24021@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 04:06:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPKQI-0004wM-Dv for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 04:06:14 +0200 Original-Received: from localhost ([::1]:51453 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPKQH-00067z-LS for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jul 2016 22:06:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPKQB-00067t-S1 for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 22:06:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPKQ6-0001o5-RG for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 22:06:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43798) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPKQ6-0001nz-NX for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 22:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPKQ6-0002qc-Ce for bug-gnu-emacs@gnu.org; Mon, 18 Jul 2016 22:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Weiner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2016 02:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24021 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24021-submit@debbugs.gnu.org id=B24021.146889394310918 (code B ref 24021); Tue, 19 Jul 2016 02:06:02 +0000 Original-Received: (at 24021) by debbugs.gnu.org; 19 Jul 2016 02:05:43 +0000 Original-Received: from localhost ([127.0.0.1]:56135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPKPn-0002q2-Kw for submit@debbugs.gnu.org; Mon, 18 Jul 2016 22:05:43 -0400 Original-Received: from mail-io0-f171.google.com ([209.85.223.171]:36650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPKPl-0002pm-Ox for 24021@debbugs.gnu.org; Mon, 18 Jul 2016 22:05:42 -0400 Original-Received: by mail-io0-f171.google.com with SMTP id b62so7012170iod.3 for <24021@debbugs.gnu.org>; Mon, 18 Jul 2016 19:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=kCy5G/rW5Lgnk6yRwyazX9fk2NhT3RM0XS/cj3V9ukQ=; b=cBhqJ74YrROrbBhO0pEb/sw/kxAwjeUkdPtwX+G+qyisTk/HYd82jyxr+v+UPjSp0r 1iOKjqw8IWB6gwDUokeHWfJLe+qho15vKLVyxWNA3xXky/pbVLaO4CSR0t9s2fUBf1O1 68XejVwQ15e3WQpLen3lM20RBrcBNPlVZ3Xzcn/isCdvA5ik0PdO1D7k+fDhrI/SxcfJ 0dBsApP2HI83HJg3A3LdWVZ3B/x1DURFwMGRhfT1JxOBPETDHJKhlQ8/JwubhIBkp5rY JyGU9TshyZw5nqyx09t7IGc1tUQAvoxMBY+/ydjsy8JRBzwNDRuNpW06q8KU6xYuIiuf cweg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=kCy5G/rW5Lgnk6yRwyazX9fk2NhT3RM0XS/cj3V9ukQ=; b=U0dpYerKg4YYkuDxouii5TbWr7MdNZInYbB3peTjl+4ruUSuQjSwcghbR3zOIDgZy4 yNyVn5QB9sxYujB3hjI4uwQ64GmTOxPnlJPA9spTftHYqSgXW1bEjoDQtwVrBDrDoo6m Wa8eHkERVcHJEvDUc4SHFjio5okjw7nCoZ6Hf9RivVLFVUA4KGCT7jnyvne06+2mPt4I NmMvj5WkpKIxcSv28YnNURXfH/DqnrDA2lD/vStyovlwLZ8+tOHfuoU+R9DrVTY4I+UT 15A077VjuxNkohIOEU0g6BpA573B2NFabsNFvteEaJ7//SR3yT1JvPl7SPBTPjhgzyEK PkaQ== X-Gm-Message-State: ALyK8tIlFF767NzHm1FV4tceO4XtrYUMXaG3KSw3QWYClwCriXwaZzIFyyWOqGN3RzUTpA== X-Received: by 10.107.7.231 with SMTP id g100mr35734592ioi.64.1468893936067; Mon, 18 Jul 2016 19:05:36 -0700 (PDT) Original-Received: from ?IPv6:2600:1017:b825:16f:3c8d:5c66:68af:47a0? ([2600:1017:b825:16f:3c8d:5c66:68af:47a0]) by smtp.gmail.com with ESMTPSA id r8sm5842086itb.5.2016.07.18.19.05.35 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 Jul 2016 19:05:35 -0700 (PDT) X-Mailer: iPhone Mail (13F69) In-Reply-To: <87oa5ucx1a.fsf@users.sourceforge.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121249 Archived-At: Thanks for the feedback. I will work on an update. -- Bob > On Jul 18, 2016, at 8:05 PM, npostavs@users.sourceforge.net wrote: >>=20 >> (defun goto-marker (marker) >> "Make MARKER's buffer and position current." >> (interactive) >=20 > The interactive spec doesn't match the parameter list. I'm not sure if > it makes sense for this to be interactive (how would the user enter a > marker?). That interactive spec should not be in there. >=20 >> (cond ((not (markerp marker)) >> (error "Invalid marker: %s" marker)) >> ((not (marker-buffer marker)) >> (error "Invalid marker buffer: %s" marker)) >=20 > I think these checks are redundant, you'll get the same errors when you > call marker-buffer and set-buffer, below. I will take a look. >=20 >> (t (let* ((buffer (marker-buffer marker)) >> (position (marker-position marker))) >> (set-buffer buffer) >> (or (and (>=3D position (point-min)) >> (<=3D position (point-max))) >> (if widen-automatically >> (widen) >> (error "Marker position is outside accessible part of b= uffer: %s" marker))) >> (goto-char position) >> (switch-to-buffer buffer))))) >=20 > If this is just a "simple function" (not an interactive command), it > shouldn't widen, or call switch-to-buffer. But it does need to do these things to leave the selected buffer and point w= here the marker points. It only widens if the marker position is outside th= e restricted range. It can be wrapped in save-restriction and save-excursio= n for times when it is used for temporary effect, e.g. to find the column of= the marker position. Bob=