unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Chong Yidong'" <cyd@stupidchicken.com>,
	"'Jason Rumney'" <jasonr@gnu.org>
Cc: 'Dan Nicolaescu' <dann@ics.uci.edu>,
	rms@gnu.org, 3370@emacsbugs.donarmstrong.com
Subject: bug#3370: 23.0.94; `comment-region' indents comment chars  inappropriately
Date: Mon, 25 May 2009 00:01:58 -0700	[thread overview]
Message-ID: <460B8A8EC0204F4A830B9EC10995A169@us.oracle.com> (raw)
In-Reply-To: <874ov9aivv.fsf@cyd.mit.edu>

> > Or perhaps it would have been better putting it back to plain if
> > Richard's new indent-or-triple option was found to not be a suitable
> > default.  I'm not sure that Dan looked into the history when he
> > changed it to indent.
> 
> Maybe.  Could Dan or Richard weigh in on this?
> 
> Personally, all else being equal,

Why would everything else be equal? What's wrong with considering what Emacs has
always done, and perhaps even thinking about breaking existing code (such as
what I reported)? Everything else is not equal.

> I think `indent' is a better comment
> style.  For instance, all the Emacs sources use that style.

I don't know what `comment-style' is, so it's difficult for me to discuss it.
There is no doc for it that explains anything - see bug #2271.

What do you mean by "all the Emacs sources use that style"? I was guessing from
your previous mail that `comment-style' somehow controls `comment-region' (which
is what this bug report is about), which performs an action. How can static
source code be said to "use that style"?

If you are referring to ;; always being indented instead of starting a line
(which is not what I reported about), then no, there are plenty of source code
lines that start with ;; - in file headers, for instance.






  reply	other threads:[~2009-05-25  7:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-24 23:31 bug#3370: 23.0.94; `comment-region' indents comment chars inappropriately Chong Yidong
2009-05-24 23:57 ` Drew Adams
2009-05-25  0:04 ` Lennart Borgman
2009-05-25  0:54   ` Chong Yidong
2009-05-25  1:28     ` Jason Rumney
2009-05-25  2:09       ` Drew Adams
2009-05-25  4:47       ` Chong Yidong
2009-05-25  7:01         ` Drew Adams [this message]
2009-05-25 13:27           ` Chong Yidong
2009-05-25 17:42             ` Drew Adams
2009-05-25 13:38           ` Stefan Monnier
2009-05-25 17:42             ` Drew Adams
2009-05-25 21:22               ` Stefan Monnier
2009-05-25 21:56                 ` Drew Adams
2009-05-25 22:46                 ` Jason Rumney
2009-05-26  1:16                   ` Stefan Monnier
2012-02-22  2:46                     ` Glenn Morris
2009-05-25  5:26       ` Dan Nicolaescu
2009-05-25  7:02         ` Drew Adams
2009-05-25 13:30           ` Chong Yidong
2009-05-25 13:39           ` Stefan Monnier
  -- strict thread matches above, loose matches on Subject: below --
2009-05-24 22:31 Drew Adams
2009-05-25 13:41 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460B8A8EC0204F4A830B9EC10995A169@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=3370@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    --cc=dann@ics.uci.edu \
    --cc=jasonr@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).