bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Robert Marshall]

I ran emacs -Q imagefile.png
and on viewing the buffer it consists of garbage which appears to be
assembled from parts of the X display (if required I can produce a screenshot)

Same problem is apparent with jpg and gifs. If I use the display command
from the command line (or from an emacs dired buffer) the images are
correctly displayed

In GNU Emacs 25.0.50.3 (i686-pc-linux-gnu, GTK+ Version 3.14.13, cairo version 1.14.2)
 of 2015-07-22 on poulenc
Repository revision: fed091f7c2513631d8c0570f444be9486d7563d1
Windowing system distributor `The X.Org Foundation', version 11.0.11701000
System Description:	Ubuntu 15.04

Configured using:
 `configure --with-cairo'

Configured features:
XPM JPEG TIFF GIF PNG RSVG CAIRO IMAGEMAGICK SOUND GPM DBUS GCONF
GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT
ZLIB TOOLKIT_SCROLL_BARS GTK3 X11

Important settings:
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Image[imagemagick]

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-c C-c to view the image as text. [2 times]
scroll-down-command: Beginning of buffer
Type C-c C-c to view the image as text.
Type C-x 1 to delete the help window, C-M-v to scroll help.
Mark saved where search started
"robert@capuchin.co.uk"
Mark saved where search started
"faure" [2 times]
Quit [2 times]

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils misearch multi-isearch cl-extra seq help-fns
help-mode cl-loaddefs pcase cl-lib image-mode easymenu dired time-date
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd fontset
image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham
georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese charscript case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice
loaddefs button faces cus-face macroexp files text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote dbusbind gfilenotify dynamic-setting
system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit
x multi-tty make-network-process emacs)

Memory information:
((conses 8 87967 9743)
 (symbols 24 19083 0)
 (miscs 20 134 285)
 (strings 16 15280 26489)
 (string-bytes 1 414619)
 (vectors 8 11228)
 (vector-slots 4 462309 5618)
 (floats 8 138 174)
 (intervals 28 957 14)
 (buffers 520 16)
 (heap 1024 41613 748))

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Eli Zaretskii]

> From: Robert Marshall <robert@capuchin.co.uk>
> Date: Wed, 22 Jul 2015 11:31:35 +0100
> 
> I ran emacs -Q imagefile.png
> and on viewing the buffer it consists of garbage which appears to be
> assembled from parts of the X display (if required I can produce a screenshot)
> 
> Same problem is apparent with jpg and gifs.

Does the problem go away if you configure without Cairo?

Does the problem exist if you view images through TIFF/JPEG/GIF
etc. libraries, not through Imagemagick?

Thanks.

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Robert Marshall]

Eli Zaretskii writes:
 > > From: Robert Marshall <robert@capuchin.co.uk>
 > > Date: Wed, 22 Jul 2015 11:31:35 +0100
 > > 
 > > I ran emacs -Q imagefile.png
 > > and on viewing the buffer it consists of garbage which appears to be
 > > assembled from parts of the X display (if required I can produce a screenshot)
 > > 
 > > Same problem is apparent with jpg and gifs.
 > 
 > Does the problem go away if you configure without Cairo?

I'll do a rebuild without Cairo tomorrow

 > 
 > Does the problem exist if you view images through TIFF/JPEG/GIF
 > etc. libraries, not through Imagemagick?
 > 
How do I do that? *info* suggests that evaluating

(setq imagemagick-types-inhibit t)
(imagemagick-register-types)

in scratch should do it but they're still coming up as imagemagick in
the mode line (and still garbled)

Robert

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Eli Zaretskii]

> Date: Wed, 22 Jul 2015 16:48:55 +0100
> From: Robert Marshall <robert@capuchin.co.uk>
> Cc: 21110@debbugs.gnu.org
> 
> Eli Zaretskii writes:
>  > > From: Robert Marshall <robert@capuchin.co.uk>
>  > > Date: Wed, 22 Jul 2015 11:31:35 +0100
>  > > 
>  > > I ran emacs -Q imagefile.png
>  > > and on viewing the buffer it consists of garbage which appears to be
>  > > assembled from parts of the X display (if required I can produce a screenshot)
>  > > 
>  > > Same problem is apparent with jpg and gifs.
>  > 
>  > Does the problem go away if you configure without Cairo?
> 
> I'll do a rebuild without Cairo tomorrow

Thanks.

>  > Does the problem exist if you view images through TIFF/JPEG/GIF
>  > etc. libraries, not through Imagemagick?
>  > 
> How do I do that?

Use "M-x customize-variable RET" to disable all Imagemagick types.

Btw, please do send a screenshot with the corrupted images, maybe
seeing it will give more ideas.

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Robert Marshall]

Eli Zaretskii writes:
 > > Date: Wed, 22 Jul 2015 16:48:55 +0100
 > > From: Robert Marshall <robert@capuchin.co.uk>
 > > Cc: 21110@debbugs.gnu.org
 > > 
 > > Eli Zaretskii writes:
 > >  > > From: Robert Marshall <robert@capuchin.co.uk>
 > >  > > Date: Wed, 22 Jul 2015 11:31:35 +0100
 > >  > > 
 > >  > > I ran emacs -Q imagefile.png
 > >  > > and on viewing the buffer it consists of garbage which appears to be
 > >  > > assembled from parts of the X display (if required I can produce a screenshot)
 > >  > > 
 > >  > > Same problem is apparent with jpg and gifs.
 > >  > 
 > >  > Does the problem go away if you configure without Cairo?
 > > 
 > > I'll do a rebuild without Cairo tomorrow
 > 
 > Thanks.

I can confirm that building without Cairo stops the corruption

 > 
 > >  > Does the problem exist if you view images through TIFF/JPEG/GIF
 > >  > etc. libraries, not through Imagemagick?
 > >  > 
 > > How do I do that?
 > 
 > Use "M-x customize-variable RET" to disable all Imagemagick types.
 >
 
I tried this and disabled png support in imagemagick-enabled-types but
still when I load a png the mode is reported as

'Image[imagemagick] mode defined in ‘image-mode.el’'

which I assume means that it's still using imagemagick?
And pre the removing cairo change the png files still loaded with
garbled images

(extract from custom-set-variables)
'(imagemagick-enabled-types
   (quote
    (3FR ART ARW AVS BMP BMP2 BMP3 CAL CALS CMYK CMYKA CR2 CRW CUR CUT DCM DCR DCX DDS DJVU DNG DPX EXR FAX FITS GBR GIF GIF87 GRB HRZ ICB ICO ICON J2C JNG JP2 JPC JPEG JPG JPX K25 KDC MIFF MNG MRW MSL MSVG MTV NEF ORF OTB PBM PCD PCDS PCL PCT PCX PDB PEF PGM PICT PIX PJPEG PNM PPM PSD PTIF PWP RAF RAS RBG RGB RGBA RGBO RLA RLE SCR SCT SFW SGI SR2 SRF SUN SVG SVGZ TGA TIFF TIFF64 TILE TIM TTF UYVY VDA VICAR VID VIFF VST WBMP WPG X3F XBM XC XCF XPM XV XWD YCbCr YCbCrA YUV)))


 > Btw, please do send a screenshot with the corrupted images, maybe
 > seeing it will give more ideas.
 >
 
Emailed yesterday

Robert

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Eli Zaretskii]

> Date: Thu, 23 Jul 2015 11:01:20 +0100
> From: Robert Marshall <robert@capuchin.co.uk>
> Cc: 21110@debbugs.gnu.org
> 
> I can confirm that building without Cairo stops the corruption

If you can afford one more test, perhaps try building with Cairo, but
without Imagemagick (and with the rest of image support libraries).
The Cairo build makes quite a bit of difference in image.c, but only
one of them is related to the Imagemagick part, so I think it's
important to understand whether this issue with Cairo is specific to
Imagemagick or to images in general.

Does anyone else have problems with Imagemagick (or images in general)
in the Cairo build?

>  > Use "M-x customize-variable RET" to disable all Imagemagick types.
>  >
>  
> I tried this and disabled png support in imagemagick-enabled-types but
> still when I load a png the mode is reported as
> 
> 'Image[imagemagick] mode defined in ‘image-mode.el’'
> 
> which I assume means that it's still using imagemagick?

Probably.  Building without Imagemagick would resolve the mystery.

>  > Btw, please do send a screenshot with the corrupted images, maybe
>  > seeing it will give more ideas.
>  
> Emailed yesterday

Yes, thanks.  Basically, I understand that the "image" shown by Emacs
contains no traces of the image itself, only some random garbage from
some entirely different graphics context, is that right?

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Glenn Morris]

Robert Marshall wrote:

> I can confirm that building without Cairo stops the corruption

Out of interest, why were you building with-cairo?

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Robert Marshall]

Eli Zaretskii writes:
 > > Date: Thu, 23 Jul 2015 11:01:20 +0100
 > > From: Robert Marshall <robert@capuchin.co.uk>
 > > Cc: 21110@debbugs.gnu.org
 > > 
 > > I can confirm that building without Cairo stops the corruption
 > 
 > If you can afford one more test, perhaps try building with Cairo, but
 > without Imagemagick (and with the rest of image support libraries).
 > The Cairo build makes quite a bit of difference in image.c, but only
 > one of them is related to the Imagemagick part, so I think it's
 > important to understand whether this issue with Cairo is specific to
 > Imagemagick or to images in general.
 > 
I did a

./configure --without-imagemagick --with-cairo

and build and with that version graphic files are no longer garbled

(It would be good IMHO if the INSTALL file mentioned the
--without-imagemagick option alongside the --without-jpeg options
rather than my having to dig through the configure script)

 > Does anyone else have problems with Imagemagick (or images in general)
 > in the Cairo build?
 > 
 > >  > Use "M-x customize-variable RET" to disable all Imagemagick types.
 > >  >
 > >  
 > > I tried this and disabled png support in imagemagick-enabled-types but
 > > still when I load a png the mode is reported as
 > > 
 > > 'Image[imagemagick] mode defined in ‘image-mode.el’'
 > > 
 > > which I assume means that it's still using imagemagick?
 > 
 > Probably.  Building without Imagemagick would resolve the mystery.
 > 

C-h m in a png file now gives me 'Image[png] mode defined in  image-mode.el' 

> >  > Btw, please do send a screenshot with the corrupted images, maybe
 > >  > seeing it will give more ideas.
 > >  
 > > Emailed yesterday
 > 
 > Yes, thanks.  Basically, I understand that the "image" shown by Emacs
 > contains no traces of the image itself, only some random garbage from
 > some entirely different graphics context, is that right?
 > 

Well if there is anything from the image it is well hidden!


Robert

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Robert Marshall]

Glenn Morris writes:
 > Robert Marshall wrote:
 > 
 > > I can confirm that building without Cairo stops the corruption
 > 
 > Out of interest, why were you building with-cairo?
 > 

Because it's there? ;-)

To see what additional functionality that gave me, I've used the cairo
dock and wanted to see how it related.

Robert

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Eli Zaretskii]

> Date: Fri, 24 Jul 2015 13:18:49 +0100
> From: Robert Marshall <robert@capuchin.co.uk>
> Cc: 21110@debbugs.gnu.org
> 
>  > If you can afford one more test, perhaps try building with Cairo, but
>  > without Imagemagick (and with the rest of image support libraries).
>  > The Cairo build makes quite a bit of difference in image.c, but only
>  > one of them is related to the Imagemagick part, so I think it's
>  > important to understand whether this issue with Cairo is specific to
>  > Imagemagick or to images in general.
>  > 
> I did a
> 
> ./configure --without-imagemagick --with-cairo
> 
> and build and with that version graphic files are no longer garbled

So the final diagnosis is that the problem is caused by the
combination of Cairo and Imagemagick.  Thanks.

> (It would be good IMHO if the INSTALL file mentioned the
> --without-imagemagick option alongside the --without-jpeg options
> rather than my having to dig through the configure script)

I added that, thanks for pointing it out.

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[YAMAMOTO Mitsuharu]

On Thu, 23 Jul 2015 19:01:20 +0900,
Robert Marshall wrote:
> 
> Eli Zaretskii writes:
>  > > Date: Wed, 22 Jul 2015 16:48:55 +0100
>  > > From: Robert Marshall <robert@capuchin.co.uk>
>  > > Cc: 21110@debbugs.gnu.org
>  > > 
>  > > Eli Zaretskii writes:
>  > >  > > From: Robert Marshall <robert@capuchin.co.uk>
>  > >  > > Date: Wed, 22 Jul 2015 11:31:35 +0100
>  > >  > > 
>  > >  > > I ran emacs -Q imagefile.png
>  > >  > > and on viewing the buffer it consists of garbage which appears to be
>  > >  > > assembled from parts of the X display (if required I can produce a screenshot)
>  > >  > > 
>  > >  > > Same problem is apparent with jpg and gifs.
>  > >  > 
>  > >  > Does the problem go away if you configure without Cairo?
>  > > 
>  > > I'll do a rebuild without Cairo tomorrow
>  > 
>  > Thanks.
> 
> I can confirm that building without Cairo stops the corruption

The cairo image support was substantially rewritten on master of the
Emacs git repository.  Could you try it and tell us if you are still
seeing this problem?  Note that the ImageMagick is now disabled by
default, so you would need --with-imagemagick as well as --with-cairo.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[Robert Marshall]

YAMAMOTO Mitsuharu writes:
 > On Thu, 23 Jul 2015 19:01:20 +0900,
 > Robert Marshall wrote:
 > > 
 > > Eli Zaretskii writes:
 > >  > > Date: Wed, 22 Jul 2015 16:48:55 +0100
 > >  > > From: Robert Marshall <robert@capuchin.co.uk>
 > >  > > Cc: 21110@debbugs.gnu.org
 > >  > > 
 > >  > > Eli Zaretskii writes:
 > >  > >  > > From: Robert Marshall <robert@capuchin.co.uk>
 > >  > >  > > Date: Wed, 22 Jul 2015 11:31:35 +0100
 > >  > >  > > 
 > >  > >  > > I ran emacs -Q imagefile.png
 > >  > >  > > and on viewing the buffer it consists of garbage which appears to be
 > >  > >  > > assembled from parts of the X display (if required I can produce a screenshot)
 > >  > >  > > 
 > >  > >  > > Same problem is apparent with jpg and gifs.
 > >  > >  > 
 > >  > >  > Does the problem go away if you configure without Cairo?
 > >  > > 
 > >  > > I'll do a rebuild without Cairo tomorrow
 > >  > 
 > >  > Thanks.
 > > 
 > > I can confirm that building without Cairo stops the corruption
 > 
 > The cairo image support was substantially rewritten on master of the
 > Emacs git repository.  Could you try it and tell us if you are still
 > seeing this problem?  Note that the ImageMagick is now disabled by
 > default, so you would need --with-imagemagick as well as --with-cairo.
 > 

Yes a fresh build from git with cairo no longer shows the error. This bug can be closed!

Thanks

Robert

bug#21110: 25.0.50; Images viewed with Image[Imagemagick] mode are garbled

[YAMAMOTO Mitsuharu]

On Sun, 30 Jun 2019 17:21:02 +0900,
Robert Marshall wrote:
> 
> YAMAMOTO Mitsuharu writes:
>  > On Thu, 23 Jul 2015 19:01:20 +0900,
>  > Robert Marshall wrote:
>  > > 
>  > > Eli Zaretskii writes:
>  > >  > > Date: Wed, 22 Jul 2015 16:48:55 +0100
>  > >  > > From: Robert Marshall <robert@capuchin.co.uk>
>  > >  > > Cc: 21110@debbugs.gnu.org
>  > >  > > 
>  > >  > > Eli Zaretskii writes:
>  > >  > >  > > From: Robert Marshall <robert@capuchin.co.uk>
>  > >  > >  > > Date: Wed, 22 Jul 2015 11:31:35 +0100
>  > >  > >  > > 
>  > >  > >  > > I ran emacs -Q imagefile.png
>  > >  > >  > > and on viewing the buffer it consists of garbage which appears to be
>  > >  > >  > > assembled from parts of the X display (if required I can produce a screenshot)
>  > >  > >  > > 
>  > >  > >  > > Same problem is apparent with jpg and gifs.
>  > >  > >  > 
>  > >  > >  > Does the problem go away if you configure without Cairo?
>  > >  > > 
>  > >  > > I'll do a rebuild without Cairo tomorrow
>  > >  > 
>  > >  > Thanks.
>  > > 
>  > > I can confirm that building without Cairo stops the corruption
>  > 
>  > The cairo image support was substantially rewritten on master of the
>  > Emacs git repository.  Could you try it and tell us if you are still
>  > seeing this problem?  Note that the ImageMagick is now disabled by
>  > default, so you would need --with-imagemagick as well as --with-cairo.
>  > 
> 
> Yes a fresh build from git with cairo no longer shows the error. This bug can be closed!
> 
> Thanks

Thanks for testing.  Closing the bug.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp