From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sun, 8 Dec 2019 02:42:42 +0200 Message-ID: <45fcbf16-c9b4-ca15-7fa2-e7ea2137218c@yandex.ru> References: <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <83ftiasfdm.fsf@gnu.org> <83lfrulmva.fsf@gnu.org> <76a012f5-8cdd-75d5-322e-a453a612c655@yandex.ru> <83immxjs6q.fsf@gnu.org> <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> <835ziuixke.fsf@gnu.org> <9c4768a5-ecce-68ce-c612-a001b2f6784d@yandex.ru> <8336dxh1ge.fsf@gnu.org> <6c68ceed-156c-a6f2-bf0f-21d7e9eb5692@yandex.ru> <831rthgy3u.fsf@gnu.org> <83o8wkfu63.fsf@gnu.org> <83r21gdnun.fsf@gnu.org> <839f1185-fc0c-0e8b-29fd-5431fb71ab2e@yandex.ru> <83o8wkdk3n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="247114"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 08 03:30:44 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idmLI-00127O-1u for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 03:30:40 +0100 Original-Received: from localhost ([::1]:54828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idmLF-0001m3-BN for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Dec 2019 21:30:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58586) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idmKo-0001hM-6M for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idmKk-0004Hn-FA for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idmKg-0004D8-4R for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idmKg-0003nY-1E for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 21:30:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2019 02:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157577214814490 (code B ref 37774); Sun, 08 Dec 2019 02:30:01 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 8 Dec 2019 02:29:08 +0000 Original-Received: from localhost ([127.0.0.1]:49960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idmJn-0003le-Pt for submit@debbugs.gnu.org; Sat, 07 Dec 2019 21:29:08 -0500 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:55772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idmJl-0003l2-Ua for 37774@debbugs.gnu.org; Sat, 07 Dec 2019 21:29:06 -0500 Original-Received: by mail-wm1-f45.google.com with SMTP id q9so11873115wmj.5 for <37774@debbugs.gnu.org>; Sat, 07 Dec 2019 18:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jaoRDAa/cmbKPD7rohny80lvUSGS1vztQcMyT/lgKXE=; b=IwC1F5qkoxKieoGhStZyqwh+Ha6xzyau3EFrjMnDzNjRZw+LQbB0f1tpKVDKq84dtD YKL1Qz8pHrmRxo8k5Nlw4HRACBWvPoe4C43ibzpWGyDwipbBrvb9XKbISBMMagt+C903 p2GK8X8mWibPCyEj18iZcmzhmG48rcAZRnP80pjJHEP8KY8JDNbK04dn23GEvyP7TubB eCvDsCgJExxSaYJzV2bRauvbPRtBr039OB8NBNXqMxcFp9u+uB/xRYY7PdpcAEP8z1mr Y1Th+3UegBOY7oH4WeSOROrToybb1C+3BqblBBMhaTwHhWRdDPxrvUuZRi6SbAdIwb1l xgGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jaoRDAa/cmbKPD7rohny80lvUSGS1vztQcMyT/lgKXE=; b=d15jRYTosX5ja6tAYCCM3OzR6R66ixJcYI9Mfzr2ZhiAGxbFvQxnamD/YzAdIWppK0 lmThxXjPgG/TmDDLK6KsLaBGMoC1UompDoXZPGn3ZihUfss7YB9VW3zPW2sOpOzdNXCO JknKjy4CpfsuxAxsyNQE3N3Vg4MVF1Y3kn+q8kw3o9THXTn0wwTnn1jSZxbye9jqOxpz w+yp2zRIXb07O9tEuzOoClDllrQJuj5cQ+b5kFlMHHE6QpykD+2/bAaJskxiVAS6PGe7 MnYEELKimvEjvaipos7QFaPr5Vm6AkikO7fU79QHo7B7/Gc9bu2G2RxqrSwMyQ0vL4TL sN0w== X-Gm-Message-State: APjAAAV7a43srzvCUKtcWLnL6MoK0fmw+lIxiPAAmfDisoUt4rM3HmUF PUlW+JuF5gE4P98TYqMCaCXdISz5 X-Google-Smtp-Source: APXvYqwg4Z4ZTYtGlF5OW5un0Hz+LFEb3aNSNhguqmtXape+2a13QXTL4vGtdDQ8Aw+mARA5BBXeug== X-Received: by 2002:a1c:9e49:: with SMTP id h70mr18597139wme.79.1575765764168; Sat, 07 Dec 2019 16:42:44 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id g25sm9844696wmh.3.2019.12.07.16.42.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Dec 2019 16:42:43 -0800 (PST) In-Reply-To: <83o8wkdk3n.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172997 Archived-At: On 07.12.2019 21:14, Eli Zaretskii wrote: > Our goal is to allow themes "inherit" the :extend attribute without > having to specify it in their face specs, unlike with other > attributes. That's the only goal; But that's exactly what it does. This question is simply different from "does it only affect the function custom-theme-set-faces", as I have explained profusely. > we don't want :extend to behave > differently from other face attributes in any other context. What other contexts do you have in mind? What *shouldn't* it do? > If you are saying that we cannot make this change apply only to face > definitions by themes, What other face definitions are there? There's defface, of course, which we treat differently. And there are theme definitions (both third-party and "user theme"). set-face-attribute is not affected, in case you were worried about that. > then it means we don't really understand what > we could break here, and then I don't think I want this change in > Emacs 27. Sorry, it's too risky. What about the existing risk of breaking every theme out there by doing nothing? > (I thought cus-face.el stores information in symbol properties that > enables it to apply the face attributes in a special way. It does. > But I don't > consider myself an expert on these matters, so if you say we cannot > differentiate between general face definition and what themes do, so > be it.) What's a "general face definition"?