From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20419: 25.0.50; doc string of `recenter-last-op` Date: Sat, 25 Apr 2015 09:12:07 -0700 (PDT) Message-ID: <45b241f3-fe0d-4147-8726-0c06361f2199@default> References: <<162fcb99-b1ac-4afa-8c95-e8d171f07153@default>> <<83iockxnog.fsf@gnu.org>> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1429978404 19421 80.91.229.3 (25 Apr 2015 16:13:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 25 Apr 2015 16:13:24 +0000 (UTC) Cc: 20419-done@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 25 18:13:11 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Ym2ha-0005Bn-Kn for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Apr 2015 18:13:10 +0200 Original-Received: from localhost ([::1]:48847 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2hZ-0000J9-VW for geb-bug-gnu-emacs@m.gmane.org; Sat, 25 Apr 2015 12:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2hW-0000Is-8T for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:13:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ym2hT-0001Yi-41 for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:13:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ym2hT-0001YY-1H for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:13:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Ym2hS-0005Q2-Hx for bug-gnu-emacs@gnu.org; Sat, 25 Apr 2015 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Apr 2015 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20419 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20419-done@debbugs.gnu.org id=D20419.142997833720776 (code D ref 20419); Sat, 25 Apr 2015 16:13:02 +0000 Original-Received: (at 20419-done) by debbugs.gnu.org; 25 Apr 2015 16:12:17 +0000 Original-Received: from localhost ([127.0.0.1]:39932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2gj-0005P1-8v for submit@debbugs.gnu.org; Sat, 25 Apr 2015 12:12:17 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:18900) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ym2gg-0005Oo-Vt for 20419-done@debbugs.gnu.org; Sat, 25 Apr 2015 12:12:15 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t3PGC7di017100 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 25 Apr 2015 16:12:08 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t3PGC79A018836 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 25 Apr 2015 16:12:07 GMT Original-Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by userv0122.oracle.com (8.13.8/8.13.8) with ESMTP id t3PGC6sK028626; Sat, 25 Apr 2015 16:12:07 GMT In-Reply-To: <<83iockxnog.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102031 Archived-At: > > > > The doc string says that these are the possible values: > > > > "`top', `middle', `bottom', integer or float numbers." > > > > It should also mention `nil', say what `nil' means, and > > > > perhaps even say that `nil' is the default value. > > > > > > How do you see that nil has any meaning whatsoever? > > > > `nil' means that the next `recenter-top-bottom' starts with > > the first element of `recenter-positions'. >=20 > Yuck! Why not set it to the first member of recenter-positions to > begin with? >=20 > FWIW, I consider this, including the exposure of this variable as > some kind of knob for other Lisp packages, bad style. You should be > demanding cleaning this up instead of documenting it. >=20 > Fixed under protest. Point taken. A better design (for its use in `perform-replace') might bind `recenter-last-op' to the car of `recenter-positions'. (The code also resets it later in `perform-replace'. That setq would also need to be changed, the same way.) Or get rid of `recenter-last-op' and just have code bind and set option `recenter-positions'... But Emacs dev generally doesn't like to do that, even locally. As long as we have something like `recenter-last-op', it is like `kill-ring-yank-pointer': it will be used by other code and needs to be documented. Please consider filing that bug report/enhancement request (or consider fixing it in the context of this one), if you like. But the behavior of nil remains unchanged. It still needs to be mentioned in the doc string, as long as it has the effect it has. Thanks for having fixed that.