From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20845: 25.0.50; bookmark.el, handling of fictitious `buffer' property Date: Thu, 18 Jun 2015 08:26:17 -0700 (PDT) Message-ID: <45ac4463-d787-44d9-90ef-b40e32698ed9@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1434641258 25793 80.91.229.3 (18 Jun 2015 15:27:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Jun 2015 15:27:38 +0000 (UTC) To: 20845@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 18 17:27:24 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z5bii-00045v-V6 for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jun 2015 17:27:13 +0200 Original-Received: from localhost ([::1]:53303 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5bii-00014f-Cb for geb-bug-gnu-emacs@m.gmane.org; Thu, 18 Jun 2015 11:27:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5bid-0000lX-Aa for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 11:27:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5biY-0003lf-RS for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 11:27:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38750) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5biY-0003lZ-Nu for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 11:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z5biY-0004ve-Hp for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 11:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jun 2015 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20845 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.143464120218913 (code B ref -1); Thu, 18 Jun 2015 15:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Jun 2015 15:26:42 +0000 Original-Received: from localhost ([127.0.0.1]:50947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5biD-0004uy-5d for submit@debbugs.gnu.org; Thu, 18 Jun 2015 11:26:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42572) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z5biB-0004uk-8V for submit@debbugs.gnu.org; Thu, 18 Jun 2015 11:26:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5bi4-0003Nz-Uh for submit@debbugs.gnu.org; Thu, 18 Jun 2015 11:26:33 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:50690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5bi4-0003Nt-Rb for submit@debbugs.gnu.org; Thu, 18 Jun 2015 11:26:32 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5bi3-00061R-Ql for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 11:26:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5bhw-0003JM-PW for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 11:26:31 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:28560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5bhw-0003IE-JW for bug-gnu-emacs@gnu.org; Thu, 18 Jun 2015 11:26:24 -0400 Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t5IFQNhm030444 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Jun 2015 15:26:23 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id t5IFQN5C013890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Thu, 18 Jun 2015 15:26:23 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id t5IFQICx001470 for ; Thu, 18 Jun 2015 15:26:23 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104093 Archived-At: Function `bookmark-default-handler' picks up and handles the property (field) named `bookmark', if present. I see nowhere else where this property is used, and nowhere where it is set. And it is not documented. IOW, there is no notion or existence (AFAICT) of any bookmarks that record a `buffer' property. And yet, the *default* handler handles this unknown property - in two ways: * If the file is readable and is not visited then it visits the file using `find-file-noselect'. Why? * Otherwise, if the buffer named by property `buffer' exists then the default handler does nothing (no-op). The (non-English) comment here is "See if buffer BUF have been created.", which tells us nothing about why it is handled by doing nothing. This partial "handling" of the undocumented and never-set property `buffer' was apparently introduced in Emacs 23.1. As it never did anything, it was seemingly never noticed. This property should either be properly documented (in the doc string of `bookmark-alist'), as to its use and meaning, or its default "handling" should be removed, as misguided. I'd suggest that the unclear handling should just be removed. If there is some existing code distributed with Emacs that actually uses this property (and I can find none) then a bug can be filed for it. A grep of the Emacs sources for `bookmark-prop-set' shows no occurrences of that function outside bookmark.el, and that function is never used to set property `bookmark'. I have also checked all occurrences of `bookmark-make-record' in the Emacs Lisp sources, and found none that set or use property `bookmark'. AFAICT, this property does not exist, and its incomplete "handling" should be removed. On the other hand, if this handling was just added to bookmark.el by someone only as support for some 3rd-party code, then it doesn't belong here anyway - that 3rd-party code can advise `bookmark-default-handler' or simply define its own, non-default, handlers. In GNU Emacs 25.0.50.1 (i686-pc-mingw32) of 2014-10-20 on LEG570 Bzr revision: 118168 rgm@gnu.org-20141020195941-icp42t8ttcnud09g Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking=3Dyes,glyphs CPPFLAGS=3D-DGLYPH_DEBUG=3D1'