bug#17888: 24.4.50; key binding not shown in menu item for alias command

bug#17888: 24.4.50; key binding not shown in menu item for alias command

[Drew Adams]

emacs -Q

(defun foo () (interactive)(message "Foo"))
(global-set-key "\C-o" 'foo)

(defalias 'bar 'foo)
(define-key menu-bar-edit-menu [bar] '(menu-item "Do It" bar))

In the Edit menu, the key `C-o' is not shown next to item `Do It'.

Also:

(defun toto () (interactive)(message "Toto"))
(define-key menu-bar-edit-menu [toto] '(menu-item "To It" toto))


(defalias 'titi 'toto)
(global-set-key "\C-n" 'titi)

The binding `C-n' is not shown next to menu item `To It'.

Seems like a command alias should be treated like the aliased command
when it comes to showing key bindings in menus.  That would help users.


In GNU Emacs 24.4.50.1 (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
 -Ic:/Devel/emacs/include''

bug#17888: 24.4.50; key binding not shown in menu item for alias command

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> (defun foo () (interactive)(message "Foo"))
> (global-set-key "\C-o" 'foo)
>
> (defalias 'bar 'foo)
> (define-key menu-bar-edit-menu [bar] '(menu-item "Do It" bar))
>
> In the Edit menu, the key `C-o' is not shown next to item `Do It'.

Is it supposed to?  I'm not sure whether that would be surprising or
not.  Does anybody have an opinion?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#17888: 24.4.50; key binding not shown in menu item for alias command

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 20 Jan 2021 03:06:07 +0100
> Cc: 17888@debbugs.gnu.org
> 
> Drew Adams <drew.adams@oracle.com> writes:
> 
> > (defun foo () (interactive)(message "Foo"))
> > (global-set-key "\C-o" 'foo)
> >
> > (defalias 'bar 'foo)
> > (define-key menu-bar-edit-menu [bar] '(menu-item "Do It" bar))
> >
> > In the Edit menu, the key `C-o' is not shown next to item `Do It'.
> 
> Is it supposed to?  I'm not sure whether that would be surprising or
> not.  Does anybody have an opinion?

Indeed, it isn't clear at all that the expectations in this case are
correct.

bug#17888: 24.4.50; key binding not shown in menu item for alias command

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> Indeed, it isn't clear at all that the expectations in this case are
> correct.

So I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#17888: [External] : Re: bug#17888: 24.4.50; key binding not shown in menu item for alias command

[Drew Adams]

> > Indeed, it isn't clear at all that the expectations
> > in this case are correct.

To this user, at least, it's clearer that users
will expect the alias's key indication than that
they will expect no key indication.

More importantly, showing the key is more helpful
to users than not showing it.  The key has the
same effect, for users, as using the menu item.

Consider also:

(defun foo () (interactive) (message "FOO"))
(global-set-key "\C-o" 'foo)
(defalias 'bar 'foo)

C-h w bar

  bar is not on any key;
   its alias foo is on C-o

That's nice, complete info.  Both pieces of that
info are appropriate for such a Help command.

Presumably we tell users about the alias binding
to let them know that you can use `C-o' to, in
effect, invoke `bar'.

That's the info that's missing, for a menu item. 

> So I'm closing this bug report.