From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60186: 29.0.60; ruby-mode indentation of multi-line expressions Date: Fri, 30 Dec 2022 17:02:26 +0200 Message-ID: <4540a3e6-f736-9050-0aac-0a9be1459248@yandex.ru> References: <902440c7-706a-20e1-55af-4e12e8cdda2c@yandex.ru> <688159e9-f6bc-f233-08c4-9834bc00c455@yandex.ru> <74f977f6-d9ba-04bd-fba0-0dce4729cf0d@yandex.ru> <8d554fc2-7da5-cfe1-c865-023d56d222e3@yandex.ru> <95adedfa-7644-c78b-8853-fde8ec38f621@yandex.ru> <44ccf2d5-789f-f122-34f9-25871fdf1283@yandex.ru> <118143a7-0703-2538-9853-7009064e7bca@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7956"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 60186@debbugs.gnu.org To: Aaron Jensen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 30 16:03:26 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pBGus-0001u4-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Dec 2022 16:03:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pBGua-0004FG-4p; Fri, 30 Dec 2022 10:03:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pBGuV-0004CF-Qf for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 10:03:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pBGuU-0001ZE-EW for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 10:03:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pBGuT-0007X3-Ui for bug-gnu-emacs@gnu.org; Fri, 30 Dec 2022 10:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Dec 2022 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60186 X-GNU-PR-Package: emacs Original-Received: via spool by 60186-submit@debbugs.gnu.org id=B60186.167241255628923 (code B ref 60186); Fri, 30 Dec 2022 15:03:01 +0000 Original-Received: (at 60186) by debbugs.gnu.org; 30 Dec 2022 15:02:36 +0000 Original-Received: from localhost ([127.0.0.1]:35914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGu4-0007WQ-1v for submit@debbugs.gnu.org; Fri, 30 Dec 2022 10:02:36 -0500 Original-Received: from mail-ed1-f44.google.com ([209.85.208.44]:38745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBGu2-0007WE-AR for 60186@debbugs.gnu.org; Fri, 30 Dec 2022 10:02:34 -0500 Original-Received: by mail-ed1-f44.google.com with SMTP id r26so25555770edc.5 for <60186@debbugs.gnu.org>; Fri, 30 Dec 2022 07:02:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=FEFoCes2Uu9WbijYEQu0m0kNf9F4106JxBAmgiV0lNw=; b=UCsfc5wj0oD/7AblUBVoLF7cIka8qkFT4GhRAdLWUgCBr52bmzUQ/nefDXoqLT5kIw 3201/zqMnj6ev6YE/H5IOqeAyfCqCWaOYoVtXY5oSkbgC39yB9TpVUJXHCoGP8mUyIO5 iFjbrCJeqcndFSJ1UPFW9Ee7Al5JEPp5R0BFGuxxg1sjomWy39RZMY+zozDeVDPdwCZM /YyloMTQIa30nJ4ndp5HZuz8nluFvsDosAyvYs/ijNOVcGOWF0R19bnM36RfJPctnoed dKsisnwW+jjQkRM8sW2LE8VLxgMGadbyv5y0UCLQpzzR/nwZm9e4Yf2AHUGcPkEcDO1c h1sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FEFoCes2Uu9WbijYEQu0m0kNf9F4106JxBAmgiV0lNw=; b=0Ry07EVy6sH8KEEZoeWQWRNgtS1LdvSFAt9oMYbofMrF+a+v0TWylAOuJSwxIaZIDL rPA6Z5NC1YsDkYpPId1VZa1PviMEF6aWO1AFqOUsoiSsU8ungwcIf1yAOPAh7+7NueYj 3u7uIbnN9pQsQLNns9EzwP3irfZrosMoXyNa+pg0WiH2mSaxoSG36QanbGX8uqHeRAgx 9AVaALTz5enYoPZh1VYUO+SlrROXk6ROtr/ZZWLMQLH3pEEKJku6pH/UFM1GF2UFpXH9 24z+Qb3OpEtsEO8WEqjn27H9jdS89Z6fgbhlvmeXY3vYcIkqzMl9ssSwaADYP301Hn2z d9Ng== X-Gm-Message-State: AFqh2kpKfY38r4t5lAXi6N+UqeuIMD5/xM8dPefdXur+6tUrCi3dc1jn mYrB+OnFJSP/BU7qwcTgVxUaoIupYsI= X-Google-Smtp-Source: AMrXdXvf+z9VVeHtnOfWyK5b92XegvAMoOiwoGk44yoBc2jx7bLq7JSbKKLvVv58jarTqkqBAZTsgA== X-Received: by 2002:aa7:c30b:0:b0:46b:c11:c8d2 with SMTP id l11-20020aa7c30b000000b0046b0c11c8d2mr27717301edq.40.1672412548689; Fri, 30 Dec 2022 07:02:28 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g24-20020a50ec18000000b0046b847d6a1csm9428181edr.21.2022.12.30.07.02.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Dec 2022 07:02:28 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252128 Archived-At: Hi Aaron, On 30/12/2022 00:59, Aaron Jensen wrote: > On Wed, Dec 28, 2022 at 4:24 PM Dmitry Gutov wrote: >> On 28/12/2022 14:47, Dmitry Gutov wrote: >>> I guess that particular trend started with ruby-method-params-indent, >>> where I haven't managed to choose better names for the var, or the values. >> Semantics aside (I suppose we could go back and revise the naming a >> little later), could you test this new revision of the patch? >> >> I think I got the implementation simple enough now. >> >> The number of options has grown, though: >> >> (setq ruby-after-operator-indent nil >> ruby-block-indent nil >> ruby-method-call-indent nil >> ruby-parenless-call-arguments-indent nil) > I'll give it a shot some more, but these appear problematic: > > fixture( > EntityProjection::Fixtures::Projection, > projection, > deleted > ) do|projection| > projection.assert_attributes_copied([ > { :document_id => :id } > ]) > end > > Should be: > > fixture( > EntityProjection::Fixtures::Projection, > projection, > deleted > ) do|projection| > projection.assert_attributes_copied([ > { :document_id => :id } > ]) > end This example is for https://debbugs.gnu.org/60321, I think. Which we split off and postponed a little. The last patch was the latest revision of the changes for https://debbugs.gnu.org/60186. As long as this example is unchanged (indented the same as the current version of ruby-mode), it's good enough. It looks like this on my machine, though: fixture( EntityProjection::Fixtures::Projection, projection, deleted ) do |projection| projection.assert_attributes_copied([ { :document_id => :id } ]) end Could you please give the v6 patch a good run soon-ish: we have a good chance of getting it into Emacs 29 (together with ruby-ts-mode, which should reuse some or most of the options), as I've just found out. The deadline for checking all this in is pretty near, alas: 1-2 days.