From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables Date: Tue, 17 Dec 2024 00:30:04 +0200 Message-ID: <4536.66692353494$1734388292@news.gmane.org> References: <48132.687299379$1734370474@news.gmane.org> <877c7z5wbc.fsf@gmail.com> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8252"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74915@debbugs.gnu.org To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 16 23:31:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tNJcY-0001s1-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Dec 2024 23:31:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tNJcH-0005St-If; Mon, 16 Dec 2024 17:31:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tNJcF-0005Sj-Gh for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 17:31:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tNJcF-0002J9-8Z for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 17:31:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=/C2IpomurLvNiW1Ze9PJf6FbIoxxTNQKQI/cYJYUHT4=; b=kStD987scGkslgM/FagrdKmPzv49h4lfZoE3Ry2rI4zcrDeK+bki5jojWLjxhfpmnYf03dYXzQJK8e/xw7MEIobsKg18NdSAGCqLVW8t2wrvCNdMNHng0Il5v9uNlAhAqf8NhqwWVfjpq2we6R8bgKAmn3Lsb8Yf+KT81PgBn290v5U3189y7w4MKLXe7lGxsKPw5Dyj7auNgUuR1pjo+5wHNkza/44DQ2sjaL6HGCKBBJ+3OQxv6ml6wXNqpM9leYRdUXGSe3PbIiMiJEUkAWkEnBJyHg94UNv6HersUACdba+K43d+eCAyNx7rN8brQGy8LqP3IbYrJg8VXPal0g==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tNJcE-000634-Py for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2024 17:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Dec 2024 22:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74915 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74915-submit@debbugs.gnu.org id=B74915.173438824623218 (code B ref 74915); Mon, 16 Dec 2024 22:31:02 +0000 Original-Received: (at 74915) by debbugs.gnu.org; 16 Dec 2024 22:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:56618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNJby-00062Q-1w for submit@debbugs.gnu.org; Mon, 16 Dec 2024 17:30:46 -0500 Original-Received: from thaodan.de ([185.216.177.71]:41648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tNJbt-000626-W9 for 74915@debbugs.gnu.org; Mon, 16 Dec 2024 17:30:44 -0500 Original-Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 25B35D00049; Tue, 17 Dec 2024 00:30:05 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1734388205; bh=c4IjqDftScbPExscxKKbIUwYE1/M169NkRZJbGxD9Js=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=UzFUz6NQpBcdo1LZchVc53ThRfDwiSmQMPyU0/L2wTkr0EME0nui0YSGdNRWsfUws PZn8aWMIcZPdcrmyZP6sstOQMve6tqBA19XwjHNjiTDNrNFgd+cVpUVRD+guLZiy1/ S6NvPHUvoyEAHAX1nCmQbhFnBmh7QV3/itGqwtKZSuvR05RF02TWPti+tJ8k7jEtV9 5JhmyfNRQ/QzoTW5sbLKMZbqQXTNDz1e2JWpjP6lOf709/x4Ge/7BdFIBcI2LTuvKj 7ZkYzjBgcCjU0DCWO2aOSSCxR6/+LJDqpSako8h5WSzfVUD6fuDVspTu6y1c++IVnH zLBOEgB51ZeXppr2++ELwAdl8AyrdkLgXIKdVfYdiiogmsh18+TMSAiPGHAsSs7vBK k0ytzgRtrtdaQEJL862iwqzMkFD9tF8xtYoYyxeR5QDBlgXyGu7aUGHqTdW2FSus8Z N1xvlnJer4GWqxL5JJHe0m+6MruUvGnuzhzxz4rPOTO/NuHDKVRLUWs/QMJZRR2rx7 NTYDUPzI0YTj1z4euEz6ncsqhYwLjXSPCRwaoLgakf2WeSH8snPiaJsFDKJ//Ck4Nw Pkj/yHq+wpQUO1SSjZ2hJRlArvMGh8Ctw24wClcIwdwJd1k5LUF6jhszF9CmaOIzHP Xt9bnfeWI8CrIbqHwqTAjcuc= In-Reply-To: <877c7z5wbc.fsf@gmail.com> (Robert Pluim's message of "Mon, 16 Dec 2024 19:15:03 +0100") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297236 Archived-At: Robert Pluim writes: >>>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Bj=C3=B6rn Bidar via "Bug report= s for GNU Emacs, the Swiss army knife of text editors" said: > Bj=C3=B6rn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 = 00:00:00 2001 > Bj=C3=B6rn> From: =3D?UTF-8?q?Bj=3DC3=3DB6rn=3D20Bidar?=3D > Bj=C3=B6rn> Date: Mon, 16 Dec 2024 19:20:00 +0200 > Bj=C3=B6rn> Subject: [PATCH] Fix custom types of gnus-article-treat-h= ead-custom variables > > Bj=C3=B6rn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-tr= eat-date) > Bj=C3=B6rn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers) > Bj=C3=B6rn> (gnus-treat-highlight-headers, gnus-treat-display-x-face) > Bj=C3=B6rn> (gnus-treat-display-face, gnus-treat-display-face) > Bj=C3=B6rn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon) > Bj=C3=B6rn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar) > Bj=C3=B6rn> (gnus-treat-body-boundary): Fix custom types to > Bj=C3=B6rn> include all possible choices mentioned in the docstrings > Bj=C3=B6rn> and manual. > > The commit message only needs to mention the type you actually > changed, in this case `gnus-article-treat-head-custom' The type meaning the custom type or the variable? > Bj=C3=B6rn> --- > Bj=C3=B6rn> lisp/gnus/gnus-art.el | 5 ++++- > Bj=C3=B6rn> 1 file changed, 4 insertions(+), 1 deletion(-) > > Bj=C3=B6rn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el > Bj=C3=B6rn> index 8243e4e632b..13dfb737243 100644 > Bj=C3=B6rn> --- a/lisp/gnus/gnus-art.el > Bj=C3=B6rn> +++ b/lisp/gnus/gnus-art.el > Bj=C3=B6rn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom > > Bj=C3=B6rn> (defvar gnus-article-treat-head-custom > Bj=C3=B6rn> '(choice (const :tag "Off" nil) > Bj=C3=B6rn> - (const :tag "Header" head))) > Bj=C3=B6rn> + (const :tag "Header" head) > Bj=C3=B6rn> + (const :tag "First" first) > Bj=C3=B6rn> + (const :tag "Last" last) > Bj=C3=B6rn> + (boolean :tag "All body parts" t))) > > `t' is a const, not a boolean, the same as `nil', in the context of > defcustom. There's bolean in the context of custom but I the context of choice is should be const with nil or t. > Plus a lot of the docstrings look cut&paste, so I=CA=BCm not > entirely sure that it=CA=BCs the existing type that is wrong rather than > the docstring. The manual, in (info "(gnus) Customizing Articles") , seem to match with those and talk in general like they apply to all of these.=20