From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#23179: 25.0.92; Restore `M-,' to continue etags search Date: Mon, 4 Apr 2016 13:41:26 +0300 Message-ID: <450a8f6d-53a6-89a5-22b0-26859019c34b@yandex.ru> References: <48066d7c-e4d3-acf5-fdcf-1aa9a108cb90@yandex.ru> <83bn5ttwul.fsf@gnu.org> <83shz4sdi0.fsf@gnu.org> <5a9b5719-ea84-89bc-c0c5-37692fafd23d@yandex.ru> <8c1fc5c4-1f80-b889-3f16-55673836ed13@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------590C21B5E7016A7141D8B887" X-Trace: ger.gmane.org 1459766542 15868 80.91.229.3 (4 Apr 2016 10:42:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2016 10:42:22 +0000 (UTC) Cc: 23179@debbugs.gnu.org To: Anders Lindgren Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 04 12:42:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1an1xT-0001WT-Bz for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 12:42:11 +0200 Original-Received: from localhost ([::1]:57795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an1xS-0000XE-Rv for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Apr 2016 06:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an1xO-0000X8-R9 for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 06:42:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an1xK-0004wO-Q5 for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 06:42:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53484) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an1xK-0004wK-MH for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 06:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1an1xK-0003lM-FI for bug-gnu-emacs@gnu.org; Mon, 04 Apr 2016 06:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Apr 2016 10:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23179-submit@debbugs.gnu.org id=B23179.145976649614433 (code B ref 23179); Mon, 04 Apr 2016 10:42:02 +0000 Original-Received: (at 23179) by debbugs.gnu.org; 4 Apr 2016 10:41:36 +0000 Original-Received: from localhost ([127.0.0.1]:50611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an1wu-0003kj-Ik for submit@debbugs.gnu.org; Mon, 04 Apr 2016 06:41:36 -0400 Original-Received: from mail-lf0-f54.google.com ([209.85.215.54]:36189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an1wt-0003kX-JG for 23179@debbugs.gnu.org; Mon, 04 Apr 2016 06:41:35 -0400 Original-Received: by mail-lf0-f54.google.com with SMTP id g184so89222745lfb.3 for <23179@debbugs.gnu.org>; Mon, 04 Apr 2016 03:41:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=EP8MCd1ZHyqZOGbfMnb0UYUetA5xg+Hty2QMaQwgBcA=; b=riOZCiABl0dAY37iGl69CyFON5QM9lRnQ9lf78AFy7xTu5GzsR1kASf40+nCNNg6oB s43stf21QhrRdYqNM70L/4W7aoKROKwVZ92QQZdBaN7BRSmFeD7tlIZtotJm/PIH25NZ 9sOQ3WXkeOp6gQwDAEirP201Ywo3CwU76saTr6IfQojm2si+GMq5JWt1j5af5s1OKtKX +wu9eHhSRiVtQIXRHJkVE7RcmFSo5w8UiKzkqd1vsU7bDOIm/UX0DJqZeZsrt2894ZdD pb6YlxxIBhwfrpcNdtr7w9/iJy6MfNLVtUCYwvWR1jp1346ZRdo7gVKuL9yB3jj12O20 evYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to; bh=EP8MCd1ZHyqZOGbfMnb0UYUetA5xg+Hty2QMaQwgBcA=; b=SJbjj4nKq7yWHFe0zJDsw9E+JLBxbzcKURgDGGC8YJw4fzMOYjF9J4BDU0KBJidAo1 pQSLnHnP1dJ5JrGx5azsp528QuSK53osqYk69CTfEtsszTFelZ2bPiqtIuIrOirdWMZU 7vfKCRvvfOCiHIQU3hhoT8zSTHGaRYxHbreTVtH/+u56klDbgvJ+ADmhoG4wyCTelzdq Rv5WtgBkMj2sUZnk/h9TeHBfIwh54mU4XU9JOwh/wDhMfCVlXl/AOjzTlacu+kzZBjPG DcKpdwmHR7N6JM5Xau+Xo+vVD7Qdl9EiEHoShjgWE7F2ow3TZ+AQJ1PJkvpW6KAKTbtI H2sg== X-Gm-Message-State: AD7BkJLsOgvxad5CtFNavt+eF80hY1tJAbfXBQ89AIqz3dzhT1w4/V+hbpLwB4Niawo1IA== X-Received: by 10.194.172.99 with SMTP id bb3mr8671151wjc.46.1459766489603; Mon, 04 Apr 2016 03:41:29 -0700 (PDT) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id m6sm28343969wje.21.2016.04.04.03.41.27 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 04 Apr 2016 03:41:28 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:116014 Archived-At: This is a multi-part message in MIME format. --------------590C21B5E7016A7141D8B887 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 04/04/2016 11:43 AM, Anders Lindgren wrote: > Unfortunately, I have very little time to do heavy lifting on Emacs > anymore (which is why recently stepped down maintaining the NS port). > However, I try to help out by providing user experience feedback, > whenever I find something that doesn't feel right. As far as user feedback goes, I need more than "the new key bindings are different from the old ones". In-depth discussion of new generic commands and their semantics would be welcome. If nobody steps up to implement your incremental search UI soon, though, we'll most likely release Emacs 25.1 with the current xref UI. > Not updated when? When you call `next-error'? I imagine that's > something to implement in that facility, then, so that every other > mode implementing next-error-function benefits. > > > Yes. In a *grep* buffer, the point and arrow moves to reflect the > current entry. OK. That's already been brought up in one of the bugs I've referenced. > It could be easily fixed by a call to `font-lock-ensure' (at least for > files already loaded into Emacs). Please test the attached patch. I'd like to know if there are cases when the highlighting overhead is noticeable. However, this approach precludes an optimization I've been considering: when a given regexp doesn't use any Emacs-specific syntax, there's no need to visit the file. We would simply construct the match based on Grep's output. It would speed up the process a lot, in certain cases. > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20489 > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=20493 > > Help welcome. > > > OK, I see that those problems are known. I hope that they get fixed, as > they are annoying. Indeed. But so far there's no consensus on how to go about fixing them. > On the other hand, yes, the fact that the matches don't appear as > soon as they're available, is a problem. Could you open a separate > bug for that? > > > I'd rather prefer if you would file a bug, I don't know which part I > should refer to, as I've only used your experimental `tags-find-regexp' > code. You've never used e.g. xref-find-references? Bug#23212 filed. --------------590C21B5E7016A7141D8B887 Content-Type: text/x-patch; name="font-lock-ensure-in-xref--collect-matches.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="font-lock-ensure-in-xref--collect-matches.diff" diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el index feed0fb..6cc8dc1 100644 --- a/lisp/progmodes/xref.el +++ b/lisp/progmodes/xref.el @@ -992,6 +992,7 @@ xref--collect-matches (line-beg (line-beginning-position)) matches) (syntax-propertize line-end) + (font-lock-ensure line-beg line-end) ;; FIXME: This results in several lines with the same ;; summary. Solve with composite pattern? (while (re-search-forward regexp line-end t) --------------590C21B5E7016A7141D8B887--