From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 2 Dec 2010 11:22:11 -0800 Message-ID: <44FB8E26FD824BB18AE8A367F560C091@us.oracle.com> References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> <4CF7EDED.5090500@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1291319132 2112 80.91.229.12 (2 Dec 2010 19:45:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 2 Dec 2010 19:45:32 +0000 (UTC) Cc: 7533@debbugs.gnu.org To: "'martin rudalics'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 02 20:45:26 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1POF5p-0004WN-O4 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Dec 2010 20:45:26 +0100 Original-Received: from localhost ([127.0.0.1]:45963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POF5p-0000jY-55 for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Dec 2010 14:45:25 -0500 Original-Received: from [140.186.70.92] (port=60386 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POF5e-0000Y4-E1 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 14:45:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POF5Z-0000Cf-33 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 14:45:14 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POF5Z-0000CT-0u for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 14:45:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1POEfK-0003zu-Lb; Thu, 02 Dec 2010 14:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2010 19:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7533-submit@debbugs.gnu.org id=B7533.129131742815259 (code B ref 7533); Thu, 02 Dec 2010 19:18:02 +0000 Original-Received: (at 7533) by debbugs.gnu.org; 2 Dec 2010 19:17:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POEeR-0003y3-Kd for submit@debbugs.gnu.org; Thu, 02 Dec 2010 14:17:07 -0500 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POEeQ-0003xN-74 for 7533@debbugs.gnu.org; Thu, 02 Dec 2010 14:17:06 -0500 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id oB2JMe8W026565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 2 Dec 2010 19:22:42 GMT Original-Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id oB28Ofoq024228; Thu, 2 Dec 2010 19:22:38 GMT Original-Received: from abhmt018.oracle.com by acsmt355.oracle.com with ESMTP id 821860081291317730; Thu, 02 Dec 2010 11:22:10 -0800 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Dec 2010 11:22:10 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <4CF7EDED.5090500@gmx.at> Thread-Index: AcuSU+FMDb7mFhguRVqKcIvJHqTY/gAAPDbg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 02 Dec 2010 14:18:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42085 Archived-At: > This would be funny when `pop-up-frames' is nil and a window > gets reused for showing the *Deletions* buffer. In particular > if that window is the only window on its frame ;-) Agreed. But what's the right test? It is _not_ `pop-up-frames' non-nil, because users can do other things than that to cause a new frame to be created for this dialog. What's needed is a test of whether a frame was newly created for this dialog buffer. What's the code for that test? > BTW the `save-window-excursion' is completely useless when > you pop up a new frame. Yes, I know. It was already there, and I left it. It seems benign in this case AFAICT, but feel free to fix this as it really should be fixed. The bug report is about the annoyance of not deleting a new frame that was created (using whatever mechanism, including non-nil `pop-up-frames') for dialog purposes. When the dialog is finished, such a new frame should disappear. Users should not need to manually delete it. How the bug gets fixed is up to you. I'm reporting the problem, not a particular fix. > > The important thing, for me, is that the frame that was > > created just to show the files that will be deleted (or whatever) > > goes away. It should be only a _temporary_ frame because its only > > raison d'etre is as part of the deletion etc. _dialog_. > > Here I have a simple function called `quit-restore-window' which does > exactly that. If that does what's needed, fine; go for it. I have no objection. > > [Martin will explain that a different test from > > `one-window-p' is more appropriate. ;-) IIRC, he generally > > prefers something like this to (one-window-p win): > > (eq win (frame-root-window (window-frame win))).] > > Because `one-window-p' calls `next-window' which I don't > like. See the recent discussion about `loop' endlessly cycling > over windows. As I said, "Martin will explain...". That's fine with me, as long as the bug gets fixed.