From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Wed, 20 Nov 2019 01:17:18 +0200 Message-ID: <448da651-20ac-14ba-6916-98ab3c23c9d1@yandex.ru> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <908fb02e-1091-0dff-2faa-71c3ec721b76@yandex.ru> <83h82z2250.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="88443"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 20 00:18:48 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXClk-000MqS-ID for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Nov 2019 00:18:48 +0100 Original-Received: from localhost ([::1]:52284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXClj-000401-DF for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Nov 2019 18:18:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43340) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXCl3-0003j4-5c for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:18:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXCl1-0008R8-Tt for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:18:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXCl1-0008Qi-Ql for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXCl0-0004L9-7d for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 18:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2019 23:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157420546616642 (code B ref 38044); Tue, 19 Nov 2019 23:18:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 23:17:46 +0000 Original-Received: from localhost ([127.0.0.1]:48679 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCkX-0004K8-Bq for submit@debbugs.gnu.org; Tue, 19 Nov 2019 18:17:46 -0500 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:33685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXCkT-0004Jt-Ek for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 18:17:29 -0500 Original-Received: by mail-wm1-f46.google.com with SMTP id a17so3671757wmb.0 for <38044@debbugs.gnu.org>; Tue, 19 Nov 2019 15:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xCPeupys8RSgdrXPzr2mrY+gX8leHSUoQTX3ZPrvjbw=; b=QE66sseqBG199uQtTHQp1/d6wpWeIKxQ+QXhsFF6/w75sq8mdPvLYM4EkVDOsotYdl JEOSHu7EoZqY7/+cCvD3XyJ0Q6wDehu98Ff6f3xtAsEITDF99Zc4IvetJNZGzFyDkGi6 6XTnmbDsPXOrgYuBsE1VlzzAE/sn0YloNfYurVwHvrybB8Z55Dei7bDDmTDlNCW21iN9 zFq3p0ffNxP/k5cn6xoHTko/qL8EBQ6x4yLrKJWj6ElpmDQDAqTbKRD6nD7kmAqnWCQp +LvOM7J1dSwa0DTX5PRiCpysGM1OVJB+oVv40jXvoSMY3rSj+lI6paa3kqmNBWE+yGuz sYcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xCPeupys8RSgdrXPzr2mrY+gX8leHSUoQTX3ZPrvjbw=; b=pCoppOlzYNbajovqfXbO99xYORQ2y771EqKxSSHWmJa5CTF+Dgm8e0vKvo6owo/MOp 8QXz/4gU2u2UjwOKIIbRLb2lcjOPy9GD2ho1K6dPolJHdZimPIRHY0FwoNny7O9g+bS6 0TdjmDw8hnMqQxl4goYei8+gsRk92hfiVAutTnvn7gEezWNLjVal7SS5xSBuUXECicyn eSZ8lJSGHWEfaDOGc0NFxU8TCefP89lMjaUxf/8G2C2SJFARYw/NBgwETU6iFl2eorNm vOARO7CmD6XcTVqTQKTrAlgeYsQlnnEGb8jcKS8Jo7DdxIGTLwgCo1MRCjmFpTKDBO+3 5vrw== X-Gm-Message-State: APjAAAXcIcCf3uMpwcheDmF2IPAkCdynn7+Nd0hpL+SvjqV9zWtNRcpQ sEJhBzTcUT5bjveJvpCvZH0= X-Google-Smtp-Source: APXvYqwxOpE+Mb8vLv4/FG8HzsY2kSrYY6zX9HDs+ePjO1wP1a67Ek9BOB4lUn73BoTUWk6fEVsN7Q== X-Received: by 2002:a1c:2e8f:: with SMTP id u137mr338503wmu.105.1574205443532; Tue, 19 Nov 2019 15:17:23 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id b3sm4473457wmj.44.2019.11.19.15.17.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 15:17:22 -0800 (PST) In-Reply-To: <83h82z2250.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172022 Archived-At: On 19.11.2019 19:43, Eli Zaretskii wrote: >> It's kind of both. 'git show HEAD' is the format that I'd personally >> expect: some meta info, including the commit message, followed by the >> diff contents. > > That's true, but I'd hesitate to introduce a new class of "show" > commands just because Git has it. I see no problem showing the > meta-data with diffs (when Git is the back-end), perhaps with an > option to disable that. These two sentences seem to contradict each other. To do the latter, we need to "introduce a new class of show commands". Because vc-git-diff won't print any metadata. > My rationale is that other VCSes have a diff > command that shows only the diffs, and that command is used "to show" > a revision with those VCSes. IMO the log message is more important because it describes and justifies what happened. Showing the diff is good as well. Maybe the other VCSes don't have a simple command to do the same, but they can either be called twice, or use special formatting. For instance, Hg can use this command: hg log -r -p >>> And don't we already have >>> a "diff" command which shows diffs for a specific revision? >> >> It *can* do that. And we also have a command that shows the revision log >> message and stuff: vc-annotate-show-log-revision-at-line. We could reuse >> its logic. >> >> And either add a diff output at the botton (making it a different >> command an dealing with major mode having to support both the headers >> and the diff), or rely on log-view-mode's bindings (the user can press >> 'd' or 'D' there). > > I think we should disconnect this "show" command from "log". It is > conceptually wrong to make them related. Of course a vc-log buffer > could have (and already has, AFAIK) a binding to a command that shows > the revision at point's line. Linking to a commit message from a diff buffer wouldn't really work. But we can "link" to a diff buffer from a common message buffer. Of course, it's better to just display both.