From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#24896: JSX prop indentation after fat arrow Date: Fri, 9 Dec 2016 02:18:12 +0200 Message-ID: <447f307f-e226-e6a5-f62a-88bcdcda74df@yandex.ru> References: <6d48deda-1d14-2d50-ca86-c89f35bf37db@yandex.ru> <77f1f91d-2f8c-0509-7a16-50bae68f3883@jacksonrayhamilton.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1481242753 24913 195.159.176.226 (9 Dec 2016 00:19:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 9 Dec 2016 00:19:13 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Jackson Ray Hamilton To: Felipe Ochoa , 24896@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 09 01:19:09 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF8u4-0005dr-D2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Dec 2016 01:19:08 +0100 Original-Received: from localhost ([::1]:43650 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF8u8-0000vV-7h for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Dec 2016 19:19:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cF8u1-0000v9-Bj for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 19:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cF8ty-0003jT-7k for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 19:19:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47815) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cF8ty-0003jK-5B for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 19:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cF8tx-0001Py-Tq for bug-gnu-emacs@gnu.org; Thu, 08 Dec 2016 19:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Dec 2016 00:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24896-submit@debbugs.gnu.org id=B24896.14812427035395 (code B ref 24896); Fri, 09 Dec 2016 00:19:01 +0000 Original-Received: (at 24896) by debbugs.gnu.org; 9 Dec 2016 00:18:23 +0000 Original-Received: from localhost ([127.0.0.1]:34981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF8tK-0001Ov-Fv for submit@debbugs.gnu.org; Thu, 08 Dec 2016 19:18:23 -0500 Original-Received: from mail-wj0-f174.google.com ([209.85.210.174]:34332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cF8tI-0001Oi-Ba for 24896@debbugs.gnu.org; Thu, 08 Dec 2016 19:18:21 -0500 Original-Received: by mail-wj0-f174.google.com with SMTP id tg4so1801121wjb.1 for <24896@debbugs.gnu.org>; Thu, 08 Dec 2016 16:18:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MvFTbpkLB7T6Tu51ALOWbG3+/S6EgGhWtjeJ/o0UpR8=; b=YFbfBWQws85SfNJZ5lZT0UXx3s9OfByHXbTKuEjFbXCpPgjd3u9kq2+KBJVA9ZaSKe km8u9Y5YNUMVNqIvlUiZ9yBLvPlFiPhN2JkQYpQYoCyTfZNr27esHzqyHKTmk0NwR5NR 8hqw4Ip87kqI8u+26h6EQ8I+D0M6U1G1etp/N0tWrYwOCWhPS61O7MT9tK2XGsOTd+mV mfpXUzWyX09fpATB9rWwfpgFUPd1Ip+6WGhlJwoHNPiYDy6PERFKYcxz5WsGZptHEkIM L49tbMZ1rOcsYZ6Ek+MnjLow047fH97XIBBHn59kTHFALuNIgaqN8Em/0bT2ZPDLRb1W tmVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MvFTbpkLB7T6Tu51ALOWbG3+/S6EgGhWtjeJ/o0UpR8=; b=Onfhxp2LtX0HOmBN1fYtUxCE4yZ/5yBTJlk/OWKO1rOHYenomdo8B8+AX+EzfYcQiq csermx+WqbSmZrHdcn2vSMZzL7YOZuHs6OYp3uohGt/JMqLr9zC3RNmgWygsu1iL4D+S b7HJ59RrQkvdBRUtSJdbf31xHH6nsIIyWgGsJqIQOFuw2VKX2c2u2Iy4t6ua/Uf41wn1 zvHjgq1aq09wQ0Zd+vgJj/gNXU3WQkPzv/nJz80pBWVAymHRduhov/FlmJli8sjykpkd WvljzqUpzXp6BdwIgkMdWnuvSAeUQyJq4krJacwPTx5ZR4tTL77VbfGMuwgR9vjJsOSp yxJA== X-Gm-Message-State: AKaTC03klgHfbCmaM7cKWE8ej5SWXZ+MadaN85OfxaJrXZG06W+NEVIDVQDCGPZ/pTu8gA== X-Received: by 10.194.108.10 with SMTP id hg10mr79382926wjb.58.1481242694555; Thu, 08 Dec 2016 16:18:14 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id l2sm39532369wji.7.2016.12.08.16.18.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Dec 2016 16:18:13 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126757 Archived-At: On 08.12.2016 13:12, Felipe Ochoa wrote: > syntax-propertize-function is outside my limited knowledge of emacs > internals. But to the extent that one could say "Outside of comments and > strings, propertize `=>' as punctuation," I imagine that would fix it. Yes, it can help with that. > Also, this may be a dumb question, but are the tests in the "manual" > directory meant to be run manually? If not, how would I run the tests there? You can e.g. 'cd test/manual/indent' and run 'make js-jsx.js.test', to compare the indentation in js-jsx.js against what the current js.el does. > And then finally, should I just email a patch with the proposed change & > tests for this? An email with a diff attached could be enough. But if you wanted to include a "proper" commit message as well, see CONTRIBUTE in the top directory.