From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Romanos Skiadas Newsgroups: gmane.emacs.bugs Subject: bug#27647: 26.0.50; Line numbers implemented natively disappear momentarily when frame out of focus Date: Thu, 9 Nov 2017 18:14:30 +0000 Message-ID: <444bc8ce-8551-1576-1a20-1b41698822bf@gmail.com> References: <83eftnitpj.fsf@gnu.org> <87inekjzy8.fsf@gmail.com> <87efp8jznq.fsf@gmail.com> <87shdo4150.fsf@users.sourceforge.net> <83r2t7qvn1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1510251324 13437 195.159.176.226 (9 Nov 2017 18:15:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 9 Nov 2017 18:15:24 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 Cc: 27647@debbugs.gnu.org, agrambot@gmail.com, kaushal.modi@gmail.com To: Eli Zaretskii , Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 09 19:15:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCrMA-00037A-D7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Nov 2017 19:15:14 +0100 Original-Received: from localhost ([::1]:38258 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCrMH-0003MB-Na for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Nov 2017 13:15:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eCrM4-0003E8-Qf for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 13:15:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eCrLy-0003jw-UZ for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 13:15:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52051) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eCrLy-0003jq-QC for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 13:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eCrLy-0000vQ-M2 for bug-gnu-emacs@gnu.org; Thu, 09 Nov 2017 13:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Romanos Skiadas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Nov 2017 18:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27647-submit@debbugs.gnu.org id=B27647.15102512823514 (code B ref 27647); Thu, 09 Nov 2017 18:15:02 +0000 Original-Received: (at 27647) by debbugs.gnu.org; 9 Nov 2017 18:14:42 +0000 Original-Received: from localhost ([127.0.0.1]:60732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCrLd-0000uc-Rf for submit@debbugs.gnu.org; Thu, 09 Nov 2017 13:14:42 -0500 Original-Received: from mail-pf0-f177.google.com ([209.85.192.177]:55657) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eCrLc-0000uP-KA for 27647@debbugs.gnu.org; Thu, 09 Nov 2017 13:14:41 -0500 Original-Received: by mail-pf0-f177.google.com with SMTP id 17so4802927pfn.12 for <27647@debbugs.gnu.org>; Thu, 09 Nov 2017 10:14:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=7ZFwFnQqTBEnGmdEEHhq06705virXWQe8GXwRivFj9s=; b=qHyVjx3qYjDMD4UeCZeZYinhBiNLxzvtN+BDPS77KUPYoUA+RHg7xhFbhpNG/f6cfZ uDprrdWr53BdRU3LR9y0ujnFg0+3ZTuTEU6nNGjihKoSihkRhZIE5jDG5tJhzHieuMNu cdswKa4gFJvCbmOG8kqXKzmuhc9Dhz8byy6LWYBE9hun8WjZODKxaplvNVe4twZJ9RLy uadc7at30WeD18aeRD6AXgCyO+rkBX6Cbyg3nuvwzcNd3fjld7AXd04/ntPHSm7hRM8l a8+EtxH53PV+LH1u+mRenA2CssYWFOwTwp0/efZkIuMeRyVyeIhxV4MAVUJkzUUrf9Xr 2pWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=7ZFwFnQqTBEnGmdEEHhq06705virXWQe8GXwRivFj9s=; b=Mbh0iwncRN/Db6Bi4uXXUsCx4vIb59EukBwsybqxOcmGCkpL7S91lO7cMsCC7V2h/h tq2cTnw4sYHrp5GnHpXbIhN13zTONI/263A0MwoqIJjVVsg4fMa+GQlySvpnd/qETNIE /JSxbmASkf/tNIs8v7aX9+0w2R/HFQomQ9Sy3pY7z60YutkYzz8eZrjjRwGzPXb/Y/52 haUWD06kW5J3juXeu80qBMmz0ZXB3+WHxjNgv9dIi0ZzC3QKRdoUcXkY78z88/+PCLtQ Fs6afX5Ld1QgXhG9yY29MAkbwjQ3h9t770cLnvdRuaVLKpRU10DmxJljI26k+pRggN2N xm7Q== X-Gm-Message-State: AJaThX4+plxiYt/mwoi1s5+uYeTIvdvUZQBSr8OFnAB/fK5CAZ+mCbud 7+Lmxc/pHrpnphK8EB2Nzyg= X-Google-Smtp-Source: ABhQp+QE/kc9WFoukIOqZlzS7yudVPxZPF97hQz4eLYjH9F2aqsqO8YUc7u/1kaZxHGiwX/BTYqsCg== X-Received: by 10.101.66.2 with SMTP id c2mr1240811pgq.403.1510251274675; Thu, 09 Nov 2017 10:14:34 -0800 (PST) Original-Received: from [10.83.37.251] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id k20sm15025488pfg.141.2017.11.09.10.14.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Nov 2017 10:14:34 -0800 (PST) In-Reply-To: <83r2t7qvn1.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139680 Archived-At: Work for me, thanks everyone for figuring this out and fixing it. Best, Romanos > I propose a slightly different patch below; could you try it? > > diff --git a/src/dispextern.h b/src/dispextern.h > index 2f55d8c..430afbf 100644 > --- a/src/dispextern.h > +++ b/src/dispextern.h > @@ -3452,7 +3452,14 @@ void gamma_correct (struct frame *, COLORREF *); > void x_implicitly_set_name (struct frame *, Lisp_Object, Lisp_Object); > void x_change_tool_bar_height (struct frame *f, int); > > +/* The frame used to display a tooltip. > + > + Note: In a GTK build with non-zero x_gtk_use_system_tooltips, this > + variable holds the frame that shows the tooltip, not the frame of > + the tooltip itself, so checking whether a frame is a tooltip frame > + cannot just compare the frame to what this variable holds. */ > extern Lisp_Object tip_frame; > + > extern Window tip_window; > extern frame_parm_handler x_frame_parm_handlers[]; > > diff --git a/src/xdisp.c b/src/xdisp.c > index 69b74dc..d4a0261 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -21126,7 +21126,13 @@ should_produce_line_number (struct it *it) > > #ifdef HAVE_WINDOW_SYSTEM > /* Don't display line number in tooltip frames. */ > - if (FRAMEP (tip_frame) && EQ (WINDOW_FRAME (it->w), tip_frame)) > + if (FRAMEP (tip_frame) && EQ (WINDOW_FRAME (it->w), tip_frame) > +#ifdef USE_GTK > + /* GTK builds store in tip_frame the frame that shows the tip, > + so we need an additional test. */ > + && !NILP (Fframe_parameter (tip_frame, Qtooltip)) > +#endif > + ) > return false; > #endif > > > >