From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Mon, 18 Nov 2024 18:54:26 +0200 Message-ID: <44260.566057504$1731948922@news.gmane.org> References: <86frnovhg8.fsf@gnu.org> <867c90vbfk.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27213"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 18 17:55:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tD51w-0006vO-JK for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Nov 2024 17:55:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tD51j-0000St-IA; Mon, 18 Nov 2024 11:55:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tD51i-0000Sh-8q for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 11:55:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tD51h-0007uJ-Vr for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 11:55:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=sjNpDMR6Psz5WGpvmg2z7ib/ph4XIksEHkJif0B2T1A=; b=kAMrTSyqxUYue2QlkoWIkGyXrntGql9gMqzwz0C7r7o/jfm2P637qpkatXF4CNYWkv0Hh1g6CI1TgVU5VKsa/bCH9CuScj1Q8M8uYCiLfy21k9uC2b4ReMCdZqKIl+GBSJ8KFhqApTUShRq4g5yOpQXKdfCvRSJX49mck2XiR655nrl/SanEHdTtW8XzC+uWLmkOT7w4Tf1Anig/KS9wlaL4dVl6ww1DOigylG5aSoNoPijfSEhPJ02O4SZtkD+JjSSf7P1QEyqfFdQDOOnguQsx1z7f4THAoPbHVRye+errOvZ8Dbd7KPqGruY8KAZx+RO5bZo3J5ZsAer9HvnSIA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tD51h-000429-Q5 for bug-gnu-emacs@gnu.org; Mon, 18 Nov 2024 11:55:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Nov 2024 16:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.173194887415456 (code B ref 74413); Mon, 18 Nov 2024 16:55:01 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 18 Nov 2024 16:54:34 +0000 Original-Received: from localhost ([127.0.0.1]:34975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD51G-00041D-2f for submit@debbugs.gnu.org; Mon, 18 Nov 2024 11:54:34 -0500 Original-Received: from thaodan.de ([185.216.177.71]:42340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tD51D-000410-6a for 74413@debbugs.gnu.org; Mon, 18 Nov 2024 11:54:32 -0500 Original-Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 3A96AD00083; Mon, 18 Nov 2024 18:54:28 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1731948868; bh=uhRkR9ej8gbZG6vXZ2U+zF39tjkMT0U7xBLs4L4LBLY=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=ZlQsjmRZsSy2+YIFKA8kqZ3NpoNn3ofO1OWqBs+FOqBdEVzm95qPtP/uQBQMGGMza 59nocjvjlqvY1Ooy/TdH6P7U7Efy2dcba5KpQDneK1IvuZjM3701bJYKm9/b6PcbW/ ZJ+Ci+lYKmLj6bjvmbvkUDf4dZHvsi2cpYMXnnlotpgSm227mqeg1QLyNUvxBRt7c6 9js49ikz5PRqMXWjnpXM2Fk/MPvDsNmYaFVFu1WvHJlR1wfDhBzft50xfTCaXovK1c I5HrXDM2q60OJyITM+wDH8o1YKKB6gkEn64h4s4BBR2O7L+3VYw6+yuKxLn+9vhySS XSmVUTsbPR06CmhswmKuH3tGWneEqmT8QMQQ0HXRyYSsxzLUOFWma09/P1esd3B5Pr WyNPqN3iCTsFJdjWlHBJ/V/tXHXDHGVgS3BGctjgwEsi2bD5wTsgmggEsK62pagjnV lNV6dFfpm+w23i9ufPAqTv0MLtQCQK6uLQBi9ayMNjmwapySZj8PSf1TitcUer0vAa H7yFd88LujGXiMxah+AJomKlRHYhTlCTNa8GudQXH/s/Pi6uNXTR1+6jZrmzGV/GV9 RW1tOm+qu13jnNEQhGIr2pSI3lrXdTtrEwjVj8LXJScE4aoSzUl+Df3xhWGP6eO6vE FcputJH8944yxBw3ZVT6vD5E= In-Reply-To: <867c90vbfk.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Nov 2024 16:55:27 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295602 Archived-At: Eli Zaretskii writes: >> From: Bj=C3=B6rn Bidar >> Cc: Po Lu , 74413@debbugs.gnu.org >> Date: Mon, 18 Nov 2024 16:21:28 +0200 >>=20 >> > Doesn't that go against the tendency to have _less_ detailed/private >> > information in the build? We've lately removed some relatively useful >> > infos from what we report in commands that use the build information. >>=20 >> The information added is only the branch and the repository similarly as >> used by the Android builds. There's no private information there unless >> the exact change reference Emacs was built on is private. > > The branch name could be private. That could be but at that point you wouldn't have access to the binary that contains the information and probably wouldn't report bugs to this tracker either I think. > Stefan, WDYT about this feature suggestion? > >> > More generally, could you present the motivation and the rationale for >> > making this information available in production builds? >>=20 >> The information wouldn't be only available to production builds but also >> testing/developer builds that are builtin in a CI environment to >> e.g. provide test builds for developers to use or to instruct user to >> use to try to reproduce a bug. >>=20 >> Even for production builds it could be useful for convenience to track >> down the exact reference/branch a build came from from, that's >> side effect only thou. > > This is already available if Emacs is built in a Git repository, and > the information is stored in the dumped Emacs. So what is gained by > also recording the repository version on a disk file external to > Emacs? The information is only stored if the worker already had git installed and checked out the sources with git inside the worker. Also the function currently fails unless the system the user uses also happ= ens to have git installed and the sources if the are installed also contain the VCS metadata. Storing the VCS metadata in the sources doesn't happen usually as it increases the size of a good chunk. In my case e.g. from 188MB to 788MB. Why not have the same feature for other platforms too?