unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Wanrong Lin <wrglin@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>,
	Lars Ingebrigtsen <larsi@gnus.org>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 39484@debbugs.gnu.org
Subject: bug#39484: 26.3; try-completion bug
Date: Wed, 28 Oct 2020 08:59:24 -0400	[thread overview]
Message-ID: <44009e48-c8b7-72c1-b505-4308d84c24e7@gmail.com> (raw)
In-Reply-To: <87lffq1snn.fsf@igel.home>

This is not implementation detail. This is the interface of this 
function. User/caller should know exactly what are the rules for the 
return value.

So in summary, my two points:

1. Return value is not ideal. You can argue it is still not wrong, but I 
think we can improve.
2. Even if we don't change anything here, we need to make this 
less-than-ideal behavior clear in the documentation (doc string).

I hope I convinced at least some of you.

Wanrong

On 10/28/2020 7:44 AM, Andreas Schwab wrote:
> On Okt 28 2020, Lars Ingebrigtsen wrote:
>
>> Andreas Schwab <schwab@linux-m68k.org> writes:
>>
>>> The case always matches one of the candidates.
>> Yes.  An arbitrary candidate (well, the first one, but it's not
>> documented, which means that it's arbitrary).
> It is not nessesary to document each and every implementation detail.
> That makes it difficult to change the implementation later, and it also
> unduly restricts the way a collection function can handle that
> situation.
>
> Andreas.
>






  reply	other threads:[~2020-10-28 12:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07 15:44 bug#39484: 26.3; try-completion bug Wanrong Lin
2020-10-27 18:42 ` Lars Ingebrigtsen
2020-10-27 19:08   ` Andreas Schwab
2020-10-27 19:17     ` Lars Ingebrigtsen
2020-10-27 20:17       ` Wanrong Lin
2020-10-27 20:28         ` Andreas Schwab
2020-10-27 20:44           ` Wanrong Lin
2020-10-27 21:21             ` Andreas Schwab
2020-10-28  0:44               ` Wanrong Lin
2020-10-28  0:47                 ` Wanrong Lin
2020-10-28  0:57                   ` Wanrong Lin
2020-10-28  7:51                     ` Andreas Schwab
2020-10-28  9:35                       ` Lars Ingebrigtsen
2020-10-28  9:42                         ` Andreas Schwab
2020-10-28  9:50                           ` Lars Ingebrigtsen
2020-10-28  9:56                             ` Andreas Schwab
2020-10-28 11:16                               ` Lars Ingebrigtsen
2020-10-28 11:44                                 ` Andreas Schwab
2020-10-28 12:59                                   ` Wanrong Lin [this message]
2020-10-28 14:45                                     ` Stefan Monnier
2020-10-28 15:47                                       ` Wanrong Lin
2020-10-28 16:34                                         ` Stefan Monnier
2022-04-23 13:17                                       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44009e48-c8b7-72c1-b505-4308d84c24e7@gmail.com \
    --to=wrglin@gmail.com \
    --cc=39484@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).