From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#14769: [PATCH] optimize `concat's literals Date: Wed, 19 Jun 2019 14:54:16 +0200 Message-ID: <43EF1EEA-BE3B-493A-9BDE-C8AE37B9696A@acm.org> References: <6BF130E1-F25B-4E1B-B55D-224F0CCEC133@acm.org> <87r27qwdrv.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_5BA07FE7-F615-46FE-9335-22E09B57C32E" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256181"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Lars Ingebrigtsen , Stefan Monnier , 14769@debbugs.gnu.org, shigeru.fukaya@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 19 14:55:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hda7O-0014UJ-3M for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2019 14:55:14 +0200 Original-Received: from localhost ([::1]:38064 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hda7N-000315-0Y for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Jun 2019 08:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33356) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hda7F-00030t-Sl for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 08:55:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hda7E-00087Y-WA for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 08:55:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60870) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hda7E-00086p-D3 for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 08:55:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hda7C-0002HF-Gw for bug-gnu-emacs@gnu.org; Wed, 19 Jun 2019 08:55:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Jun 2019 12:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14769 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14769-submit@debbugs.gnu.org id=B14769.15609488648685 (code B ref 14769); Wed, 19 Jun 2019 12:55:02 +0000 Original-Received: (at 14769) by debbugs.gnu.org; 19 Jun 2019 12:54:24 +0000 Original-Received: from localhost ([127.0.0.1]:46181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hda6Z-0002G1-U9 for submit@debbugs.gnu.org; Wed, 19 Jun 2019 08:54:24 -0400 Original-Received: from mail74c50.megamailservers.eu ([91.136.10.84]:56429 helo=mail92c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hda6X-0002Fr-47 for 14769@debbugs.gnu.org; Wed, 19 Jun 2019 08:54:22 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1560948859; bh=1fEVEH5h3bKMBCUDV6knjSagI/5XcfWP/mqkM6Gvznk=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=TdSo2ucphe9r8ZTmpcALCnrO+cEkXyLh+GvKs400DvrzlRVvjqWyVK8RAndIa69Vy jk1VUNQTNSK4gOE+L39ZfPacaZ7BnO7aRTJhdFgqA7J7gyNQDoBOJZrMus77zpaWUX GZWuNZR3MiW+LA8lW6EJ1kcGIeNiKntV/IXtMios= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.1.65] (c-e636e253.032-75-73746f71.bbcust.telenor.se [83.226.54.230]) (authenticated bits=0) by mail92c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id x5JCsGeB011435; Wed, 19 Jun 2019 12:54:18 +0000 In-Reply-To: <87r27qwdrv.fsf@gmail.com> X-Mailer: Apple Mail (2.3445.104.11) X-CTCH-RefID: str=0001.0A0B020D.5D0A307B.0010, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=LZQSFAXi c=1 sm=1 tr=0 a=M+GU/qJco4WXjv8D6jB2IA==:117 a=M+GU/qJco4WXjv8D6jB2IA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=pGLkceISAAAA:8 a=N54-gffFAAAA:8 a=XHONTn1MfpYIiTRvBwMA:9 a=QEXdDO2ut3YA:10 a=IUaKqlKYTyGjG5-Y8p0A:9 a=B2y7HmGcmWMA:10 a=6l0D2HzqY3Epnrm8mE3f:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160842 Archived-At: --Apple-Mail=_5BA07FE7-F615-46FE-9335-22E09B57C32E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 19 juni 2019 kl. 03.43 skrev Noam Postavsky : >=20 > Mattias Engdeg=C3=A5rd writes: >=20 >> + (dolist (arg (cdr form)) >=20 >> + (let ((val (eval arg))) >=20 >> + ;; Constant arg: concat with previous. >> + (setq accum (concat accum val))))) >=20 > Hmm, I think the OP's patch is careful not to concat in a loop like > this: it's O(n^2). I guess for most human written code n is small > enough that it doesn't matter, but I could imagine this slowing > compilation of a very big rx macro. Yes, I thought it wouldn't matter but you are right. Updated patch = attached. For that matter, ry performs this optimisation itself, but it's also = nice to have it in the compiler, since concat is frequently used to = split long string constants in elisp source. --Apple-Mail=_5BA07FE7-F615-46FE-9335-22E09B57C32E Content-Disposition: attachment; filename=0001-Merge-consecutive-constant-concat-args-bug-14769.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Merge-consecutive-constant-concat-args-bug-14769.patch" Content-Transfer-Encoding: quoted-printable =46rom=20d4c3bbce9472618b5e762a18af5ba1a2b1b79698=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Sun,=2016=20Jun=202019=2013:13:47=20+0200=0A= Subject:=20[PATCH]=20Merge=20consecutive=20constant=20`concat'=20args=20= (bug#14769)=0A=0ASuggested=20by=20Shigeru=20Fukaya=20= =0A=0A*=20lisp/emacs-lisp/byte-opt.el=20= (byte-optimize-concat):=20New.=0A(concat):=20Add=20byte-optimizer.=0A---=0A= =20lisp/emacs-lisp/byte-opt.el=20|=2029=20+++++++++++++++++++++++++++++=0A= =201=20file=20changed,=2029=20insertions(+)=0A=0Adiff=20--git=20= a/lisp/emacs-lisp/byte-opt.el=20b/lisp/emacs-lisp/byte-opt.el=0Aindex=20= b0aa407c8b..2e09601639=20100644=0A---=20a/lisp/emacs-lisp/byte-opt.el=0A= +++=20b/lisp/emacs-lisp/byte-opt.el=0A@@=20-850,6=20+850,33=20@@=20= byte-optimize-memq=0A=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20',list)))))=0A=20=20=20=20=20= (byte-optimize-predicate=20form)))=0A=20=0A+(defun=20= byte-optimize-concat=20(form)=0A+=20=20"Merge=20adjacent=20constant=20= arguments=20to=20`concat'."=0A+=20=20(let=20((args=20(cdr=20form))=0A+=20= =20=20=20=20=20=20=20(newargs=20nil))=0A+=20=20=20=20(while=20args=0A+=20= =20=20=20=20=20(let=20((strings=20nil)=0A+=20=20=20=20=20=20=20=20=20=20=20= =20val)=0A+=20=20=20=20=20=20=20=20(while=20(and=20args=20= (macroexp-const-p=20(car=20args))=0A+=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20(progn=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20(setq=20val=20(eval=20(car=20args)))=0A+=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(and=20(or=20= (stringp=20val)=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20(and=20(or=20(listp=20val)=20= (vectorp=20val))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(not=20(memq=20nil=0A= +=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= (mapcar=20#'characterp=20val))))))))=0A+=20=20=20=20=20=20=20=20=20=20= (push=20val=20strings)=0A+=20=20=20=20=20=20=20=20=20=20(setq=20args=20= (cdr=20args)))=0A+=20=20=20=20=20=20=20=20(when=20strings=0A+=20=20=20=20= =20=20=20=20=20=20(let=20((s=20(apply=20#'concat=20(nreverse=20= strings))))=0A+=20=20=20=20=20=20=20=20=20=20=20=20(when=20(not=20(zerop=20= (length=20s)))=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20(push=20s=20= newargs)))))=0A+=20=20=20=20=20=20(when=20args=0A+=20=20=20=20=20=20=20=20= (push=20(car=20args)=20newargs)=0A+=20=20=20=20=20=20=20=20(setq=20args=20= (cdr=20args))))=0A+=20=20=20=20(if=20(=3D=20(length=20newargs)=20(length=20= (cdr=20form)))=0A+=20=20=20=20=20=20=20=20form=20=20=20=20=20=20=20=20=20= =20;=20No=20improvement.=0A+=20=20=20=20=20=20(cons=20'concat=20= (nreverse=20newargs)))))=0A+=0A=20(put=20'identity=20'byte-optimizer=20= 'byte-optimize-identity)=0A=20(put=20'memq=20'byte-optimizer=20= 'byte-optimize-memq)=0A=20=0A@@=20-892,6=20+919,8=20@@=20= byte-optimize-memq=0A=20(put=20'car-safe=20'byte-optimizer=20= 'byte-optimize-predicate)=0A=20(put=20'cdr-safe=20'byte-optimizer=20= 'byte-optimize-predicate)=0A=20=0A+(put=20'concat=20'byte-optimizer=20= 'byte-optimize-concat)=0A+=0A=20;;=20I'm=20not=20convinced=20that=20this=20= is=20necessary.=20=20Doesn't=20the=20optimizer=20loop=0A=20;;=20take=20= care=20of=20this?=20-=20Jamie=0A=20;;=20I=20think=20this=20may=20some=20= times=20be=20necessary=20to=20reduce=20ie=20(quote=205)=20to=205,=0A--=20= =0A2.20.1=20(Apple=20Git-117)=0A=0A= --Apple-Mail=_5BA07FE7-F615-46FE-9335-22E09B57C32E--