From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#17172: 24.3.50; Timeouts when pasting from mouse Date: Tue, 15 Apr 2014 22:41:23 +0200 Message-ID: <43B05B9F-D0DA-47AC-B8FB-4A780FF3E095@swipnet.se> References: <87eh1fsved.fsf@linaro.org> <534CE79A.3030600@cs.ucla.edu> <534D0749.3060404@swipnet.se> <534D57EA.1000503@cs.ucla.edu> <534D9453.9040700@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (1.0) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1397594546 14567 80.91.229.3 (15 Apr 2014 20:42:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Apr 2014 20:42:26 +0000 (UTC) Cc: Alex =?UTF-8?Q?Benn=C3=A9e?= , "17172@debbugs.gnu.org" <17172@debbugs.gnu.org> To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 15 22:42:19 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WaABO-0002RG-23 for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Apr 2014 22:42:18 +0200 Original-Received: from localhost ([::1]:51662 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaABN-0007gb-K6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Apr 2014 16:42:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaABE-0007cX-KM for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:42:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WaAB8-00079c-Mi for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:42:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41022) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaAB8-00079W-KD for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WaAB8-0004r9-8T for bug-gnu-emacs@gnu.org; Tue, 15 Apr 2014 16:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Apr 2014 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17172 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17172-submit@debbugs.gnu.org id=B17172.139759450018623 (code B ref 17172); Tue, 15 Apr 2014 20:42:02 +0000 Original-Received: (at 17172) by debbugs.gnu.org; 15 Apr 2014 20:41:40 +0000 Original-Received: from localhost ([127.0.0.1]:49179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WaAAl-0004qG-8Z for submit@debbugs.gnu.org; Tue, 15 Apr 2014 16:41:40 -0400 Original-Received: from mailfe07.swip.net ([212.247.154.193]:52654 helo=swip.net) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WaAAg-0004po-Pd for 17172@debbugs.gnu.org; Tue, 15 Apr 2014 16:41:36 -0400 X-T2-Spam-Status: No, hits=0.8 required=5.0 tests=BAYES_50, MIME_QP_LONG_LINE Original-Received: from hosdjarv.se (account mj138573@tele2.se [46.59.42.57] verified) by mailfe07.swip.net (CommuniGate Pro SMTP 5.4.4) with ESMTPA id 492932269; Tue, 15 Apr 2014 22:41:25 +0200 In-Reply-To: <534D9453.9040700@cs.ucla.edu> X-Mailer: iPhone Mail (11D167) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88042 Archived-At: Hello.=20 > 15 apr 2014 kl. 22:19 skrev Paul Eggert : >=20 > Jan Dj=C3=A4rv wrote: >> That can't happen, all masks are initialized with FD_ZERO. >=20 > True, but after that they can be reused in some cases and it's not immedia= tely obvious that they are guaranteed to be properly reinitialized for every= call to xg_select. They are not reinitialized with FD_ZERO, but no garbage bits are ever set.=20= >=20 >> If we passed masks with garbage in them to pselect we would get EINVAL ba= ck. >=20 > Not if the garbage's 1 bits happen to correspond to open file descriptors.= But there are no garbage bits. >=20 >> In that case, process.c does not inspect the masks, so this change fixes n= othing. >=20 > Although it doesn't inspect the masks right away, in some cases it reuses a= mask later. The code is reasonably tricky here. Not so you can't follow it.=20 >=20 >> you just used it as a means to get untested code into the emacs-24 branch= >=20 > Hmm, well, that's a bit unfair as I did test it, but as you're sure the ch= ange doesn't fix any user-visible bugs I reverted it. It was not tested by the OP of this bug.=20 Jan D.=20=