From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38563: 27.0.50; Company popup renders with newlines (?) inheriting the bg properties of the character at next line's bol Date: Wed, 18 Dec 2019 22:37:49 +0200 Message-ID: <4397c5c2-e944-e684-82c4-e458826addc2@yandex.ru> References: <4c2a9d55-57d1-4c19-fe20-4ccf61d20d68@yandex.ru> <83o8weaiem.fsf@gnu.org> <4220b126-0511-d6ee-521d-d79f463ab6ee@yandex.ru> <8336dpaiee.fsf@gnu.org> <2203b03e-5558-1fe1-788a-4006602626f2@yandex.ru> <83h8248wio.fsf@gnu.org> <83wob071sd.fsf@gnu.org> <0e27fa9b-67ac-c4b4-176f-f98c151d9b19@yandex.ru> <83pngs6y1t.fsf@gnu.org> <83fthn729o.fsf@gnu.org> <60c8d23f-759a-9f10-d8ac-577f0c56ebe0@yandex.ru> <837e2w5kzm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="224559"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 38563@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 18 21:38:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ihg5H-000wEj-JW for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Dec 2019 21:38:15 +0100 Original-Received: from localhost ([::1]:60386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihg5F-0001RV-OE for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Dec 2019 15:38:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36107) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihg57-0001RD-MJ for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 15:38:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihg55-0002nY-Tc for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 15:38:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38017) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ihg54-0002lY-Ca for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 15:38:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ihg54-0001nI-8S for bug-gnu-emacs@gnu.org; Wed, 18 Dec 2019 15:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Dec 2019 20:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38563 X-GNU-PR-Package: emacs Original-Received: via spool by 38563-submit@debbugs.gnu.org id=B38563.15767014806888 (code B ref 38563); Wed, 18 Dec 2019 20:38:02 +0000 Original-Received: (at 38563) by debbugs.gnu.org; 18 Dec 2019 20:38:00 +0000 Original-Received: from localhost ([127.0.0.1]:43990 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihg52-0001n2-H3 for submit@debbugs.gnu.org; Wed, 18 Dec 2019 15:38:00 -0500 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:43682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ihg50-0001mp-1H for 38563@debbugs.gnu.org; Wed, 18 Dec 2019 15:37:58 -0500 Original-Received: by mail-wr1-f49.google.com with SMTP id d16so3705205wre.10 for <38563@debbugs.gnu.org>; Wed, 18 Dec 2019 12:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lGjXMTdDkSazHsbV0+j+BmnPbNfMxFYfauZUQ4bfxpA=; b=MG1h00suWXHrWVLTZ7pkIWy9duqYOl5TdMh1fp4MtH5vNcNaxzcmpD11Zz9HEzAiDT CJIULknAJQWrJosxwskmeOvDIKna2gQWvgphjeQJUkbbCZkON47Werl9OfJPPkfK4k0P t7sH0Cx+tfxVCvFwx9cQsDCS3Co/tYJmPO5AKUSEP8NeQVVyjA6rhFCZSTXtzr5f04wP XUrYkfHu0YmFjC21HjX0uUBJKBSHoD0iB5vX2ZVIwPD6pNtlpbzXfJ06sywrVNDGqzdY v+5wo3mGplvmVhU8FoGRn+ocrNh62evFr8DvEVJ5QF8k1OyfFOFhZAHWZ98YBUYnLbh0 20PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lGjXMTdDkSazHsbV0+j+BmnPbNfMxFYfauZUQ4bfxpA=; b=XEa2d++JZ/tz1M5RO8uY8JbAdQYzKtorgIPyon5g07YVMLWnKfOq/JMRXHO+zBq1dZ 817DA+xXwfILV1m/w6hBvEJP+2EwWO1EdxPTuRtmbIA5p6E5O/RxkoFJVEns0D1wC9U5 ebBND0Zb0bQuYxAOHROiDgadjCEyxYtSotcCl6Oe3gm3QUSgCtU4D8VsgSlgVMgn0e9b XKX/wKZaeZkqX1aqBUbGkcmNgEQ4Mr2Hp3LstrZNHlpAPcjLTID0cbFFUMhRRElUPj7B ua3lRSOaJYpNRwUFjqL+nqcSe7E6XYlxeHEFXEa4y6vbm8Sn8AtZFz6KuLvdUPu2z/E4 x6yQ== X-Gm-Message-State: APjAAAU11ITLD7Lr0mU4qoT14cg4V+cREVg5GAIR6BeNSxTLakPKJzIG J/c/0BCs1VstJXLkokRnLoC8IXRLZ+E= X-Google-Smtp-Source: APXvYqx6b7fnr8jfAEreFxM0cEVMKPJt6Q11vjqUi3gep6t8l5ceyN+Bp6pP2XDET6VoxBGke02EjA== X-Received: by 2002:adf:dcc2:: with SMTP id x2mr4676541wrm.24.1576701471820; Wed, 18 Dec 2019 12:37:51 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id o1sm3847108wrn.84.2019.12.18.12.37.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Dec 2019 12:37:50 -0800 (PST) In-Reply-To: <837e2w5kzm.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173531 Archived-At: On 16.12.2019 17:49, Eli Zaretskii wrote: > Unfortunately, in bug#38633 in turned out my "fix" was not really a > fix, but a stupid typo, which just happened to stop the problem in > this bug from happening, but caused serious breakage elsewhere. > > So I'm reopening this bug, and will have to think of a better > solution. In case you don't find it, how about we put 'default' as the 'face' property of the overlay? That seems to work. And with that we can stop appending 'default' to all 'face' values in the overlay string. WDYT? diff --git a/company.el b/company.el index 80398a3..399e9ea 100644 --- a/company.el +++ b/company.el @@ -2939,6 +2939,7 @@ Returns a negative number if the tooltip should be displayed above point." (overlay-put ov 'display disp) (overlay-put ov 'after-string disp) (overlay-put ov 'invisible t)) + (overlay-put ov 'face 'default) (overlay-put ov 'window (selected-window))))) (defun company-pseudo-tooltip-guard ()