From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#64531: [PATCH v2] Add new command vc-dir-copy-filename-as-kill Date: Sun, 20 Aug 2023 13:26:02 +0300 Message-ID: <43944ccb-8c21-5158-4bb5-31020a10eec8@yandex.ru> References: <87bkgmq1ra.fsf@ya.ru> <83jzvadabq.fsf@gnu.org> <87bkfhy7fr.fsf_-_@ya.ru> <83a5un1mn3.fsf@gnu.org> <21b04273-e7e5-cbe5-cd95-9484a89a4b64@yandex.ru> <838ra6xm9n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20207"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: ivan-p-sokolov@ya.ru, 64531@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 20 12:27:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXfeO-0004y8-HT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Aug 2023 12:27:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXfeA-0000ns-9j; Sun, 20 Aug 2023 06:27:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXfe8-0000nk-Rs for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 06:27:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXfe8-0008Ax-Jd for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 06:27:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXfeA-0007OU-3c for bug-gnu-emacs@gnu.org; Sun, 20 Aug 2023 06:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Aug 2023 10:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64531 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64531-submit@debbugs.gnu.org id=B64531.169252718028360 (code B ref 64531); Sun, 20 Aug 2023 10:27:02 +0000 Original-Received: (at 64531) by debbugs.gnu.org; 20 Aug 2023 10:26:20 +0000 Original-Received: from localhost ([127.0.0.1]:53148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXfdT-0007NM-Ry for submit@debbugs.gnu.org; Sun, 20 Aug 2023 06:26:20 -0400 Original-Received: from forward103b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:d103]:39906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXfdR-0007N7-2Z for 64531@debbugs.gnu.org; Sun, 20 Aug 2023 06:26:18 -0400 Original-Received: from mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net [IPv6:2a02:6b8:c14:6e01:0:640:627f:0]) by forward103b.mail.yandex.net (Yandex) with ESMTP id 3B31960042; Sun, 20 Aug 2023 13:26:09 +0300 (MSK) Original-Received: by mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id 6QhH8lTDamI0-pztMNeNM; Sun, 20 Aug 2023 13:26:08 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1692527168; bh=JRu64OZzocL+/o6a6dMgFnk98ITNI52EDMxJHbjJRlo=; h=In-Reply-To:From:Subject:Message-ID:Cc:References:Date:To; b=doF8qFIjNHpOPQvaj7THAPFxhkn1yNAe2wLcQvsiHez7thPVjDyvZrCxsMXwFT3Ab bPKbcBpYzZJOSDqjpKe5ih5gBVnXvyFstyl2Q2SvUMU34m/CGlwSJYHTZmuI5uEiRv zhU1t8pmIGRB62lGCfW8ulHWrhuwXu09wpE/cW4s= Authentication-Results: mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net; dkim=pass header.i=@yandex.ru Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id BB2D027C0054; Sun, 20 Aug 2023 06:26:06 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 20 Aug 2023 06:26:06 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddujedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegughhuthhovheshigrnhguvgigrdhruheqnecuggftrfgrth htvghrnheptdffgeegkeelteevtdekleethfeftdduvdegkedtkedujefhfedtveeftdff udevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hguhhtohhvodhmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqddufeeffeelleeh hedvqddvleegjeejjeejiedqughguhhtohhvpeephigrnhguvgigrdhruhesfhgrshhtmh grihhlrdgtohhm X-ME-Proxy: Feedback-ID: ib1d9465d:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Aug 2023 06:26:05 -0400 (EDT) Content-Language: en-US In-Reply-To: <838ra6xm9n.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267980 Archived-At: On 20/08/2023 09:26, Eli Zaretskii wrote: >> Date: Sun, 20 Aug 2023 02:33:59 +0300 >> Cc: 64531@debbugs.gnu.org >> From: Dmitry Gutov >> >> The difference from dired-copy-filename-as-kill in handing of the prefix >> argument looks unfortunate (as a principle), but I'd rather leave it for >> you to judge. Perhaps changing the latter command's interface would be a >> better choice; I'm not sure why it works that way. > > What difference is that? I must be missing something, since it sounds > like both commands use the argument to select absolute or relative > file names? One of them mandates M-0 for that effect. >> Implementation difference: instead of going through (format "%S"), this >> one uses shell-quote-argument. Is that good enough for Windows systems? > > It depends on how the result will be used. But maybe we should do the > same as dired-copy-filename-as-kill, just for consistency of the UX? Maybe. I imagine it might be used in a shell, but indeed there are different options. >> And one more difference which we might want to see fixed: >> >> (When there's a single file, no quoting is done.) >> >> It seems like, at least, in some usage scenarios users would prefer to >> have copied filename not quoted. E.g. for subsequent use with find-file >> or... something similar. I don't really use this command all that much, >> so maybe I'm mistaken here, though. > > There will always be cases when quoting gets in the way, but hopefully > they are rare. The important thing, IMO, is that quoting is useful > for many/most uses of the file names in VC commands. Is it? When using 'M-!'? Maybe. I think consistency between 'w' commands is somewhat important, though.