From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74467: 31.0.50; org-protocol emacsclient.desktop change is not fully functional Date: Sun, 05 Jan 2025 20:13:09 +0200 Message-ID: <43736.6341053107$1736100863@news.gmane.org> References: <86seriksak.fsf@gnu.org> <87ed27cthy.fsf@localhost> <86cyhrpfbf.fsf@gnu.org> <864j2ot4w1.fsf@gnu.org> <86r05id8f5.fsf@gnu.org> <86o70lahmt.fsf@gnu.org> <87sepxprl1.fsf@localhost> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28775"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 74467@debbugs.gnu.org, Eli Zaretskii , binarin@binarin.info To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 05 19:14:16 2025 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tUV8h-0007Nw-Tk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Jan 2025 19:14:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tUV8W-0002OR-Eb; Sun, 05 Jan 2025 13:14:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tUV8U-0002OG-Ee for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 13:14:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tUV8U-0002I9-6K for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 13:14:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=2MBJIssa188tVdvCpw5VbaoLLJkK34frpv6wQsc3a/0=; b=ZgPO52XsndFik11U8qu/1QDHfyQkSA1jo0JsTLlxrjWUKKbg8EyKBKexhoevvsY/+gxuLBCS4xpw547vBa04mNlpzm8nKmmfmRA0cuYO83Z84GxaSB/hUffYEH+WbDTLhPWuPMQuQMoVdtubA/Nou2UUzG+uacZgd/UCjvIN8EoyFcMeVywFHVp53anmm+Gal5+AlPDSToxK8/9ZBf/EoKOT9lJVvH6pBmn+OI7z1ZABYFeC+MofKHoaNdThzdDwTZHekD6EatcwHs0eCiGs6z2QXFng11zaO4iAVWdThe9DahWLgtitk9PN2Eneagc0PRfgKZihZgF1QqMwG9lAJg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tUV8U-0000uG-0b for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2025 13:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jan 2025 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74467 X-GNU-PR-Package: emacs Original-Received: via spool by 74467-submit@debbugs.gnu.org id=B74467.17361008023405 (code B ref 74467); Sun, 05 Jan 2025 18:14:01 +0000 Original-Received: (at 74467) by debbugs.gnu.org; 5 Jan 2025 18:13:22 +0000 Original-Received: from localhost ([127.0.0.1]:35124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tUV7q-0000sr-9d for submit@debbugs.gnu.org; Sun, 05 Jan 2025 13:13:22 -0500 Original-Received: from thaodan.de ([2a03:4000:4f:f15::1]:34672) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1tUV7n-0000sV-GU for 74467@debbugs.gnu.org; Sun, 05 Jan 2025 13:13:20 -0500 Original-Received: from odin (dsl-trebng12-50dc7b-49.dhcp.inet.fi [80.220.123.49]) by thaodan.de (Postfix) with ESMTPSA id 3CD31D00059; Sun, 5 Jan 2025 20:13:11 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1736100791; bh=lXW6xIrFj9hY6K/rztxjW//iFSJLNBTm9FT4jVm/8y8=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=l14KTWHmOiXra9RSbU/m4580V5cpu61rfklDHOFDeKtniM1hHvSGrdsXyM1Modedc YhLeC1WvS2B1KASb16DZBhKDCqUrT248c9D4jcoOrG1fkV8jWZjEPSDU7JxaZyYAzh pxZdtJH/HaFTLwN8GJRpxt6j/xbmf8PdYDJdlqWFJWas9ouk8gKxYv6WI2nuuOcWgO VZqdwjbmABp8xmsfeDAOdoT89mE0LCIS6jmH7iPKctGkfldxVuoUnpZUpoHYr2VJPr eaoglwG9GQHB1Rj7R5vk+TCA3q2t5TWCLoWbOdeFG9t5BLpYw2tUgKR38pEs6+n5gI bKdA0G/M4ndVVcn3ldHu3AoHwTqM0069AHLKNt4n08IYTq23SRbutgpNnP8XBCgcuK 3+FRr5HnX/+eaEhxgT4q4i0nsyJ13hrhXwVGQXIFJHNV4LFtpRBqdcIGu5QrmwBKdS suXRb4bozP6DeaE10YFX5eS5oZy585mdAkO2hQuHMdBToTOjTMJf1LxMhyVZcTm5mw Fj3ZY2TbVx9dJcmqByi75+kUdmDZPxbMKtxYKYwyXyxNjXJuf42N2C2VD0zLM0JUNU M008BovPcheU0EpdHhQDtF9P0Ck/2RetZ+gwT7HCnm69xG9S8lVhjFczx9boUlvcGz GLG+5lPF9hpTxbDcsRsmfmwE= In-Reply-To: <87sepxprl1.fsf@localhost> (Ihor Radchenko's message of "Sun, 05 Jan 2025 08:55:54 +0000") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:298582 Archived-At: Ihor Radchenko writes: > Eli Zaretskii writes: > >> ... Ihor >> seemed to say that if this can be supported, there could be an >> alternative patch for fixing this issue, and I'd like to see that >> alternative patch to decide which one is simpler and/or more elegant. > > See the attached. > If Emacs can handle file URIs, we can simply use %U field code. > > diff --git a/etc/emacsclient.desktop b/etc/emacsclient.desktop > index 4395d3b02bc..c339ac93687 100644 > --- a/etc/emacsclient.desktop > +++ b/etc/emacsclient.desktop > @@ -3,7 +3,7 @@ Name=Emacs (Client) > GenericName=Text Editor > Comment=Edit text > MimeType=text/english;text/plain;text/x-makefile;text/x-c++hdr;text/x-c++src;text/x-chdr;text/x-csrc;text/x-java;text/x-moc;text/x-pascal;text/x-tcl;text/x-tex;application/x-shellscript;text/x-c;text/x-c++;x-scheme-handler/org-protocol; > -Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %F > +Exec=sh -c "if [ -n \\"\\$*\\" ]; then exec emacsclient --alternate-editor= --display=\\"\\$DISPLAY\\" \\"\\$@\\"; else exec emacsclient --alternate-editor= --create-frame; fi" sh %U Do we need the shell code here? if DISPLAY is defined emacsclient could shurely forward it to Emacs. Shellcode is part of the issue.