From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#63648: 29.0.90; project.el: with switch-use-entire-map, switch-project errors on non-project commands Date: Mon, 18 Sep 2023 14:00:03 +0300 Message-ID: <4367c45c-95b3-6a29-4ba3-068a3c748452@gutov.dev> References: <86bki9y68h.fsf@mail.linkov.net> <86cz2f7bvo.fsf@mail.linkov.net> <86353axu48.fsf@mail.linkov.net> <87o7jfi00b.fsf@catern.com> <86msyhwrrg.fsf@mail.linkov.net> <86y1hs4kkg.fsf@mail.linkov.net> <86h6of66o3.fsf@mail.linkov.net> <86wmxb2qvh.fsf@mail.linkov.net> <8634zyjt0k.fsf@mail.linkov.net> <8d1fb7ac-5c82-0ec2-8ae2-d09c131ec165@gutov.dev> <86edj6hyem.fsf@mail.linkov.net> <8634zitwoy.fsf@mail.linkov.net> <50d46d30-a796-b855-0d4c-690d6cb3d15b@gutov.dev> <86il88x9cy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22975"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Spencer Baugh , 63648@debbugs.gnu.org, sbaugh@catern.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 13:01:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiC0c-0005od-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 13:01:43 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiC0G-0001Qr-Oj; Mon, 18 Sep 2023 07:01:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiBzq-0001Jx-KI for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 07:00:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiBzq-0001oc-CF for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 07:00:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiBzy-0008Jk-H1 for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 07:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 11:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63648 X-GNU-PR-Package: emacs Original-Received: via spool by 63648-submit@debbugs.gnu.org id=B63648.169503482331890 (code B ref 63648); Mon, 18 Sep 2023 11:01:02 +0000 Original-Received: (at 63648) by debbugs.gnu.org; 18 Sep 2023 11:00:23 +0000 Original-Received: from localhost ([127.0.0.1]:52190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiBzK-0008IH-QQ for submit@debbugs.gnu.org; Mon, 18 Sep 2023 07:00:23 -0400 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:46451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiBzI-0008Hz-ER for 63648@debbugs.gnu.org; Mon, 18 Sep 2023 07:00:21 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 46BC13200922; Mon, 18 Sep 2023 07:00:06 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 18 Sep 2023 07:00:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1695034805; x=1695121205; bh=b2tYBfic7sKKDZZv5KMBZkD3Rbqv+Odgkhc UgshrLug=; b=koCwf9JnxuNT8NViOlQHFzZ4ysPrvQp+4Pbvhif1lXI07eko78b aGkpxOblIW71W87Bsum/l7ef0Ec/4oebVVJCHQE3ta7yZ06RuE8s91WZAPGar22R EXDc7+44nUC52rK2lZPcPHJksxbJGi7lWD3sx/61qC6QmZSPFhIeZRvXSn6RiUO7 i+fkzEuiBtvNEh8VU6G2tSx7wy4Odo6N9iE35e2p2qYKeiv5oxIrQ6DH3RvkJRoO 8C7Psg/A0s2si6CaKkTMtAQqPgMsI+V8ZvdxxPiDiUZcVYaxOs9fQ1asR5EyMC4e 0k4se1gYiM+QlXxR90FAlMtJbU5bNK79VCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695034805; x=1695121205; bh=b2tYBfic7sKKDZZv5KMBZkD3Rbqv+Odgkhc UgshrLug=; b=c8MOziG7lyuA40mxQ4RfSz4hqkT+6uS7sKKirNQwoJFc154UeMC Eho18RnyhMC+Q+0uQ05ciJt49rePZTdSakadRS1F4KcojU0ZjrM7UgrPyXjJ80cM 11tvBI75mTeVSaxb+Bc3sTciJ2xLLsMc5a1NVSkcFv2UhZdJ6I4wYnvQyMb1uFiT Ve11HVTmiblH3DTIRdhn/mj0Y3cy/9XBbH1el8jjGKzrbHQ0Jam+meNhPtjo/cBi Y1V8fgd0ZKK4Pei0Lc3Kg/aaIPKeBLWyy/mNpIcTqZPiZ5pxp6SHeBJb0xy9+0Zl C2HRaAf3aTvy48nKvvuWh3WKCSbA6BM23Eg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudejkedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Sep 2023 07:00:04 -0400 (EDT) Content-Language: en-US In-Reply-To: <86il88x9cy.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270769 Archived-At: On 18/09/2023 09:51, Juri Linkov wrote: >>> 'C-x p p C-x v L' to see a vc log in another project, and >>> 'C-x p p C-x v d' to open vc-dir, etc. >> All right, so we also want to support non-project commands. And you wanted >> to use a common approach for both. >> >> What if we handle them differently, though? For "project" commands (those >> that internally call project-current) we can set one variable, and for the >> rest -- alter default-directory. Then restore the previous value in >> post-command. >> >> The detection of "project commands" could work like this: >> >> - Is it in one of the special maps? E.g. in project-prefix-map. Or maybe >> it's in project-switch-commands. >> - Does the function name start with 'project-'? >> - Finally, for user-defined commands we could also introduce a property >> 'project-command-p', although the distinction between using >> project-current-directory-override vs default-directory will not be >> important for every such command, so maybe being this thorough is not too >> important. > Sorry, I don't understand how 'C-x p p' could read the user's mind > whether the user afterwards will type a key for a project command > or a non-project command? And depending on user's intention will > either set project-current-directory-override or default-directory. Ah, I forgot that in the general case we don't read the sequence, find the command and do the thing. We leave the event loop up to Emacs. What about pre-command-hook? this-command will already be set by then.