From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#34657: 26.1; Some erc hook names lack the expected suffix Date: Tue, 26 Feb 2019 12:54:57 +1300 Message-ID: <42f6bffbb0e6eb71f87c375a31948970@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138369"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Orcon Webmail To: 34657@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 26 00:56:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyQ6W-000ZsM-Kc for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Feb 2019 00:56:12 +0100 Original-Received: from localhost ([127.0.0.1]:45779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyQ6V-0005K3-Jo for geb-bug-gnu-emacs@m.gmane.org; Mon, 25 Feb 2019 18:56:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyQ6P-0005Jl-4r for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:56:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyQ6O-0004kq-0K for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:56:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38388) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyQ6M-0004jh-VI for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:56:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gyQ6M-0004Z3-CE for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Feb 2019 23:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34657 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155113891917491 (code B ref -1); Mon, 25 Feb 2019 23:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Feb 2019 23:55:19 +0000 Original-Received: from localhost ([127.0.0.1]:51932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyQ5e-0004Y3-VJ for submit@debbugs.gnu.org; Mon, 25 Feb 2019 18:55:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gyQ5b-0004Xm-8Z for submit@debbugs.gnu.org; Mon, 25 Feb 2019 18:55:17 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:39538) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gyQ5V-0004If-Tq for submit@debbugs.gnu.org; Mon, 25 Feb 2019 18:55:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gyQ5U-0005CK-SB for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:55:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gyQ5T-0004F6-TI for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:55:08 -0500 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:41014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gyQ5T-0004B4-H3 for bug-gnu-emacs@gnu.org; Mon, 25 Feb 2019 18:55:07 -0500 Original-Received: from [10.253.37.70] (port=52138 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.86_2) (envelope-from ) id 1gyQ5J-0003So-Gp for bug-gnu-emacs@gnu.org; Tue, 26 Feb 2019 12:54:58 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Tue, 26 Feb 2019 12:54:57 +1300 X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155783 Archived-At: `erc-before-connect' and `erc-after-connect' are abnormal hooks, so I think they should each have the suffix "-functions" for consistency, and so that they are easier to discover. Is is ok to rename them and defvaralias the old names? All other erc hooks have the -hook or -functions suffix, so far as I can see. For reference: (defcustom erc-before-connect nil "Hook called before connecting to a server. This hook gets executed before `erc' actually invokes `erc-mode' with your input data. The functions in here get called with three parameters, SERVER, PORT and NICK." :group 'erc-hooks :type 'hook) (defcustom erc-after-connect nil "Hook called after connecting to a server. This hook gets executed when an end of MOTD has been received. All functions in here get called with the parameters SERVER and NICK." :group 'erc-hooks :type 'hook) In GNU Emacs 27.0.50 (build 2, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars) of 2019-01-07 built on hal Repository revision: b0b483d714e87ee0a4572f9c541514a1ac1a8226 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.11906000 System Description: Ubuntu 18.04.2 LTS Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Loading erc...done uncompressing erc.el.gz...done Mark set Configured using: 'configure --prefix=/home/phil/emacs/head/usr/local --with-x-toolkit=lucid --without-sound' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK DBUS GSETTINGS GLIB NOTIFY INOTIFY GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM THREADS LCMS2 GMP Important settings: value of $LANG: en_NZ.UTF-8 locale-coding-system: utf-8-unix Major mode: Emacs-Lisp Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree help-mode easymenu jka-compr find-func erc-goodies erc erc-backend erc-compat format-spec auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib thingatpt pp erc-loaddefs dired dired-loaddefs advice elec-pair mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 119750 7960) (symbols 48 22664 1) (strings 32 36457 2107) (string-bytes 1 986101) (vectors 16 18682) (vector-slots 8 549648 11634) (floats 8 51 66) (intervals 56 588 50) (buffers 992 15))