unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 18009@debbugs.gnu.org
Subject: bug#18009: 24.4.50; Add hooks for `rename-file' and `delete-file'
Date: Sat, 19 Jul 2014 09:15:23 -0700 (PDT)	[thread overview]
Message-ID: <42eb878e-b5f3-4fbe-a5c6-95eacf5f038e@default> (raw)
In-Reply-To: <jwv38dy13lh.fsf-monnier+emacsbugs@gnu.org>

> > Please add a hook for each of these basic operations.  It is not
> > unusual to want to be able to carry out some action associated with
> > (successfully) renaming or deleting a file.  The hooks would be run
> > at the end of the operation, and only upon success.
> 
> It's not unreasonable, but these are rather low-level operations, I'm
> not sure I want to run hooks from them.

I'm curious what difference that makes.  I suppose you're thinking that
if a hook does something awful then it could affect things widely.  Is
that it?

I guess I don't have a good counter argument, if so.  On the other
hand, the same thing would happen if someone advised the function.

Plus, there are hooks and there are hooks.  Some hooks have more
potential for wreaking havoc than others.  We have not created hooks
only for contexts that are benign or well isolated.  We have hooks
that, if abused, can lead to data corruption or loss.  I don't really
see why these hooks would be so different.

> > One use case: Bookmark+ autofile bookmarks have the same name as their
> > files.  (There can be multiple bookmarks with the same name,
> > corresponding to files with the same name in different directories.)
> > With a hook it would be trivial to automatically rename or delete the
> > associated bookmark.
> 
> Of course you can use an `advice' in the mean time, but maybe a better
> long-term answer is the file-notification API so that your code would
> know about renames not only when they're performed from the same Emacs
> session but also from any other process.

I will take a look at that; I'm not familiar with it.  The doc speaks
of a few restrictions and caveats, but it does sound worth trying.

Why did you mention "long-term" here? I wonder if I'm missing something.

That might well be something interesting for the use case I mentioned.
But I would still like to see the hooks added.  It is not the same
thing to want Emacs to do something when IT renames or deletes a file,
as opposed to hearing back from the operating system (when, exactly?)
that something was changed.  Associating an action with the act of
renaming or deleting makes sense to me, a priori.





  reply	other threads:[~2014-07-19 16:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-12 22:31 bug#18009: 24.4.50; Add hooks for `rename-file' and `delete-file' Drew Adams
2014-07-12 22:39 ` Drew Adams
2014-07-13  1:35   ` Glenn Morris
2014-07-13  2:32     ` Drew Adams
2014-07-13  8:13 ` Andreas Schwab
2014-07-13  9:21   ` Michael Albinus
2014-07-13  9:26     ` Andreas Schwab
2014-07-13  9:32       ` Michael Albinus
2014-07-13  9:38         ` Andreas Schwab
2014-07-13  9:46           ` Michael Albinus
2014-07-13 10:55             ` Andreas Schwab
2014-07-19  2:34 ` Stefan Monnier
2014-07-19 16:15   ` Drew Adams [this message]
2022-02-20 13:07   ` Lars Ingebrigtsen
2022-02-20 21:08     ` bug#18009: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42eb878e-b5f3-4fbe-a5c6-95eacf5f038e@default \
    --to=drew.adams@oracle.com \
    --cc=18009@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).