From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 27 Oct 2022 11:44:09 +0300 Message-ID: <42bb91a0-60ff-2e51-dcdc-c1e1f80e31ec@yandex.ru> References: <8735budxiz.fsf@gmail.com> <83a662dvgo.fsf@gnu.org> <871qqvj6qb.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35402"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: 58447@debbugs.gnu.org To: Augusto Stoffel , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 27 10:46:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1onyWg-00093z-SJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Oct 2022 10:46:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1onyVc-0000mD-Bq; Thu, 27 Oct 2022 04:45:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1onyVa-0000Vp-6y for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 04:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1onyVZ-0008Q5-U2 for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 04:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1onyVZ-0001aV-Ju for bug-gnu-emacs@gnu.org; Thu, 27 Oct 2022 04:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Oct 2022 08:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.16668602586038 (code B ref 58447); Thu, 27 Oct 2022 08:45:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 27 Oct 2022 08:44:18 +0000 Original-Received: from localhost ([127.0.0.1]:56142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onyUs-0001ZK-Eh for submit@debbugs.gnu.org; Thu, 27 Oct 2022 04:44:18 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:39550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1onyUq-0001Z6-Rg for 58447@debbugs.gnu.org; Thu, 27 Oct 2022 04:44:17 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id o4so985162wrq.6 for <58447@debbugs.gnu.org>; Thu, 27 Oct 2022 01:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=K9XHjCOib2HhTyh9bQ9L4MCl+n3sKobi9c8cHp3Go1M=; b=VA8n603dm+ssUDisyHevtbAI1q9X5mKB8k3ssjDYYb0bQDW2nEP8IlQR81WdE5UyIP G9OL+wcGkmEuut5Go/O4oqytViMmkHh9spbyPZ9rbtjuyaJC3s7EqiyJus6OJGrk29Od BVupVHTQn35sILjzonV73z65/lG/VARtHLfCYwSPx8tu2fuiJY1QUSpPZn7n8OyBxMs9 h43e8W0zda8AM/NLpCPhsraz8QmESzh5xYheRncWZMZYxdjBytd1B1CHDKITaOuPjL7X f6FCtXqVpa8ZTfp1tpoyEUuEMzx2/GKelHGE35xBt6hn+/CYSXb110dJCkPblYg43ZTz qDOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=K9XHjCOib2HhTyh9bQ9L4MCl+n3sKobi9c8cHp3Go1M=; b=nMkGqMVpazKqMNbYPkRYj1/WB+RK7sT8H5ScVpD+qa3tJfjLvhwkDK1TRvsrjZy40l E/aVigyoWuXQPSVFblv29NDpzswogaeWwjQBx6bBnafj4M26f29JgJ3Wh0YVbipKrs23 mDSYLoJ3fh/JqXnJAmy4q48Lbzge8sIo2fIHw2acLu4T2lcq1JjxbmJeOOogCKs8cGVE aIvZLngRW2JUzirt6TzyNVjBE8BdkxBBcATiFGU/wTGJXDG4cp3ZnDBbmpdCJGU2I1in e+nPl9HPqA1TheKxfxaFAFCqt2mvprctKUr5t0vw1klEY0BGMcuzuhcwUZ0TtpLRDHdB Y9Ow== X-Gm-Message-State: ACrzQf2gLEy1N1YsL/gjDb++1LK7EgZn4Xb12cJAlcPF/1peMy0peCF7 /xmqYOKewhDEDwhmChG8Xrk= X-Google-Smtp-Source: AMsMyM4sYLSsvDdSLRGnRaUkkcFy21m9ZCiG1UjanIjZphLE+IritWiZ37DeLveO35LPnSJ5nhibWQ== X-Received: by 2002:a5d:654d:0:b0:235:197d:72d1 with SMTP id z13-20020a5d654d000000b00235197d72d1mr25687688wrv.680.1666860250921; Thu, 27 Oct 2022 01:44:10 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z7-20020a05600c0a0700b003a682354f63sm4634437wmp.11.2022.10.27.01.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 01:44:10 -0700 (PDT) Content-Language: en-US In-Reply-To: <871qqvj6qb.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246280 Archived-At: On 26.10.2022 12:04, Augusto Stoffel wrote: > I'm copying Dmitry. Hi! > On Tue, 11 Oct 2022 at 22:13, Eli Zaretskii wrote: > >>> From: Augusto Stoffel >>> Date: Tue, 11 Oct 2022 20:29:24 +0200 >>> >>> `project-find-file' and related commands share their history with more >>> general commands like `find-file', so they should add the absolute file >>> name to history. Currently, file names relative to the project root are >>> added. The attached patch fixes this. >> Shouldn't project.el have its separate history of file names, > I'm not sure that's useful, but then the history items should be > absolute file names anyway. > >> perhaps even a project-specific history? > This might make sense. I like both of these ideas, except I'm not sure how to implement the project-specific part better. I suppose we won't be passing the history var to completing-read anymore?