From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode Date: Wed, 12 Feb 2020 01:42:22 +0200 Message-ID: <42a997dd-0667-da4d-7605-aa8267018869@yandex.ru> References: <83a762k9p2.fsf@gnu.org> <71c2898c-aca7-ea92-e7d2-f4fd122b566d@gmail.com> <83ftfthsqs.fsf@gnu.org> <83d0awj42l.fsf@gnu.org> <83a760j23r.fsf@gnu.org> <83zhdqbg6v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="50296"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 39379@debbugs.gnu.org, wyuenho@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 12 00:43:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j1fBQ-000Cza-W2 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Feb 2020 00:43:12 +0100 Original-Received: from localhost ([::1]:58438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1fBQ-0000AR-1I for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Feb 2020 18:43:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46473) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j1fBH-00007s-KR for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 18:43:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j1fBG-00015G-Kt for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 18:43:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51751) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j1fBG-00015C-HO for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 18:43:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j1fBG-0003yS-FQ for bug-gnu-emacs@gnu.org; Tue, 11 Feb 2020 18:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Feb 2020 23:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39379 X-GNU-PR-Package: emacs Original-Received: via spool by 39379-submit@debbugs.gnu.org id=B39379.158146455215239 (code B ref 39379); Tue, 11 Feb 2020 23:43:02 +0000 Original-Received: (at 39379) by debbugs.gnu.org; 11 Feb 2020 23:42:32 +0000 Original-Received: from localhost ([127.0.0.1]:57724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1fAl-0003xj-Tu for submit@debbugs.gnu.org; Tue, 11 Feb 2020 18:42:32 -0500 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:50735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j1fAk-0003xW-S6 for 39379@debbugs.gnu.org; Tue, 11 Feb 2020 18:42:31 -0500 Original-Received: by mail-wm1-f44.google.com with SMTP id a5so26885wmb.0 for <39379@debbugs.gnu.org>; Tue, 11 Feb 2020 15:42:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=D0t1ZCEHM92V8NGZMaeoXxNGWxfO5viN1ZaKPaJz5rc=; b=XPEMPEsZ/17Cme54mjFyX5xrG2BQWmdKMEfvdPHaUG3pXBs91CVxY6UxNjDBa6SQFs 20ZqVgT0D61ItqfE8cfukyY0emG6NwbBCtM2RhTg4ModIEpEBrJZcjmjsPieB6OYZxui ycU+q0eJpLUx9sQPNNCZCDd26i6719Zjy7zaIRNqhZyaHlzTFUXMZZGW+QpFQdXdnbtf WbpL+bZhkhDlKR9OF6k5MKbxBCNRM1E7zlyue3QhaPsfheww1X32sbeVQQYaMJ58a5YT tlFU6rTuf1Jnpe0Ts/kZlf7g1W7WX3A5zbH+lWxNIHwGIAgxjOukINe2DkwCftjHXUai 3Bxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=D0t1ZCEHM92V8NGZMaeoXxNGWxfO5viN1ZaKPaJz5rc=; b=jXyejT97+g5DYgWmOU+Cotym9Iltng3+ALB3GqqDiNxMrEVPYDaGHtWtohj+MJ6Vxe ktbTZygubecl7tuKn/9/Bb6V8k1FuYl4sMPBuQj/XRvsGy0/KiEvABTXrehjj10OPa0a ZVzShOwzDMnyG06hSkj73IzTFiPvEwj1Zl+Mna7kAuRfFfSUxsHscyjmVBdVI7JJrbI+ cLXxJFmaiaTb91N3BQikN98L2cI1T8OXIEQ7NJx5NkpdPKIm/cOULBxg1zoDFB4n0oWL MHbWsXMK3cTCp1LHsu41xHeeXFQwISsRDxQk0sTuFVwBDbiSPp+1HNTrrEPe3mAVs5nC q6rw== X-Gm-Message-State: APjAAAWK8I1R4t/RnQvMSg1fNIA85zyfxDnwnf8rzvhzdaf7i8WHu6nR 8b/NUPT7ItL4nJ/dV0p2POSm8JVBPrc= X-Google-Smtp-Source: APXvYqxtPuvPw3Xx9GIxMj9Rxk263g3Jh5fFCYMiS7mjSw6wzL2W7LuhUkNzRmmuDl03dpxajDjb9A== X-Received: by 2002:a05:600c:2190:: with SMTP id e16mr8451458wme.84.1581464544780; Tue, 11 Feb 2020 15:42:24 -0800 (PST) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id m9sm7160423wrx.55.2020.02.11.15.42.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Feb 2020 15:42:24 -0800 (PST) In-Reply-To: <83zhdqbg6v.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175962 Archived-At: On 10.02.2020 17:44, Eli Zaretskii wrote: > So now, after thinking about this for some time, I think I want to > change my mind and ask why do we need to use an overlay with > after-string in ido.el? Re-reading related discussions, it seems the > answer is "so that the temporary display of messages is not at the end > of the minibuffer, where it could be invisible due to > resize-mini-windows being nil or restrictions imposed by ido.el via > ido-max-window-height". Is that the correct conclusion? If so, then > I think we can solve that problem without overlays. See the proposed > patch below, which basically reverts ido.el to its previous shape, and > uses a special text property to instruct set-minibuffer-message where > to put the overlay (defaulting to EOB). The patch more or less works, with the exception of the case where POS is EOB (e.g. when the sole completion is fully typed out). But that should be fixable as well. The reason I used after-string, though, is that icomplete-mode does that. And either it should have the same problems, or ido creates some circumstances where the problems show up. The former seems to be the case, though. Like, if I set max-mini-window-height to 1, then icomplete-mode also exhibits bug#39433. And while there is no xxx-vertical-mode for icomplete-mode, we would probably want one to be written someday. Sounds like when that happens, icomplete-vertical-mode would trigger this same bug as well unless we fix it in the display engine or find some other general way to avoid it.