unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39379@debbugs.gnu.org, wyuenho@gmail.com
Subject: bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode
Date: Wed, 12 Feb 2020 01:42:22 +0200	[thread overview]
Message-ID: <42a997dd-0667-da4d-7605-aa8267018869@yandex.ru> (raw)
In-Reply-To: <83zhdqbg6v.fsf@gnu.org>

On 10.02.2020 17:44, Eli Zaretskii wrote:
> So now, after thinking about this for some time, I think I want to
> change my mind and ask why do we need to use an overlay with
> after-string in ido.el?  Re-reading related discussions, it seems the
> answer is "so that the temporary display of messages is not at the end
> of the minibuffer, where it could be invisible due to
> resize-mini-windows being nil or restrictions imposed by ido.el via
> ido-max-window-height".  Is that the correct conclusion?  If so, then
> I think we can solve that problem without overlays.  See the proposed
> patch below, which basically reverts ido.el to its previous shape, and
> uses a special text property to instruct set-minibuffer-message where
> to put the overlay (defaulting to EOB).

The patch more or less works, with the exception of the case where POS 
is EOB (e.g. when the sole completion is fully typed out). But that 
should be fixable as well.

The reason I used after-string, though, is that icomplete-mode does 
that. And either it should have the same problems, or ido creates some 
circumstances where the problems show up.

The former seems to be the case, though. Like, if I set 
max-mini-window-height to 1, then icomplete-mode also exhibits bug#39433.

And while there is no xxx-vertical-mode for icomplete-mode, we would 
probably want one to be written someday. Sounds like when that happens, 
icomplete-vertical-mode would trigger this same bug as well unless we 
fix it in the display engine or find some other general way to avoid it.





  reply	other threads:[~2020-02-11 23:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 23:53 bug#39379: 27.0.60; Fix for #38457 broke ido-vertical-mode Jimmy Yuen Ho Wong
2020-02-01  8:12 ` Eli Zaretskii
2020-02-02 13:58   ` Jimmy Yuen Ho Wong
2020-02-02 16:13     ` Eli Zaretskii
2020-02-02 17:23       ` Eli Zaretskii
2020-02-02 18:06         ` Eli Zaretskii
2020-02-02 18:38           ` Eli Zaretskii
2020-02-02 21:33             ` Jimmy Yuen Ho Wong
2020-02-03  3:21               ` Eli Zaretskii
2020-02-03 13:19               ` Dmitry Gutov
2020-02-03 15:40                 ` Eli Zaretskii
2020-02-03 21:51                   ` Dmitry Gutov
2020-02-04  3:27                     ` Eli Zaretskii
2020-02-04 13:19                       ` Dmitry Gutov
2020-02-04 15:40                         ` Eli Zaretskii
2020-02-04 23:55                           ` Dmitry Gutov
2020-02-05  3:36                             ` Eli Zaretskii
2020-02-10 15:44           ` Eli Zaretskii
2020-02-11 23:42             ` Dmitry Gutov [this message]
2020-02-12 18:18               ` Eli Zaretskii
2020-02-12 18:24                 ` Dmitry Gutov
2020-02-12 19:42                   ` Eli Zaretskii
2020-03-03 14:02                   ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42a997dd-0667-da4d-7605-aa8267018869@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=39379@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=wyuenho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).