From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#69584: 29.2.50; project-find-functions should have access to maybe-prompt Date: Fri, 5 Apr 2024 03:33:49 +0300 Message-ID: <428f4138-1dfa-4d10-8fe6-c957ff28046c@gutov.dev> References: <65b29bab-3149-49e3-a6ae-6c0c1485e6f2@gutov.dev> <875xxmjoc9.fsf@catern.com> <34e15612-77bc-4a67-b493-e00c97d1155e@gutov.dev> <28cf57b9-de16-46a5-9bb8-918827143f72@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32526"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: sbaugh@catern.com, 69584@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 05 02:35:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsXXx-0008CO-Uk for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Apr 2024 02:35:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsXXn-0002gE-Tu; Thu, 04 Apr 2024 20:34:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsXXm-0002g1-J4 for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 20:34:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsXXm-0002zM-Ac for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 20:34:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsXXr-00024N-HV for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 20:35:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2024 00:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69584 X-GNU-PR-Package: emacs Original-Received: via spool by 69584-submit@debbugs.gnu.org id=B69584.17122772467552 (code B ref 69584); Fri, 05 Apr 2024 00:35:03 +0000 Original-Received: (at 69584) by debbugs.gnu.org; 5 Apr 2024 00:34:06 +0000 Original-Received: from localhost ([127.0.0.1]:34971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsXWw-0001xi-3z for submit@debbugs.gnu.org; Thu, 04 Apr 2024 20:34:06 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:35675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsXWu-0001xA-1P for 69584@debbugs.gnu.org; Thu, 04 Apr 2024 20:34:05 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id EC60E3200A3F; Thu, 4 Apr 2024 20:33:52 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 04 Apr 2024 20:33:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712277232; x=1712363632; bh=Ryu3h7YzSLcgdz66vNYHssoGfHQ29mlNe4X4agLa5XM=; b= l6UytEZMHxnIPy9bPZKGVNh3+q4iAusymYRFoFpXXkr4vEALUlEtDk2RrNztZRnD +pgZ3TSizsEjI2VpAv+gDAUL4sfYeIVceabi2yUpbCB46ziwyahDVsOn4/0ldlct erZMR1be5GAsyqnz0bTVLTcKnMFYArcEmne+mufk7WdDWwQRx3qEkW59brDP4xDV UB4EpiEmCsYv/5OZ8exc3zexAoOuFxV8X/uefKzBYjLlLfegBigeYh/0g29Gim0v 5UNPZ3y8AIUz6YkVKUFE40uPEtQedosW9x4TqwtOrHkyvy4na3DZsJm9gSYkLK69 RJtgYSRUuNkUJQiHMOwgng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712277232; x= 1712363632; bh=Ryu3h7YzSLcgdz66vNYHssoGfHQ29mlNe4X4agLa5XM=; b=o kUX/l+izr9YIW/Vd9OhOks/cjHgnQPsC0ZTxhiHerq/krc/IPaCuKesigUy01kP6 egCbNCNDW8r6ezK8ptb3Ql0Thd/8GGRE/P/gw5GxfYzQh4FKicSVGdVgJ56J8kex 2TdMKU4PA9NOUagwmIob4RPHgQqII9lKmtqfxbU5uvBFG1wVwqAghHHYNjV7hj6o azNEWwqyH5q6DnYm+9gdSfayPlVusZGVBPFX52iHvNEW6OgMTySsbTW0hvIJTSLD DCWP03qOD+9m4eAZY4c7loTuaw5hQZ+PXZk2bsGsOtQSRqXLpBulzAQ2wRt6LArj fk8nHzTqEWXG4o6zvvL4A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefledgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Apr 2024 20:33:50 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282683 Archived-At: On 04/04/2024 17:29, Spencer Baugh wrote: > Dmitry Gutov writes: >> On 22/03/2024 15:05, Spencer Baugh wrote: >>>> If this change will be enough to cover your scenario, let's go ahead >>>> and add the 'non-essential' binding. It does seem to make sense for >>>> Tramp, at least. >>> Yes, that completely covers my scenario. (Putting aside whether my >>> scenario is a good idea 🙂 ) >>> So I would be happy with that. >> Now pushed to master as commit 1552f8345d8. > Ah, I think this is not quite right, should be: > > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 1da03c7b60e..3cd6dafb409 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -229,8 +229,8 @@ project-current > of the project instance object." > (unless directory (setq directory (or project-current-directory-override > default-directory))) > - (let ((pr (project--find-in-directory directory)) > - (non-essential (not maybe-prompt))) > + (let* ((non-essential (not maybe-prompt)) > + (pr (project--find-in-directory directory))) > (cond > (pr) > ((unless project-current-directory-override Right! Thanks for the correction (21f9be00531 in master).