From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#26018: Emacs workaround for Solaris 10 is unnecessary Date: Tue, 7 Mar 2017 09:05:01 -0800 Organization: UCLA Computer Science Department Message-ID: <42889902-fc49-5271-f603-ab4358c265ca@cs.ucla.edu> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1488906379 23808 195.159.176.226 (7 Mar 2017 17:06:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 7 Mar 2017 17:06:19 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 Cc: 26018@debbugs.gnu.org To: "Burt, Timothy C - GS" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 07 18:06:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIYp-0004zh-Gz for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Mar 2017 18:06:07 +0100 Original-Received: from localhost ([::1]:51852 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIYv-0007dX-HM for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 Mar 2017 12:06:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIYp-0007dR-Mm for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:06:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clIYk-0007Yl-L8 for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:06:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1clIYk-0007Yh-HW for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1clIYk-0006En-AO for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2017 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 26018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: Emacs bug reports Original-Received: via spool by submit@debbugs.gnu.org id=B.148890634823954 (code B ref -1); Tue, 07 Mar 2017 17:06:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 Mar 2017 17:05:48 +0000 Original-Received: from localhost ([127.0.0.1]:44864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIYW-0006EH-6R for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:48 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:55539) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1clIYT-0006E5-N5 for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clIYN-0007Ql-9s for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:40 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:45250) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clIYN-0007Qg-6u for submit@debbugs.gnu.org; Tue, 07 Mar 2017 12:05:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clIYL-0007bv-Nd for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:05:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clIYG-0007Nx-Qm for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:05:37 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51774) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1clIYG-0007Mu-H2 for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2017 12:05:32 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C21AA160069; Tue, 7 Mar 2017 09:05:26 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ew7TyK4Xx6Xc; Tue, 7 Mar 2017 09:05:24 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8E38516009A; Tue, 7 Mar 2017 09:05:24 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jDEXHZ2domwd; Tue, 7 Mar 2017 09:05:24 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 71970160069; Tue, 7 Mar 2017 09:05:24 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130321 Archived-At: Going back to the old bug report copied below, because I'm trying to simplify the isnan code in Emacs. I cannot reproduce the problem on Solaris 10 sparc with the bundled GCC 3.4.3 (/usr/sfw/bin/gcc, which reports "gcc (GCC) 3.4.3 (csl-sol210-3_4-branch+sol_rpath)". So I am inclined to think that the compiler mentioned below wasn't installed correctly. I notice, for example, that when I run the command 'nm floatfns.o' the output does not contain the symbols __builtin_isnan or __builtin_isfinite. Instead, the Fisnan function contains open code that tests where a register contains a NaN, which is what I would expect GCC to do. So I am now inclined to think that the bug report is a false alarm. I'll CC: this to bug-gnu-emacs so that this gets a bug number. On 10/22/2013 06:43 PM, Burt, Timothy C - GS wrote: > Paul --- > > My apologies if you are not involved with emacs development or even care to be notified of what seems to be a regression to one of your fixes. But if you're still willing to read on then can I presume on you to point me in the right direction to report this? > > In short, while compiling emacs 24.3 on a Sparc Solaris 10 machine with gcc v3.4.3 I encountered fatal errors[fn:1] with __builtin_isnan and __builtin_isfinite being undefined symbols. I found your fix for isnan, but the code base I used (from http://gnu.spinellicreations.com/emacs/emacs-24.3.tar.gz) had isnan surrounded by an #ifndef/#endif guard instead of your #undef solution. So, I changed it back and did the same for isfinite then the compilation was successful. I think this is a bug but I hesitated to use bug-gnu-emacs@gnu.org since that seemed to be for emacs, not necessarily emacs development. Would you be able to point me in the right direction? > > > Thank you, > and I'm sorry for the cold call. > > > > [fn:1] Internal compilation notes that include error at temacs step: > + IMPORTANT: For Solaris 10 with gcc v3.4.3 the following changes need > to be made to src/floatfns.c > : 37c37 > : < #ifndef isfinite > : --- > : > #undef isfinite > : 39,40c39 > : < #endif > : < #ifndef isnan > : --- > : > #undef isnan > : 42d40 > : < #endif > - Paul Eggert noticed an fixed a problem with isnan (see > http://lists.gnu.org/archive/html/emacs-diffs/2011-09/msg00041.html). > However, somewhere between that fix and the code base used here a > minor, but vital, change was made that broke the compilation on > Solaris 10 with gcc v3.4.3. Specifically, isnan should have > been #undef'd. The changes above take away the #ifndef/#endif > guards and replace them with a leading #undef for both isnan and > isfinite since they both contribute to the fatal error making > temacs. > #+begin_src text > cc -std=gnu99 -Demacs -I. -I/vendor/emacs-24.3/emacs-24.3/src -I../lib -I/vendor/emacs-24.3/emacs-24.3/src/../lib -I/usr/openwin/include -I/usr/include/libxml2 -MMD -MF deps/.d -MP -g3 -O2 -L/usr/openwin/lib \ > -o temacs dispnew.o frame.o scroll.o xdisp.o menu.o xmenu.o window.o charset.o coding.o category.o ccl.o character.o chartab.o bidi.o cm.o term.o terminal.o xfaces.o xterm.o xfns.o xselect.o xrdb.o xsmfns.o xsettings.o xgselect.o emacs.o keyboard.o macros.o keymap.o sysdep.o buffer.o filelock.o insdel.o marker.o minibuf.o fileio.o dired.o cmds.o casetab.o casefiddle.o indent.o search.o regex.o undo.o alloc.o data.o doc.o editfns.o callint.o eval.o floatfns.o fns.o font.o print.o lread.o syntax.o unexsol.o bytecode.o process.o gnutls.o callproc.o region-cache.o sound.o atimer.o doprnt.o intervals.o textprop.o composite.o xml.o profiler.o xfont.o fontset.o fringe.o image.o terminfo.o lastfile.o widget.o ../lib/libgnu.a ../lwlib/liblw.a -ltiff -ljpeg -lpng -lz - lm -lXpm -lXaw -lXmu -lXt -lSM -lICE -lXext -lX11 -lrt -lrt -lxml2 -lpthread -lz -lm -lsocket -lnsl -lresolv -lsocket -lnsl -lncurses -lfontconfig -lpthread -lm > Undefined first referenced > symbol in file > __builtin_isnan floatfns.o > __builtin_isfinite floatfns.o > ld: fatal: Symbol referencing errors. No output written to temacs > collect2: ld returned 1 exit status > gmake[1]: *** [temacs] Error 1 > gmake[1]: Leaving directory `/ssd/system/vendor/emacs-24.3/emacs-24.3/src' > gmake: *** [src] Error 2 > #+end_src > > > > Timothy C. Burt, PhD > Senior Staff Scientist > timothy.burt@exelisinc.com > (585) 269-5230 > > > > ________________________________ > > This e-mail and any files transmitted with it may be proprietary and are intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender. Please note that any views or opinions presented in this e-mail are solely those of the author and do not necessarily represent those of Exelis Inc. The recipient should check this e-mail and any attachments for the presence of viruses. Exelis Inc. accepts no liability for any damage caused by any virus transmitted by this e-mail.