From: Gregory Heytings <gregory@heytings.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, harven@free.fr, 48042@debbugs.gnu.org
Subject: bug#48042: 26.3; Macros don't work with french-postfix input method
Date: Fri, 14 May 2021 14:16:26 +0000 [thread overview]
Message-ID: <425cd7715b4c15a15813@heytings.org> (raw)
In-Reply-To: <83y2chxvg4.fsf@gnu.org>
>
> If you search the Lisp files for unread-command-events,
>
Of course I did this.
>
> you will see how many features unrelated to input methods do add stuff
> to unread-command-events. What if an input method were active while one
> of those unrelated features does that?
>
As I just said to Stefan, we could perhaps wait for an actual bug report
to see whether this happens? I tried to fix this bug, it still seems to
me that what I proposed is TRT because it fixes the problem at its "root",
but I cannot fix yet unknown bugs.
>
> That part didn't exist because once upon a time we recorded everything
> immediately as it happened. When that changed (for a good reason, as
> described in the discussion cited by the commit log message), we needed
> to keep track of what was and what wasn't recorded. So restoring the
> behavior back to what it was then doesn't help me to gain confidence in
> the correctness of the patch, sorry. Going back to what we had there is
> certainly not something we should do.
>
We're not going back to what we had earlier, the patch goes back to what
we had only when an input method is activated.
>
> Hmm... but the from_macro label seems to indicate that this code runs
> for macros as well, even when input method is not active?
>
And in that case, given that the condition checks whether an input method
is active, the event will be recorded.
>
> So you are saying we should bind the variable there as well?
>
I don't know, and didn't test that. As I said above, it seems to me that
fixing a bug at its "root" is much better than trying to add code
elsewhere to circumvent the bug.
>
> Thanks.
>
What do you expect me to do now?
next prev parent reply other threads:[~2021-05-14 14:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 18:05 bug#48042: 26.3; Macros don't work with french-postfix input method harven
2021-04-26 18:22 ` Eli Zaretskii
2021-04-28 18:24 ` harven
2021-05-14 9:29 ` Gregory Heytings
2021-05-14 9:55 ` Basil L. Contovounesios
2021-05-14 10:03 ` Gregory Heytings
2021-05-14 11:09 ` Eli Zaretskii
2021-05-14 13:38 ` Gregory Heytings
2021-05-14 13:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-14 14:08 ` Gregory Heytings
2021-05-14 14:12 ` Eli Zaretskii
2021-05-14 14:04 ` Eli Zaretskii
2021-05-14 14:16 ` Gregory Heytings [this message]
2021-05-14 14:36 ` Eli Zaretskii
2021-05-14 15:00 ` Gregory Heytings
2021-05-14 15:11 ` Eli Zaretskii
2021-05-14 15:51 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-14 15:59 ` Eli Zaretskii
2021-05-14 17:07 ` Gregory Heytings
2021-05-14 17:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-15 9:46 ` Gregory Heytings
2021-05-15 10:21 ` Eli Zaretskii
2021-05-15 18:47 ` Gregory Heytings
2021-05-15 18:52 ` Eli Zaretskii
2021-05-15 20:17 ` Gregory Heytings
2021-05-29 8:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=425cd7715b4c15a15813@heytings.org \
--to=gregory@heytings.org \
--cc=48042@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=harven@free.fr \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).