* bug#29222: 26.0.90; doc string of `search-invisible'
@ 2017-11-09 5:00 Drew Adams
2017-11-10 10:06 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2017-11-09 5:00 UTC (permalink / raw)
To: 29222
This part of the doc string:
When the value is 'open', if the text matched is made invisible by an
overlay having an 'invisible' property and that overlay has a property
'isearch-open-invisible', then incremental search will show the
contents.
would be clearer if it said "an overlay having a non-nil 'invisible'
property" and "...has a non-nil property `isearch-open-invisible'.
Having a property is a bit ambiguous, or at least can be thought so.
Sure, it's true that one cannot tell the difference between not having
a property `foo' and having a property `foo' that has a value of nil.
Still, it's better to be explicit here, I think.
In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32)
of 2017-10-13 built on LAPHROAIG
Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window, C-M-v to scroll help.
Configured using:
'configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static -g3''
Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#29222: 26.0.90; doc string of `search-invisible'
2017-11-09 5:00 bug#29222: 26.0.90; doc string of `search-invisible' Drew Adams
@ 2017-11-10 10:06 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2017-11-10 10:06 UTC (permalink / raw)
To: Drew Adams; +Cc: 29222-done
> Date: Wed, 8 Nov 2017 21:00:29 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
>
> This part of the doc string:
>
> When the value is 'open', if the text matched is made invisible by an
> overlay having an 'invisible' property and that overlay has a property
> 'isearch-open-invisible', then incremental search will show the
> contents.
>
> would be clearer if it said "an overlay having a non-nil 'invisible'
> property" and "...has a non-nil property `isearch-open-invisible'.
Thanks, done on the release branch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-10 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-09 5:00 bug#29222: 26.0.90; doc string of `search-invisible' Drew Adams
2017-11-10 10:06 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).