From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52293: 29.0.50; [PATCH v3] Prevent further cases of duplicated separators in context menus Date: Sat, 11 Dec 2021 20:02:41 -0800 Message-ID: <414be477-34d4-c777-f623-3e0e59c0dd08@gmail.com> References: <86tufn5jn9.fsf@mail.linkov.net> <86pmqa14fc.fsf@mail.linkov.net> <15eebcb1-b67a-8363-bc23-cf113913856f@gmail.com> <86h7bkhlo7.fsf@mail.linkov.net> <37047ada-fa33-88dd-5237-769611fec61b@gmail.com> <83wnkfw8ud.fsf@gnu.org> <86ilvysyq3.fsf@mail.linkov.net> <834k7ix4ij.fsf@gnu.org> <86pmq6taeb.fsf@mail.linkov.net> <83czm6unfs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21159"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52293@debbugs.gnu.org To: Eli Zaretskii , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 12 05:03:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mwG4r-0005FP-SX for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Dec 2021 05:03:09 +0100 Original-Received: from localhost ([::1]:41324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mwG4q-0000mX-Vx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Dec 2021 23:03:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mwG4k-0000hv-2U for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 23:03:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mwG4j-0008JF-M5 for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 23:03:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mwG4j-0003Tc-Jk for bug-gnu-emacs@gnu.org; Sat, 11 Dec 2021 23:03:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Dec 2021 04:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52293 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52293-submit@debbugs.gnu.org id=B52293.163928177413349 (code B ref 52293); Sun, 12 Dec 2021 04:03:01 +0000 Original-Received: (at 52293) by debbugs.gnu.org; 12 Dec 2021 04:02:54 +0000 Original-Received: from localhost ([127.0.0.1]:50414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwG4c-0003TF-03 for submit@debbugs.gnu.org; Sat, 11 Dec 2021 23:02:54 -0500 Original-Received: from mail-pf1-f175.google.com ([209.85.210.175]:37796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mwG4V-0003Sw-UD for 52293@debbugs.gnu.org; Sat, 11 Dec 2021 23:02:51 -0500 Original-Received: by mail-pf1-f175.google.com with SMTP id 8so12034884pfo.4 for <52293@debbugs.gnu.org>; Sat, 11 Dec 2021 20:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=pv4hjqWf6MAovgbe6XwqJYRb1e/Zs9pN42Vq21HcO0c=; b=OBn7/nXyKZmDT0Ocoyg0mU0iXZJXEE1uruif3nscuqVlgZ/oAFzRBLBXOrs/caqwSm QA6utslA8fWPLhq7YUf2LpTA96+6XragbsxbfGtOBqg1PRGh4q+9jDqY1X/vK2eOMB9b JIgkDpQScVNAqhulWcRYNAIGfjuvRkOYSa70Nw7zFaAYC0mrfa9cSL/ik3FEMaz9ZfUx nh6bc5hEyBGN4HfefZdE/9QPfQ6I/4xJQG2GLO2gt/rOni+ae8dtmtXltnEO/nz/W4gV g6NE/dFswC+axJaNk6BfdBJooO36RJ/Swg9MmCev0cpu21ksNwXWLxOwzO+p4q1LWEYT lvqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pv4hjqWf6MAovgbe6XwqJYRb1e/Zs9pN42Vq21HcO0c=; b=nx5TcfiwCcsuH6688syuvq2yfkSAlZhUHGMWjXsSl4htsfi7Bfh2iJDvHra/s6BRtH i8lhHpFGUK9uL+gPH1MZCFjYQlJIsvxIuoz2QtsA5+0w6psJ08UUKUoLI3XreLgv6/HU f7Lp13EH/0KfVm+Ogsp+O7BO8ZtMNGxKag+bOfrpz3W5E5PWPerwpKJA4T3haIfYROGG 57aNQiMBttD8pif1oWKBYFA5P2FLU58dKzXuq2QQ3wClPzqVqpzHt1WcKbLiyN2Lk7Nd VyvRLXTp0cslF1x5cCWnayQbLbAmw+MvapiBFQHVwUA5tXwU2a9I/vqF48KgFalVxbl8 utmw== X-Gm-Message-State: AOAM530xF6BT6PErXEHKy2rH3KbWL5Y4DQGfpUzQp1sLzwSqoS1Nh58R S3RsHoTKFOZhI3QxURfuYnliriE7UMQ= X-Google-Smtp-Source: ABdhPJzrPuCz5jvX7W3SfSagK/4skGuCz6yqsXOAmpSv4SYbeKiUSTuwIsMOXZW6plLdX2KBYlFAyw== X-Received: by 2002:a63:2162:: with SMTP id s34mr4616437pgm.277.1639281761954; Sat, 11 Dec 2021 20:02:41 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id cv1sm3107674pjb.48.2021.12.11.20.02.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Dec 2021 20:02:41 -0800 (PST) In-Reply-To: <83czm6unfs.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222162 Archived-At: On 12/9/2021 1:39 AM, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc: jporterbugs@gmail.com, 52293@debbugs.gnu.org >> Date: Thu, 09 Dec 2021 11:06:36 +0200 >> >>> I'd prefer all of those to go to master. I'm quite sure this is not >>> the last time we hear that something in those quarters needs to be >>> fixed (I think the feature wasn't mature enough to go to Emacs 28 in >>> the first place, but that's water under the bridge now). No >>> catastrophe will happen if this will be fixed after 28.1, or even in >>> 29.1. >> >> Do you think that [separator-global] should be renamed to [global-separator] >> only in master? > > Yes. This way, we have quite some time before us to let people bump > into any problems this could cause and report back to us. That's ok by me. Note that this[1] is a very mildly incompatible change, so as long as people are aware of that, I think it should be ok to merge into 29, and hopefully into 28.2. The only incompatibility would be people wanting to add context menu items after certain specific separators like `global-separator' or `undo-separator'. I think that's fairly unlikely though, since: a) `context-menu-mode' is new so there aren't many (any?) third-party packages that use it yet. b) `context-menu-mode' doesn't guarantee that any particular items are actually present in the menu. Users can customize the context menu, so it could have anything at all in it. Relying on the presence of `global-separator' (however it's named) would be somewhat risky. `middle-separator' and `top-separator' (the latter is from the patch in this bug) are/will be at least *likely* to be present though, so are more likely to be used in third-party code. If there are any other issues with the latest patch in this bug (or bug#52286), just let me know. [1] bug#52286, that is.