From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Wed, 03 Mar 2021 19:34:30 +0000 Message-ID: <4119ea30553e3f90ab8c@heytings.org> References: <87im69uzlt.fsf@mail.linkov.net> <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="G0L0IVQL72" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7340"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 03 20:35:08 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHXH2-0001nG-GD for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 20:35:08 +0100 Original-Received: from localhost ([::1]:44982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHXH1-0001z1-J5 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Mar 2021 14:35:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHXGw-0001yv-5V for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 14:35:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45486) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHXGv-0005Hl-UW for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 14:35:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHXGv-0003Ai-Rn for bug-gnu-emacs@gnu.org; Wed, 03 Mar 2021 14:35:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Mar 2021 19:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.161480007512151 (code B ref 46859); Wed, 03 Mar 2021 19:35:01 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 3 Mar 2021 19:34:35 +0000 Original-Received: from localhost ([127.0.0.1]:57032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHXGU-00039u-Op for submit@debbugs.gnu.org; Wed, 03 Mar 2021 14:34:34 -0500 Original-Received: from heytings.org ([95.142.160.155]:41796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHXGS-00039l-3j for 46859@debbugs.gnu.org; Wed, 03 Mar 2021 14:34:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20210101; t=1614800071; bh=1ClAw3RPSUscBSP7kAeCdHcqgKQyynIyTdjzHZclfCg=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=sf6h9AjJRBJlqIkWETzgpj6vTRwz1d0gwYhyXB6H5gwjlOta4WXnK52b45GyIofAQ 2Q2SZoVLGX2SIm198271v2PDloKWXPNGVKNUN8Esjvh8SV47HdRuE1k8XVCBQkqREh N5kDq1EbO3yN2rTMcBM0lZZj+zEz5UHLZNQEyqzC/QQA0Yk+2c7aAybGXzvGAdDiZf APSh3E3ZZubjzMVs3Y5D0Jbek74d/JVOwKJKCMfxkDu3p7Vipte10qvJWXYq4D7st1 EedBdFcjNabFykYdaXe7z2hYoXdMTNnnBwQuTj3AYjfyQVFBJ1EiN+wGdfFeljeTew zx9GB8ZQ1jIQA== In-Reply-To: <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> Content-ID: <4119ea30550b7a3e6ebb@heytings.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201310 Archived-At: --G0L0IVQL72 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-ID: <4119ea305501a07f8b35@heytings.org> >> Yes.=C2=A0 You get, for each match: the line number (from the beginning = of=20 >> the file), the byte offset (from the beginning of the file) of the=20 >> first displayed character, and the context of the match. > > OK, so we get the byte offset, but not the length of the match (which=20 > we'll also need later, for purposes such as highlighting and=20 > replacement). And what happens if there are several matches on the same= =20 > line? We need columns for all of them. > I don't know exactly what you want to do, I initially chimed in this=20 conversation to react to Juri's "GNU grep has no option to truncate=20 output", to mention that GNU grep does have an option to do this; perhaps= =20 it doesn't do exactly what you want. I could be wrong, but I believe that adapting what you want to what GNU=20 grep provides will always be more efficient than the opposite. >> And you can easily get the byte offset of each beginning of line with=20 >> "grep -nbo '^.'", so calculating the byte offset from the beginning of= =20 >> the line is easy. > > Do you mean to suggest we call grep one more time for each matching=20 > line? > No, once for each file. "grep -nbo '^.' FILE" returns a "::" line for each line in FILE. With this you=20 can easily calculate the offset of a match on a given line. This will be= =20 more efficient than calculating the offset of a match by parsing each line= =20 with Elisp code. --G0L0IVQL72--